From: Alistair Francis <alistair23@gmail.com>
To: Lukasz Majewski <lukma@denx.de>
Cc: Joseph Myers <joseph@codesourcery.com>,
Paul Eggert <eggert@cs.ucla.edu>,
Adhemerval Zanella <adhemerval.zanella@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
Alistair Francis <alistair.francis@wdc.com>,
GNU C Library <libc-alpha@sourceware.org>,
Florian Weimer <fweimer@redhat.com>,
"Carlos O'Donell" <carlos@redhat.com>,
Stepan Golosunov <stepan@golosunov.pp.ru>,
Andreas Schwab <schwab@suse.de>, Zack Weinberg <zackw@panix.com>
Subject: Re: [PATCH 2/2] lowlevellock-futex: Remove not used macros
Date: Tue, 1 Dec 2020 08:47:36 -0800 [thread overview]
Message-ID: <CAKmqyKN+y=d=2OKUvn=OmQTX2xSV68Y_5hH4drg=UnDSRSZE2A@mail.gmail.com> (raw)
In-Reply-To: <20201201121727.25155-2-lukma@denx.de>
On Tue, Dec 1, 2020 at 4:18 AM Lukasz Majewski <lukma@denx.de> wrote:
>
> Following macros: lll_futex_timed_lock_pi, lll_futex_clock_wait_bitset,
> lll_futex_wait_requeue_pi, lll_futex_timed_wait_requeue_pi are not
> used anymore so are eligible for removal.
>
> Build tests:
> ./src/scripts/build-many-glibcs.py glibcs
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> sysdeps/nptl/lowlevellock-futex.h | 43 -------------------------------
> 1 file changed, 43 deletions(-)
>
> diff --git a/sysdeps/nptl/lowlevellock-futex.h b/sysdeps/nptl/lowlevellock-futex.h
> index 2209ca76a1..d09e9a8749 100644
> --- a/sysdeps/nptl/lowlevellock-futex.h
> +++ b/sysdeps/nptl/lowlevellock-futex.h
> @@ -94,28 +94,6 @@
> # define lll_futex_supported_clockid(clockid) \
> ((clockid) == CLOCK_REALTIME || (clockid) == CLOCK_MONOTONIC)
>
> -/* The kernel currently only supports CLOCK_MONOTONIC or
> - CLOCK_REALTIME timeouts for FUTEX_WAIT_BITSET. We could attempt to
> - convert others here but currently do not. */
> -# define lll_futex_clock_wait_bitset(futexp, val, clockid, timeout, private) \
> - ({ \
> - long int __ret; \
> - if (lll_futex_supported_clockid (clockid)) \
> - { \
> - const unsigned int clockbit = \
> - (clockid == CLOCK_REALTIME) ? FUTEX_CLOCK_REALTIME : 0; \
> - const int op = \
> - __lll_private_flag (FUTEX_WAIT_BITSET | clockbit, private); \
> - \
> - __ret = lll_futex_syscall (6, futexp, op, val, \
> - timeout, NULL /* Unused. */, \
> - FUTEX_BITSET_MATCH_ANY); \
> - } \
> - else \
> - __ret = -EINVAL; \
> - __ret; \
> - })
> -
> /* Wake up up to NR waiters on FUTEXP. */
> # define lll_futex_wake(futexp, nr, private) \
> lll_futex_syscall (4, futexp, \
> @@ -138,32 +116,11 @@
> FUTEX_OP_CLEAR_WAKE_IF_GT_ONE)
>
>
> -/* Priority Inheritance support. */
> -#define lll_futex_timed_lock_pi(futexp, abstime, private) \
> - lll_futex_syscall (4, futexp, \
> - __lll_private_flag (FUTEX_LOCK_PI, private), \
> - 0, abstime)
> -
> #define lll_futex_timed_unlock_pi(futexp, private) \
> lll_futex_syscall (4, futexp, \
> __lll_private_flag (FUTEX_UNLOCK_PI, private), \
> 0, 0)
>
> -/* Like lll_futex_wait (FUTEXP, VAL, PRIVATE) but with the expectation
> - that lll_futex_cmp_requeue_pi (FUTEXP, _, _, MUTEX, _, PRIVATE) will
> - be used to do the wakeup. Confers priority-inheritance behavior on
> - the waiter. */
> -# define lll_futex_wait_requeue_pi(futexp, val, mutex, private) \
> - lll_futex_timed_wait_requeue_pi (futexp, val, NULL, 0, mutex, private)
> -
> -/* Like lll_futex_wait_requeue_pi, but with a timeout. */
> -# define lll_futex_timed_wait_requeue_pi(futexp, val, timeout, clockbit, \
> - mutex, private) \
> - lll_futex_syscall (5, futexp, \
> - __lll_private_flag (FUTEX_WAIT_REQUEUE_PI \
> - | (clockbit), private), \
> - val, timeout, mutex)
> -
> /* Like lll_futex_requeue, but pairs with lll_futex_wait_requeue_pi
> and inherits priority from the waiter. */
> # define lll_futex_cmp_requeue_pi(futexp, nr_wake, nr_move, mutex, \
> --
> 2.20.1
>
next prev parent reply other threads:[~2020-12-01 16:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 12:17 [PATCH 1/2] futex: Remove not used futex_reltimed_wait{_cancelable} Lukasz Majewski
2020-12-01 12:17 ` [PATCH 2/2] lowlevellock-futex: Remove not used macros Lukasz Majewski
2020-12-01 12:52 ` Adhemerval Zanella
2020-12-01 16:47 ` Alistair Francis [this message]
2020-12-01 12:52 ` [PATCH 1/2] futex: Remove not used futex_reltimed_wait{_cancelable} Adhemerval Zanella
2020-12-01 16:39 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKmqyKN+y=d=2OKUvn=OmQTX2xSV68Y_5hH4drg=UnDSRSZE2A@mail.gmail.com' \
--to=alistair23@gmail.com \
--cc=adhemerval.zanella@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=arnd@arndb.de \
--cc=carlos@redhat.com \
--cc=eggert@cs.ucla.edu \
--cc=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=lukma@denx.de \
--cc=schwab@suse.de \
--cc=stepan@golosunov.pp.ru \
--cc=zackw@panix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).