From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd41.google.com (mail-io1-xd41.google.com [IPv6:2607:f8b0:4864:20::d41]) by sourceware.org (Postfix) with ESMTPS id 4E9523857C4F for ; Tue, 1 Dec 2020 16:59:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4E9523857C4F Received: by mail-io1-xd41.google.com with SMTP id j23so2315086iog.6 for ; Tue, 01 Dec 2020 08:59:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Sw4OxUkw/QfWlHMT82o90v17/21iQPONqlW9i5RzMrs=; b=henX2qFPOFDtLpK+prkhJfX6zQwuwZMAZhvTmqHTs8rgiLvf+E6aPDNn44j5tIYty0 b7LQtoJFWeQXtzIiW0X6uZaYJTUbg77MBQq1TKAcNGTPSSVOV8nGXmypUphNil01VtCH XyaLFluu+cLslUTwE4a5daYdNwcnBp7Drc+6aGxWneyLOLq7kLTlJIedWPgOBjK1TPsW 9b3NGnrPWiVgINuGc9Q2j/BqyY67Nu8W9D9XQUCoIMTvu5gqvIrgeLieEWG0VuDuWTO+ FtpYJ1niFydUeiSbG99BUxaDz3617C77fArfElEntvSMWx3cQyRMXRdh64DuhGm55xEe f51A== X-Gm-Message-State: AOAM5330T8Q1ttdvj1NDO3dmZ0NVsGrVv5LplmSZ6OnxGooTnAjtQ5Am v50F13mUrvXthVRzbK7wV1iYwXXG9h/M+Bt8+1I= X-Google-Smtp-Source: ABdhPJxCwqNWfi5isa46dLrSwfzw9zbPyQ2pQ+hZcIiNY7UseMmX7mlA3CvIfkUc8uncFZNt3aTYNcB2IUIcCOSlNZE= X-Received: by 2002:a6b:c994:: with SMTP id z142mr3090510iof.42.1606841993858; Tue, 01 Dec 2020 08:59:53 -0800 (PST) MIME-Version: 1.0 References: <20201201121727.25155-1-lukma@denx.de> <20201201121727.25155-2-lukma@denx.de> In-Reply-To: <20201201121727.25155-2-lukma@denx.de> From: Alistair Francis Date: Tue, 1 Dec 2020 08:47:36 -0800 Message-ID: Subject: Re: [PATCH 2/2] lowlevellock-futex: Remove not used macros To: Lukasz Majewski Cc: Joseph Myers , Paul Eggert , Adhemerval Zanella , Arnd Bergmann , Alistair Francis , GNU C Library , Florian Weimer , "Carlos O'Donell" , Stepan Golosunov , Andreas Schwab , Zack Weinberg Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Dec 2020 16:59:55 -0000 On Tue, Dec 1, 2020 at 4:18 AM Lukasz Majewski wrote: > > Following macros: lll_futex_timed_lock_pi, lll_futex_clock_wait_bitset, > lll_futex_wait_requeue_pi, lll_futex_timed_wait_requeue_pi are not > used anymore so are eligible for removal. > > Build tests: > ./src/scripts/build-many-glibcs.py glibcs Reviewed-by: Alistair Francis Alistair > --- > sysdeps/nptl/lowlevellock-futex.h | 43 ------------------------------- > 1 file changed, 43 deletions(-) > > diff --git a/sysdeps/nptl/lowlevellock-futex.h b/sysdeps/nptl/lowlevellock-futex.h > index 2209ca76a1..d09e9a8749 100644 > --- a/sysdeps/nptl/lowlevellock-futex.h > +++ b/sysdeps/nptl/lowlevellock-futex.h > @@ -94,28 +94,6 @@ > # define lll_futex_supported_clockid(clockid) \ > ((clockid) == CLOCK_REALTIME || (clockid) == CLOCK_MONOTONIC) > > -/* The kernel currently only supports CLOCK_MONOTONIC or > - CLOCK_REALTIME timeouts for FUTEX_WAIT_BITSET. We could attempt to > - convert others here but currently do not. */ > -# define lll_futex_clock_wait_bitset(futexp, val, clockid, timeout, private) \ > - ({ \ > - long int __ret; \ > - if (lll_futex_supported_clockid (clockid)) \ > - { \ > - const unsigned int clockbit = \ > - (clockid == CLOCK_REALTIME) ? FUTEX_CLOCK_REALTIME : 0; \ > - const int op = \ > - __lll_private_flag (FUTEX_WAIT_BITSET | clockbit, private); \ > - \ > - __ret = lll_futex_syscall (6, futexp, op, val, \ > - timeout, NULL /* Unused. */, \ > - FUTEX_BITSET_MATCH_ANY); \ > - } \ > - else \ > - __ret = -EINVAL; \ > - __ret; \ > - }) > - > /* Wake up up to NR waiters on FUTEXP. */ > # define lll_futex_wake(futexp, nr, private) \ > lll_futex_syscall (4, futexp, \ > @@ -138,32 +116,11 @@ > FUTEX_OP_CLEAR_WAKE_IF_GT_ONE) > > > -/* Priority Inheritance support. */ > -#define lll_futex_timed_lock_pi(futexp, abstime, private) \ > - lll_futex_syscall (4, futexp, \ > - __lll_private_flag (FUTEX_LOCK_PI, private), \ > - 0, abstime) > - > #define lll_futex_timed_unlock_pi(futexp, private) \ > lll_futex_syscall (4, futexp, \ > __lll_private_flag (FUTEX_UNLOCK_PI, private), \ > 0, 0) > > -/* Like lll_futex_wait (FUTEXP, VAL, PRIVATE) but with the expectation > - that lll_futex_cmp_requeue_pi (FUTEXP, _, _, MUTEX, _, PRIVATE) will > - be used to do the wakeup. Confers priority-inheritance behavior on > - the waiter. */ > -# define lll_futex_wait_requeue_pi(futexp, val, mutex, private) \ > - lll_futex_timed_wait_requeue_pi (futexp, val, NULL, 0, mutex, private) > - > -/* Like lll_futex_wait_requeue_pi, but with a timeout. */ > -# define lll_futex_timed_wait_requeue_pi(futexp, val, timeout, clockbit, \ > - mutex, private) \ > - lll_futex_syscall (5, futexp, \ > - __lll_private_flag (FUTEX_WAIT_REQUEUE_PI \ > - | (clockbit), private), \ > - val, timeout, mutex) > - > /* Like lll_futex_requeue, but pairs with lll_futex_wait_requeue_pi > and inherits priority from the waiter. */ > # define lll_futex_cmp_requeue_pi(futexp, nr_wake, nr_move, mutex, \ > -- > 2.20.1 >