From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 130497 invoked by alias); 18 Oct 2019 21:29:19 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 130483 invoked by uid 89); 18 Oct 2019 21:29:19 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.1 spammy=fsblkcnt_t, statfsh, fsfilcnt_t, UD:typesizes.h X-HELO: mail-lj1-f196.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aGK9txIysH2FImBpa8WgDCPJZK6pxnSgDOV0C78B39s=; b=TkFg8Txzp6pgdZZQvqKi2QBp3pqw/sYyoK7zswHm8XT7Xihli0/7DwBmXDcTcHU7iG ehdo5XXwCd6v+r7045IvLSDnqk4nfiQoIRH6tfd/9rFTeScH1SSDSDSNaJrG3kunMIyj D6f/FI8PykBA6gKLD+qLoyeD8DQCs5jb0eBEkf4tYkO56CQMcHcGa5MLBZE9EA8dsH0K yb11TSapgdwWu3byPr/AWqyH+uMwhxePpgXennt/TkKAfDiUckbCJmtF1nzvaao3wyRM qcKBJ/LEw4TRqx6+JIejWtvkAuGKRrAASAhhHPSqCZG8XAIeQ5S8JGv6c+bFX+18s9jS FR0A== MIME-Version: 1.0 References: <20191016234407.4306-1-alistair.francis@wdc.com> <20191016234407.4306-2-alistair.francis@wdc.com> In-Reply-To: From: Alistair Francis Date: Fri, 18 Oct 2019 21:29:00 -0000 Message-ID: Subject: Re: [PATCH v4 2/2] Define __STATFS_MATCHES_STATFS64 To: Joseph Myers Cc: Alistair Francis , GNU C Library , alistair23@gmaill.com Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2019-10/txt/msg00590.txt.bz2 On Fri, Oct 18, 2019 at 8:14 AM Joseph Myers wrote: > > On Wed, 16 Oct 2019, Alistair Francis wrote: > > > Add a new macro __STATFS_MATCHES_STATFS64 that specifies if fsblkcnt_t > > matches fsblkcnt64_t and if fsfilcnt_t matches fsfilcnt64_t. > > > > On a 32-bit platform with a 64-bit ino_t type (__STATFS_MATCHES_STATFS64 > > == 1) we want to update the statfs struct to remove the padding as it > > isn't required. As we don't have the padding we also need to update the > > overflow checker to not access the undefined members. > > > > * bits/typesizes.h: Define __STATFS_MATCHES_STATFS64 to handle > > 64-bit __fsblkcnt_t and __fsfilcnt_t types on 32-bit hosts. > > * sysdeps/unix/sysv/linux/generic/bits/statfs.h: Likewise. > > * sysdeps/unix/sysv/linux/generic/bits/typesizes.h: Likewise. > > * sysdeps/unix/sysv/linux/generic/wordsize-32/overflow.h: Likewise. > > * sysdeps/unix/sysv/linux/s390/bits/typesizes.h: Likewise. > > * sysdeps/unix/sysv/linux/sparc/bits/typesizes.h: Likewise. > > * sysdeps/unix/sysv/linux/x86/bits/typesizes.h: Likewise. > > Note that you no longer need to write ChangeLog entries. > > I don't follow the logic for which bits/typesizes.h headers you're > updating. You're updating some for architectures not using linux/generic, > which I think is the right thing to do - make them provide the defined > API, whether or not they currently use any code that actually tests the > __STATFS_MATCHES_STATFS64 macro. But you're not updating > sysdeps/unix/sysv/linux/alpha/bits/typesizes.h or > sysdeps/mach/hurd/bits/typesizes.h; I'd expect those to be updated as well > for consistency. I just missed those two, I have updated them. Alistair > > -- > Joseph S. Myers > joseph@codesourcery.com