From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x144.google.com (mail-il1-x144.google.com [IPv6:2607:f8b0:4864:20::144]) by sourceware.org (Postfix) with ESMTPS id 12C103857032 for ; Mon, 10 Aug 2020 15:27:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 12C103857032 Received: by mail-il1-x144.google.com with SMTP id c6so7853491ilo.13 for ; Mon, 10 Aug 2020 08:27:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QmoqyHcw0QkboS0KMyI0UrDtbEShjgJByWq8wOxPXGQ=; b=K693i3uQMJGTfo2cCFlmHPVQjrnYH4z6m9aCqN23T/4X1BUaj6QXSMcG2FEE47n+K4 KfizVsi4LU4hYy36wF+8peEMqcsSD5cSveDudS4WMa5Cdd8oZYlHV1MZqWLtw064vcqZ S18VzynZOdnepddlcVloszX4bi28Qijlbx+VJiNpQ9+Xb7KbpL2xHBqGajujnbmOfTeV 6j/O7TW0cC0XVoZ+WJ647VGAKr0iLiOjM7nmGvh42BC6VxTP/azYrwaVyo9vzmw602o7 w4gXzrOfZ7Mg6pW/9d9CXfQUTXdtMD0eOua5i0Apzw2Gj765KrAy7BbkZp51KRztOoSH pumg== X-Gm-Message-State: AOAM530qtV63QTHE4wwes6DwlGr8hPYmdno3tCBxSHTeEu3iMA0pranB Ct9Vmaq4jXGVMiV+epzCJSpCBex23vhFX26SDvU= X-Google-Smtp-Source: ABdhPJz4yv/Liw/szdB5nyMn2nhQGxluDe8UL9D60YRqLbLCq3rSASMwJ3WcJbrQWG3A+8f4hY2Jb1czs4IWyCVEriU= X-Received: by 2002:a05:6e02:f07:: with SMTP id x7mr18648647ilj.40.1597073239572; Mon, 10 Aug 2020 08:27:19 -0700 (PDT) MIME-Version: 1.0 References: <91a2de374c9ae48869743324f4a0edc185f63161.1594568655.git.alistair.francis@wdc.com> In-Reply-To: From: Alistair Francis Date: Mon, 10 Aug 2020 08:16:57 -0700 Message-ID: Subject: Re: [PATCH v3 02/19] RISC-V: Cleanup some of the sysdep.h code To: "Maciej W. Rozycki" Cc: Alistair Francis , GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Aug 2020 15:27:21 -0000 On Wed, Jul 15, 2020 at 6:07 PM Maciej W. Rozycki via Libc-alpha wrote: > > On Sun, 12 Jul 2020, Alistair Francis via Libc-alpha wrote: > > > --- > > sysdeps/unix/sysv/linux/riscv/sysdep.h | 14 +------------- > > 1 file changed, 1 insertion(+), 13 deletions(-) > > Please try to have at least a little explanation for posterity with > non-mechanical changes like this, e.g.: > > Remove a duplicate inclusion of which is already > pulled via , and the inclusion > of whose definition of `__set_errno' is not needed here. Added! > > It's not always easy for the reader to reproduce an environment needed to > bring the observations that have lead to the conclusion a given change is > the right one to make; they shouldn't have to anyway. > > > diff --git a/sysdeps/unix/sysv/linux/riscv/sysdep.h b/sysdeps/unix/sysv/linux/riscv/sysdep.h > > index 83e4adf6a2..429686cebe 100644 > > --- a/sysdeps/unix/sysv/linux/riscv/sysdep.h > > +++ b/sysdeps/unix/sysv/linux/riscv/sysdep.h > > @@ -107,19 +107,7 @@ > > # undef ret_ERRVAL > > # define ret_ERRVAL ret > > > > -#endif /* __ASSEMBLER__ */ > > - > > -/* In order to get __set_errno() definition in INLINE_SYSCALL. */ > > -#ifndef __ASSEMBLER__ > > -# include > > -#endif > > - > > -#include > > - > > -#undef SYS_ify > > -#define SYS_ify(syscall_name) __NR_##syscall_name > > This redefinition actually has to stay; sorry to be unclear about it. I > can see you have readded it with 03/19, but having things broken even for > the duration of a single commit will interfere with bisection. > > Please place it after the common inclusions at the top of this file. Fixed. Alistair > > Maciej