From: Alistair Francis <alistair23@gmail.com>
To: Lukasz Majewski <lukma@denx.de>
Cc: Joseph Myers <joseph@codesourcery.com>,
Paul Eggert <eggert@cs.ucla.edu>,
Adhemerval Zanella <adhemerval.zanella@linaro.org>,
Alistair Francis <alistair.francis@wdc.com>,
GNU C Library <libc-alpha@sourceware.org>,
Siddhesh Poyarekar <siddhesh@gotplt.org>,
Florian Weimer <fweimer@redhat.com>,
Florian Weimer <fw@deneb.enyo.de>,
Zack Weinberg <zackw@panix.com>,
"Carlos O'Donell" <carlos@redhat.com>,
Andreas Schwab <schwab@suse.de>
Subject: Re: [PATCH v3 1/7] y2038: Define __suseconds64_t type to be used with struct __timeval64
Date: Thu, 30 Jan 2020 18:01:00 -0000 [thread overview]
Message-ID: <CAKmqyKNbXMb34dVL_oi4N48BSbv1EwPzuYZydDaU0ga1K_OvMg@mail.gmail.com> (raw)
In-Reply-To: <20200129125914.11221-1-lukma@denx.de>
On Wed, Jan 29, 2020 at 4:59 AM Lukasz Majewski <lukma@denx.de> wrote:
>
> The __suseconds64_t type is supposed to be the 64 bit type across all
> architectures.
>
> It would be mostly used internally in the glibc - however, when passed to
> Linux kernel (very unlikely), if necessary, it shall be converted to 32
> bit type (i.e. __suseconds_t)
>
> Build tests:
> ./src/scripts/build-many-glibcs.py glibcs
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
>
> ---
> Changes for v3:
> - Fix indentation (from spaces to tab) for
> #define __SUSECONDS64_T_TYPE __SQUAD_TYPE
>
> Changes for v2:
> - New patch
> ---
> bits/typesizes.h | 1 +
> posix/bits/types.h | 1 +
> sysdeps/mach/hurd/bits/typesizes.h | 1 +
> sysdeps/unix/sysv/linux/alpha/bits/typesizes.h | 1 +
> sysdeps/unix/sysv/linux/generic/bits/typesizes.h | 1 +
> sysdeps/unix/sysv/linux/s390/bits/typesizes.h | 1 +
> sysdeps/unix/sysv/linux/sparc/bits/typesizes.h | 1 +
> sysdeps/unix/sysv/linux/x86/bits/typesizes.h | 1 +
> 8 files changed, 8 insertions(+)
>
> diff --git a/bits/typesizes.h b/bits/typesizes.h
> index 014c9aab21..599408973e 100644
> --- a/bits/typesizes.h
> +++ b/bits/typesizes.h
> @@ -50,6 +50,7 @@
> #define __TIME_T_TYPE __SLONGWORD_TYPE
> #define __USECONDS_T_TYPE __U32_TYPE
> #define __SUSECONDS_T_TYPE __SLONGWORD_TYPE
> +#define __SUSECONDS64_T_TYPE __SQUAD_TYPE
> #define __DADDR_T_TYPE __S32_TYPE
> #define __KEY_T_TYPE __S32_TYPE
> #define __CLOCKID_T_TYPE __S32_TYPE
> diff --git a/posix/bits/types.h b/posix/bits/types.h
> index adba926b45..a26cd383e4 100644
> --- a/posix/bits/types.h
> +++ b/posix/bits/types.h
> @@ -160,6 +160,7 @@ __STD_TYPE __ID_T_TYPE __id_t; /* General type for IDs. */
> __STD_TYPE __TIME_T_TYPE __time_t; /* Seconds since the Epoch. */
> __STD_TYPE __USECONDS_T_TYPE __useconds_t; /* Count of microseconds. */
> __STD_TYPE __SUSECONDS_T_TYPE __suseconds_t; /* Signed count of microseconds. */
> +__STD_TYPE __SUSECONDS64_T_TYPE __suseconds64_t;
>
> __STD_TYPE __DADDR_T_TYPE __daddr_t; /* The type of a disk address. */
> __STD_TYPE __KEY_T_TYPE __key_t; /* Type of an IPC key. */
> diff --git a/sysdeps/mach/hurd/bits/typesizes.h b/sysdeps/mach/hurd/bits/typesizes.h
> index b429379d7d..10f3ac231a 100644
> --- a/sysdeps/mach/hurd/bits/typesizes.h
> +++ b/sysdeps/mach/hurd/bits/typesizes.h
> @@ -50,6 +50,7 @@
> #define __TIME_T_TYPE __SLONGWORD_TYPE
> #define __USECONDS_T_TYPE __U32_TYPE
> #define __SUSECONDS_T_TYPE __SLONGWORD_TYPE
> +#define __SUSECONDS64_T_TYPE __SQUAD_TYPE
> #define __DADDR_T_TYPE __S32_TYPE
> #define __KEY_T_TYPE __S32_TYPE
> #define __CLOCKID_T_TYPE __S32_TYPE
> diff --git a/sysdeps/unix/sysv/linux/alpha/bits/typesizes.h b/sysdeps/unix/sysv/linux/alpha/bits/typesizes.h
> index 30356ba6d6..489e5d12e2 100644
> --- a/sysdeps/unix/sysv/linux/alpha/bits/typesizes.h
> +++ b/sysdeps/unix/sysv/linux/alpha/bits/typesizes.h
> @@ -49,6 +49,7 @@
> #define __TIME_T_TYPE __SLONGWORD_TYPE
> #define __USECONDS_T_TYPE __U32_TYPE
> #define __SUSECONDS_T_TYPE __S64_TYPE
> +#define __SUSECONDS64_T_TYPE __SQUAD_TYPE
> #define __DADDR_T_TYPE __S32_TYPE
> #define __KEY_T_TYPE __S32_TYPE
> #define __CLOCKID_T_TYPE __S32_TYPE
> diff --git a/sysdeps/unix/sysv/linux/generic/bits/typesizes.h b/sysdeps/unix/sysv/linux/generic/bits/typesizes.h
> index a916dea047..7c963e523e 100644
> --- a/sysdeps/unix/sysv/linux/generic/bits/typesizes.h
> +++ b/sysdeps/unix/sysv/linux/generic/bits/typesizes.h
> @@ -51,6 +51,7 @@
> #define __TIME_T_TYPE __SLONGWORD_TYPE
> #define __USECONDS_T_TYPE __U32_TYPE
> #define __SUSECONDS_T_TYPE __SLONGWORD_TYPE
> +#define __SUSECONDS64_T_TYPE __SQUAD_TYPE
> #define __DADDR_T_TYPE __S32_TYPE
> #define __KEY_T_TYPE __S32_TYPE
> #define __CLOCKID_T_TYPE __S32_TYPE
> diff --git a/sysdeps/unix/sysv/linux/s390/bits/typesizes.h b/sysdeps/unix/sysv/linux/s390/bits/typesizes.h
> index 45f70184ea..e775e460bb 100644
> --- a/sysdeps/unix/sysv/linux/s390/bits/typesizes.h
> +++ b/sysdeps/unix/sysv/linux/s390/bits/typesizes.h
> @@ -50,6 +50,7 @@
> #define __TIME_T_TYPE __SLONGWORD_TYPE
> #define __USECONDS_T_TYPE __U32_TYPE
> #define __SUSECONDS_T_TYPE __SLONGWORD_TYPE
> +#define __SUSECONDS64_T_TYPE __SQUAD_TYPE
> #define __DADDR_T_TYPE __S32_TYPE
> #define __KEY_T_TYPE __S32_TYPE
> #define __CLOCKID_T_TYPE __S32_TYPE
> diff --git a/sysdeps/unix/sysv/linux/sparc/bits/typesizes.h b/sysdeps/unix/sysv/linux/sparc/bits/typesizes.h
> index 1f3bbc8002..ac48c23e37 100644
> --- a/sysdeps/unix/sysv/linux/sparc/bits/typesizes.h
> +++ b/sysdeps/unix/sysv/linux/sparc/bits/typesizes.h
> @@ -50,6 +50,7 @@
> #define __TIME_T_TYPE __SLONGWORD_TYPE
> #define __USECONDS_T_TYPE __U32_TYPE
> #define __SUSECONDS_T_TYPE __S32_TYPE
> +#define __SUSECONDS64_T_TYPE __SQUAD_TYPE
> #define __DADDR_T_TYPE __S32_TYPE
> #define __KEY_T_TYPE __S32_TYPE
> #define __CLOCKID_T_TYPE __S32_TYPE
> diff --git a/sysdeps/unix/sysv/linux/x86/bits/typesizes.h b/sysdeps/unix/sysv/linux/x86/bits/typesizes.h
> index d084145597..87c50a4f32 100644
> --- a/sysdeps/unix/sysv/linux/x86/bits/typesizes.h
> +++ b/sysdeps/unix/sysv/linux/x86/bits/typesizes.h
> @@ -64,6 +64,7 @@
> #define __TIME_T_TYPE __SYSCALL_SLONG_TYPE
> #define __USECONDS_T_TYPE __U32_TYPE
> #define __SUSECONDS_T_TYPE __SYSCALL_SLONG_TYPE
> +#define __SUSECONDS64_T_TYPE __SQUAD_TYPE
> #define __DADDR_T_TYPE __S32_TYPE
> #define __KEY_T_TYPE __S32_TYPE
> #define __CLOCKID_T_TYPE __S32_TYPE
> --
> 2.20.1
>
next prev parent reply other threads:[~2020-01-30 17:59 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 12:59 Lukasz Majewski
2020-01-29 12:59 ` [PATCH v3 7/7] y2038: linux: Provide ___gettimeofday64 implementation Lukasz Majewski
2020-02-04 19:18 ` Adhemerval Zanella
2020-02-05 0:06 ` Lukasz Majewski
2020-02-05 16:23 ` Adhemerval Zanella
2020-02-05 16:58 ` Lukasz Majewski
2020-02-05 17:49 ` Adhemerval Zanella
2020-02-06 10:08 ` Lukasz Majewski
2020-02-07 13:20 ` Adhemerval Zanella
2020-02-06 21:41 ` Joseph Myers
2020-02-07 12:54 ` Adhemerval Zanella
2020-02-08 22:16 ` Lukasz Majewski
2020-02-10 16:15 ` Adhemerval Zanella
2020-02-10 16:57 ` Lukasz Majewski
2020-02-10 17:26 ` Adhemerval Zanella
2020-01-29 12:59 ` [PATCH v3 2/7] y2038: Introduce struct __timeval64 - new internal glibc type Lukasz Majewski
2020-01-30 18:01 ` Alistair Francis
2020-02-04 18:36 ` Adhemerval Zanella
2020-01-29 12:59 ` [PATCH v3 5/7] y2038: Provide conversion helpers for struct __timeval64 Lukasz Majewski
2020-02-04 18:48 ` Adhemerval Zanella
2020-01-29 12:59 ` [PATCH v3 6/7] y2038: linux: Provide __settimeofday64 implementation Lukasz Majewski
2020-02-04 18:52 ` Adhemerval Zanella
2020-01-29 12:59 ` [PATCH v3 4/7] y2038: alpha: Rename valid_timeval64_to_timeval to valid_timeval_to_timeval32 Lukasz Majewski
2020-01-30 21:41 ` Alistair Francis
2020-02-04 18:43 ` Adhemerval Zanella
2020-01-29 15:52 ` [PATCH v3 3/7] y2038: alpha: Rename valid_timeval_to_timeval64 to valid_timeval32_to_timeval Lukasz Majewski
2020-02-04 18:40 ` Adhemerval Zanella
2020-02-04 22:50 ` Lukasz Majewski
2020-02-05 16:11 ` Adhemerval Zanella
2020-01-30 18:01 ` Alistair Francis [this message]
2020-02-04 18:34 ` [PATCH v3 1/7] y2038: Define __suseconds64_t type to be used with struct __timeval64 Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKmqyKNbXMb34dVL_oi4N48BSbv1EwPzuYZydDaU0ga1K_OvMg@mail.gmail.com \
--to=alistair23@gmail.com \
--cc=adhemerval.zanella@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=carlos@redhat.com \
--cc=eggert@cs.ucla.edu \
--cc=fw@deneb.enyo.de \
--cc=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=lukma@denx.de \
--cc=schwab@suse.de \
--cc=siddhesh@gotplt.org \
--cc=zackw@panix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).