From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69238 invoked by alias); 4 Jan 2020 18:09:50 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 69228 invoked by uid 89); 4 Jan 2020 18:09:50 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.1 spammy=rv32, alistair, H*f:sk:CAKmqyK, RV32 X-HELO: mail-lf1-f52.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AXZraWM4WdeCPKCS2J4EfFMBjzbiQeTtJC6S3GuK5fo=; b=S/7IYgBqBNm6iD6glT+A8fNMEt1SQOwjgNZyUiBDdzuE2SAP7fq9OJdnHVuDtTj35s yetsR7lKzLE4hsPdsMBeBQheHKAj33Dch7ivQQzU+Re//jOv9/wNVM6PxEEUMf6DboTw 1qjWUo5k799zHXSWTa/UZpV7hYX+jshs5WY75APu6mN2q43mkV3b31xG5IB1Msod7j+B EzjL1LVVBRhwTwD3mu2qDBTfVjCvSjhZ7Y21fuvF/bLIUQfI6HB4lZ2SoM493TCqn68B VanJ/f06BJ76mSw0nN97ioI//MNXIvTETQwxwSPNACdUeVsMmoeeXvwjicwa07mtjtgb dYUg== MIME-Version: 1.0 References: In-Reply-To: From: Alistair Francis Date: Sat, 04 Jan 2020 18:09:00 -0000 Message-ID: Subject: Re: Math errors To: Szabolcs Nagy Cc: Joseph Myers , nd , GNU C Library Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2020-01/txt/msg00050.txt.bz2 On Fri, Jan 3, 2020 at 1:30 AM Szabolcs Nagy wrote: > > On 03/01/2020 02:18, Alistair Francis wrote: > > On Mon, Dec 30, 2019 at 2:29 PM Joseph Myers wrote: > >> > >> On Mon, 30 Dec 2019, Joseph Myers wrote: > >> > >>> On Mon, 30 Dec 2019, Alistair Francis wrote: > >>> > >>>> Hey, > >>>> > >>>> I'm running the `make check` tests on RV32 inside QEMU and about 800 > >>>> math tests are failing with errors along these lines: > >>> > >>> You need to generate libm-test-ulps for RV32 ("make regen-ulps") (also > >>> remember to create a corresponding libm-test-ulps-name file for use in > >>> generating the table in the manual). > >> > >> I should add: first try renaming the RV64 libm-test-ulps to make it > >> generic for both RV32 and RV64. You should only need a separate file for > >> RV32 if there is a clear reason for different results between the two. > > > > Thanks Joseph, > > > > I moved the RV64 one to be generic and that seems to fix most of the > > math tests. I tried `make regen-ulps` after that, just to be sure, and > > it didn't generate a diff. > > regen-ulps should create a math/NewUlps file. > (details are in math/README.libm-test) Yep, I just meant that I diffed that to the RV64 one. > > > > > There are a handful of math tests that seem to fail, but if I manually > > run the test a few times I will eventually get a pass. Any hints on > > what to do there? > > flaky math test is not normal, you need to investigate. It turns out that there is a difference between libm-test-ulps for RV32 and RV64. The gen-libm-test.py script was failing to run as I don't have Python2 installed, so the file wasn't being updated. If I manually run the script with Python3 I can generate a libm-test-ulps file that is somewhat different to the RV64 one. I'm running the tests now, but hopefully that fixes the failing math test cases. Alistair > > > > > Alistair > > > >> > >> -- > >> Joseph S. Myers > >> joseph@codesourcery.com >