From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-xa43.google.com (mail-vk1-xa43.google.com [IPv6:2607:f8b0:4864:20::a43]) by sourceware.org (Postfix) with ESMTPS id 1756A385DC1A for ; Tue, 7 Apr 2020 14:55:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1756A385DC1A Received: by mail-vk1-xa43.google.com with SMTP id f17so892949vkk.2 for ; Tue, 07 Apr 2020 07:55:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2Htk1oSlJpGBqpi/Z3HIwDEYlj/yT/e514aFMUjqzYA=; b=rl/ETsyJAvvjt0cqYyy4fnn7INwZiMb6psKR2fOSQ24xDbEDGtBnuAT2ZIhLfTJVph gFJ5dgVL5nGL0FjpqLs13mdBxrX03Q9es3+E0dQ1MPDCzI9Ggj1MxgvovCCGbHjAYKER xrVytIIGS9i9Y+bhozjad3mp2/+piXvDVqI7J/tyyVYPtNzuOmg/gVP/YiEG7APZuSVx +s62udJpNxCq8Ufz4X6UMn0hbZFUrrhkUVFEZa2UZw1Cp0EopekY5aW8/brxgnSvNfQK mTxMYOhavBXZg2ijbik6j3hKIoS3N0V+z91A0QDrUoGMT4wt6M/q9G6EtebQYJAMGTnt jGYg== X-Gm-Message-State: AGi0PuaOO9CQKajhEEKB6JrOfraFVMFtl6MSpS1/je2DEKASo6jPy+Ci exHFpS6T8N2P6dgvbOh+2ZdenqvjzlaFPSjQ9ek= X-Google-Smtp-Source: APiQypJWtalGDU2xPUtsf+LrrHXtJuxpQysIcHcNnpS3mZoPBf/S2isZaSe2Bzkp0val0j+CD5g28MzTQ0WHekTWQsU= X-Received: by 2002:a1f:a2d0:: with SMTP id l199mr1701749vke.77.1586271353652; Tue, 07 Apr 2020 07:55:53 -0700 (PDT) MIME-Version: 1.0 References: <20200407054010.2573333-1-alistair.francis@wdc.com> <877dyr8rq1.fsf@oldenburg2.str.redhat.com> In-Reply-To: From: Alistair Francis Date: Tue, 7 Apr 2020 07:47:42 -0700 Message-ID: Subject: Re: [PATCH v2] linux: wait4: Fix incorrect return value comparison To: Adhemerval Zanella Cc: GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Apr 2020 14:55:55 -0000 On Tue, Apr 7, 2020 at 6:25 AM Adhemerval Zanella via Libc-alpha wrote: > > > > On 07/04/2020 08:23, Florian Weimer via Libc-alpha wrote: > > * Alistair Francis via Libc-alpha: > > > >> Path 600f00b "linux: Use long time_t for wait4/getrusage" introduced > > > > Typo: "Path" > > > >> two bugs: > >> - The usage32 struct was set if the wait4 syscall had an error. > >> - For 32-bit systems the usage struct was set even if it was specified > >> as NULL. > >> > >> This patch fixes the two issues. > > > > Would it make sense to include a test case? > > > > (Somehow, my earlier message did not make it it to the list.) > > I think it would, specially now that glibc does more internally. I agree. Would you like me to write it or does someone who knows more about the glibc tests like to do it? Alistair