From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd42.google.com (mail-io1-xd42.google.com [IPv6:2607:f8b0:4864:20::d42]) by sourceware.org (Postfix) with ESMTPS id 252B03857C53 for ; Mon, 10 Aug 2020 15:55:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 252B03857C53 Received: by mail-io1-xd42.google.com with SMTP id b16so971732ioj.4 for ; Mon, 10 Aug 2020 08:55:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zpbJr+NJNIeCxPV/b24F599gHGrp+i2D0kvEpqt6buY=; b=W8onTHk5w1fscuzuhzIbSt3cxB0/H8GHFanQRL3sLKyqed06F5EMQxdmWwYiCklDf+ QDiB8zt3OidtcFhYVlAfj2sbSWPVIig7XXRoCvD2+pY+/uYyQcnbnjuSyh2yYq9Ja8tv onXkr7yF9xny48Yk27xx/Db6f9QtUk73fHhDPgNSwcVOhKq/EEI7Qn1cmnnLNlnUJ1hI eltU3csTAzuz1kmKO+llb+HNj1AAG7KJN8M88XNSnADoxBzjrHwTAc+2JKsEILRDd5z7 8KWG6vKb4VtZi0gzBzjlR5s0CMaegHLt6CAcLgbifBft6GoDpGiTF+1hRYI1EYopm9J/ Em5w== X-Gm-Message-State: AOAM532UmZ8Acj4y4r7EF7evy4eNro8IMIrJUDFnrPU4s5caDFr2bmfa QmNkdMIxYkl2yXEqnZ+wy41V9tFDOqh4gsrE/qo= X-Google-Smtp-Source: ABdhPJy01V56XDs//vde0gsC4MW3sFgsqgs6M8GNWjxHs9/MigILTFidHabCvSeWWOgiyk0We2+Mlbo9J7MewJWJA0o= X-Received: by 2002:a05:6638:248e:: with SMTP id x14mr20444046jat.135.1597074930366; Mon, 10 Aug 2020 08:55:30 -0700 (PDT) MIME-Version: 1.0 References: <3bc3074d7ae29928b90efd584f018cc9da3b42db.1594568655.git.alistair.francis@wdc.com> In-Reply-To: From: Alistair Francis Date: Mon, 10 Aug 2020 08:45:03 -0700 Message-ID: Subject: Re: [PATCH v3 15/19] RISC-V: Build Infastructure for 32-bit To: "Maciej W. Rozycki" Cc: Alistair Francis , GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Aug 2020 15:55:32 -0000 On Tue, Jul 14, 2020 at 4:55 PM Maciej W. Rozycki via Libc-alpha wrote: > > Hi Alistair, > > The heading uses odd capitalisation and wording, how about: > > RISC-V: Build infastructure for 32-bit port > > ? > > On Sun, 12 Jul 2020, Alistair Francis via Libc-alpha wrote: > > > This patch lays out the top-level orginazition of the RISC-V 32-bit port. It > > contains all the Implies files as well as various other fragments of > > build infastructure for the RISC-V 32-bit port. > > How about: > > This patch lays out the top-level organization of the RISC-V 32-bit port. > It provides all the Implies files as well as various other fragments of > the build infastructure. Fixed. > > ? [Oh, I can see where it all has been copied and pasted from.] > > > diff --git a/sysdeps/unix/sysv/linux/riscv/Makefile b/sysdeps/unix/sysv/linux/riscv/Makefile > > index 301b082398..6c11f7fd9a 100644 > > --- a/sysdeps/unix/sysv/linux/riscv/Makefile > > +++ b/sysdeps/unix/sysv/linux/riscv/Makefile > > @@ -7,11 +7,13 @@ ifeq ($(subdir),stdlib) > > gen-as-const-headers += ucontext_i.sym > > endif > > > > -abi-variants := lp64 lp64d > > +abi-variants := ilp32 ilp32d lp64 lp64d > > > > ifeq (,$(filter $(default-abi),$(abi-variants))) > > $(error Unknown ABI $(default-abi), must be one of $(abi-variants)) > > endif > > > > +abi-ilp32-condition := !defined __LP64__ && defined __riscv_float_abi_soft > > +abi-ilp32d-condition := !defined __LP64__ && defined __riscv_float_abi_double > > abi-lp64-condition := defined __LP64__ && defined __riscv_float_abi_soft > > abi-lp64d-condition := defined __LP64__ && defined __riscv_float_abi_double > > I feel like these all ought to use __WORDSIZE so as to be consistent, > also with the majority of other ports, and inclusive for RV32 rather than > exclusive. That if FAOD: > > abi-ilp32-condition := __WORDSIZE == 32 && defined __riscv_float_abi_soft > abi-ilp32d-condition := __WORDSIZE == 32 && defined __riscv_float_abi_double > abi-lp64-condition := __WORDSIZE == 64 && defined __riscv_float_abi_soft > abi-lp64d-condition := __WORDSIZE == 64 && defined __riscv_float_abi_double > > This way the ABI condition is tied to a property that we can reasonably > expect is not going to ever change and won't have to be adjusted if we add > support for say RV128 sometime. Let me know if you disagree. Fixed Alistair > > Otherwise OK. > > Maciej