public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Alistair Francis <alistair23@gmail.com>
To: Lukasz Majewski <lukma@denx.de>
Cc: Joseph Myers <joseph@codesourcery.com>,
	Paul Eggert <eggert@cs.ucla.edu>,
	 Adhemerval Zanella <adhemerval.zanella@linaro.org>,
	Arnd Bergmann <arnd@arndb.de>,
	 Alistair Francis <alistair.francis@wdc.com>,
	GNU C Library <libc-alpha@sourceware.org>,
	 Florian Weimer <fweimer@redhat.com>,
	"Carlos O'Donell" <carlos@redhat.com>,
	 Stepan Golosunov <stepan@golosunov.pp.ru>,
	Andreas Schwab <schwab@suse.de>, Zack Weinberg <zackw@panix.com>,
	Jeff Law <law@redhat.com>
Subject: Re: [PATCH 1/2] nptl: Provide proper spelling for 32 bit version of futex_abstimed_wait
Date: Wed, 16 Sep 2020 07:56:22 -0700	[thread overview]
Message-ID: <CAKmqyKO_D9FRVKVo-QAdV6nyuQpATrTLT6f3n5m2iYOe4biMxQ@mail.gmail.com> (raw)
In-Reply-To: <20200916110738.9904-1-lukma@denx.de>

On Wed, Sep 16, 2020 at 4:07 AM Lukasz Majewski <lukma@denx.de> wrote:
>
> This change provides proper spelling of 32 bit __futex_abstimed_wait_cancelable32
> function

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
>  sysdeps/nptl/futex-internal.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/sysdeps/nptl/futex-internal.c b/sysdeps/nptl/futex-internal.c
> index a2ee5804ec..a4fc1dc52f 100644
> --- a/sysdeps/nptl/futex-internal.c
> +++ b/sysdeps/nptl/futex-internal.c
> @@ -24,10 +24,10 @@
>
>  #ifndef __ASSUME_TIME64_SYSCALLS
>  static int
> -__futex_abstimed_wait_cancellable32 (unsigned int* futex_word,
> -                                     unsigned int expected, clockid_t clockid,
> -                                     const struct __timespec64* abstime,
> -                                     int private)
> +__futex_abstimed_wait_cancelable32 (unsigned int* futex_word,
> +                                    unsigned int expected, clockid_t clockid,
> +                                    const struct __timespec64* abstime,
> +                                    int private)
>  {
>    if (! in_time_t_range (abstime->tv_sec))
>      return -EOVERFLOW;
> @@ -91,8 +91,8 @@ __futex_abstimed_wait_cancelable64 (unsigned int* futex_word,
>                                   FUTEX_BITSET_MATCH_ANY);
>  #ifndef __ASSUME_TIME64_SYSCALLS
>    if (err == -ENOSYS)
> -    err = __futex_abstimed_wait_cancellable32 (futex_word, expected,
> -                                               clockid, abstime, private);
> +    err = __futex_abstimed_wait_cancelable32 (futex_word, expected,
> +                                              clockid, abstime, private);
>  #endif
>
>    switch (err)
> --
> 2.20.1
>

  parent reply	other threads:[~2020-09-16 15:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-16 11:07 Lukasz Majewski
2020-09-16 11:07 ` [PATCH 2/2] nptl: Provide NULL abstime pointer handling in __futex_abstimed_wait_cancelable32 Lukasz Majewski
2020-09-16 12:06   ` Andreas Schwab
2020-09-16 14:59   ` Alistair Francis
2020-09-16 12:04 ` [PATCH 1/2] nptl: Provide proper spelling for 32 bit version of futex_abstimed_wait Andreas Schwab
2020-09-16 14:56 ` Alistair Francis [this message]
2020-09-29 16:52   ` Lukasz Majewski
2020-09-29 18:11     ` Adhemerval Zanella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKmqyKO_D9FRVKVo-QAdV6nyuQpATrTLT6f3n5m2iYOe4biMxQ@mail.gmail.com \
    --to=alistair23@gmail.com \
    --cc=adhemerval.zanella@linaro.org \
    --cc=alistair.francis@wdc.com \
    --cc=arnd@arndb.de \
    --cc=carlos@redhat.com \
    --cc=eggert@cs.ucla.edu \
    --cc=fweimer@redhat.com \
    --cc=joseph@codesourcery.com \
    --cc=law@redhat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=lukma@denx.de \
    --cc=schwab@suse.de \
    --cc=stepan@golosunov.pp.ru \
    --cc=zackw@panix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).