From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x143.google.com (mail-il1-x143.google.com [IPv6:2607:f8b0:4864:20::143]) by sourceware.org (Postfix) with ESMTPS id 5E5F6385700B for ; Wed, 16 Sep 2020 17:27:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5E5F6385700B Received: by mail-il1-x143.google.com with SMTP id u18so7209978iln.13 for ; Wed, 16 Sep 2020 10:27:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WDbpP2wLzQulF/Rbi2gRupQclQ6O+1s+vMlaoO3MV70=; b=gy1O10/a94K9heE34M62SbrOozH4aXyZaXeGZWcYaEPZ5biS/gFg+89i4peOah6G4m z6THcp8wyrW0dKTNrMpVuazmlqY26Jq+bDySWqxNTPn82+lc7aziZfAJiVMWOMCDyFJt ZKqFV1WgGE5tcj55eJUr1/auDL0vTk/VTbSu3dgXJlsUhfbqk0zH0uzQ5YVZrqdE1L0v C6AsB3ivelyddliycB1/XbOUvLS1GDWAbcJJPt4zDqjP4LA4VNXl88OZDmfamZ/Tj7qh YT+eI+maCCLTSB56F07Qd2dEe5l2ib7ns3b2jw2JQ+/wfhGdxoRqWPqbKzebGSfWPhAG h15w== X-Gm-Message-State: AOAM532KKKNzh6JEzAkdX/kr53PRT4vU9k16ni3gOhgpghM242NzMgir nBJcb1+nGWr73At0vgaSCRjEdddyvksH5z8XZsPy2h8mrIM= X-Google-Smtp-Source: ABdhPJzfLG/HX9qhfbUz6EfPgAUBysrNmq1z09k5+7P2GHNQhp+roFERS9KIHEeeD76S/ow3zVqC/xziU8NH7/wxQhc= X-Received: by 2002:a92:4a08:: with SMTP id m8mr10639859ilf.227.1600277264817; Wed, 16 Sep 2020 10:27:44 -0700 (PDT) MIME-Version: 1.0 References: <20200908145738.640039-1-adhemerval.zanella@linaro.org> <20200908145738.640039-10-adhemerval.zanella@linaro.org> In-Reply-To: <20200908145738.640039-10-adhemerval.zanella@linaro.org> From: Alistair Francis Date: Wed, 16 Sep 2020 10:16:33 -0700 Message-ID: Subject: Re: [PATCH v2 10/14] linux: Add time64 support for nanosleep To: Adhemerval Zanella Cc: GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-9.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Sep 2020 17:27:47 -0000 On Tue, Sep 8, 2020 at 8:01 AM Adhemerval Zanella via Libc-alpha wrote: > > It uses __clock_nanosleep64 and adds the __nanosleep64 symbol. > > Checked on x86_64-linux-gnu and i686-linux-gnu (on 5.4 and on 4.15 > kernel). Reviewed-by: Alistair Francis Alistair > --- > include/time.h | 9 ++++++ > sysdeps/unix/sysv/linux/nanosleep.c | 50 +++++++++++++++++++++++++++++ > 2 files changed, 59 insertions(+) > create mode 100644 sysdeps/unix/sysv/linux/nanosleep.c > > diff --git a/include/time.h b/include/time.h > index 936486e206..edf6cdf829 100644 > --- a/include/time.h > +++ b/include/time.h > @@ -271,6 +271,15 @@ extern struct tm *__tz_convert (__time64_t timer, int use_localtime, > extern int __nanosleep (const struct timespec *__requested_time, > struct timespec *__remaining); > hidden_proto (__nanosleep) > +#if __TIMESIZE == 64 > +# define __nanosleep64 __nanosleep > +#else > +extern int __nanosleep64 (const struct __timespec64 *__requested_time, > + struct __timespec64 *__remaining); > +hidden_proto (__nanosleep64) > +#endif > + > + > extern int __getdate_r (const char *__string, struct tm *__resbufp) > attribute_hidden; > > diff --git a/sysdeps/unix/sysv/linux/nanosleep.c b/sysdeps/unix/sysv/linux/nanosleep.c > new file mode 100644 > index 0000000000..8f4ee0f744 > --- /dev/null > +++ b/sysdeps/unix/sysv/linux/nanosleep.c > @@ -0,0 +1,50 @@ > +/* High-resolution sleep. > + Copyright (C) 2020 Free Software Foundation, Inc. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library; if not, see > + . */ > + > +#include > +#include > + > +int > +__nanosleep64 (const struct __timespec64 *req, struct __timespec64 *rem) > +{ > + int ret = __clock_nanosleep_time64 (CLOCK_REALTIME, 0, req, rem); > + if (ret != 0) > + { > + __set_errno (ret); > + return -1; > + } > + return 0; > +} > +#if __TIMESIZE != 64 > +libc_hidden_def (__nanosleep64) > + > +int > +__nanosleep (const struct timespec *req, struct timespec *rem) > +{ > + struct __timespec64 treq64, trem64; > + > + treq64 = valid_timespec_to_timespec64 (*req); > + int ret = __nanosleep64 (&treq64, &trem64); > + > + if (ret != 0 && errno == EINTR && rem != NULL) > + *rem = valid_timespec64_to_timespec (trem64); > + return ret; > +} > +#endif > +libc_hidden_def (__nanosleep) > +weak_alias (__nanosleep, nanosleep) > -- > 2.25.1 >