From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x143.google.com (mail-il1-x143.google.com [IPv6:2607:f8b0:4864:20::143]) by sourceware.org (Postfix) with ESMTPS id 702253857C57 for ; Wed, 26 Aug 2020 16:34:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 702253857C57 Received: by mail-il1-x143.google.com with SMTP id j9so2302733ilc.11 for ; Wed, 26 Aug 2020 09:34:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zJ85AbEB63mfgQT4kVsaO1TLkKeM+vsfAzNJlNdWxBI=; b=cmeyNX2fDdRudMiy8UlU2+tejTEgYWX80KdO+GxQJkz8DNKaLT/Oaclw5x4/SO1u0i B7XbyM3CBHxgWuNxBW2oMDgrDQgHH1qPc1GoTX3trALfUgSPB9imfu3FPKqizZP/CgTP bi/GtXZi7faKYoUBIJYD5U8MiCyyO/WrlgYpgG+XeqDsVg+0hK921pwv60U2afgVnLBH XrHjC8+6KyqOMhFZRmwZ/Xxdvw8h2KwStfzEnDq0By9QOtgGEK8p+PK1NLmwYsiJYdRV w2jpWkx4l5MDC6PbdvGba9PUNbcJOzgf84U9WqBVkLf3E0IiVU1BChZfcQxEDUmmad3g Go2g== X-Gm-Message-State: AOAM530ASEpQuQZmqGNuo8YVPeUrZ/Mz+AxHhyZsuWPy2H9pSw0Z3jL0 i9bt0RTPXtOLCXxVzhyt1ZM+se9+Hu26+G82FTHEzyINhvk= X-Google-Smtp-Source: ABdhPJyI6CuMJit0b+T+QRGjj3GaKibEl3PDegrQR+Nm0pT/ze/GE7ABMg4a2vpmxC3/k3xTPOwtmmNPOmOM7JYsc2Y= X-Received: by 2002:a92:c7d4:: with SMTP id g20mr14143876ilk.40.1598459664993; Wed, 26 Aug 2020 09:34:24 -0700 (PDT) MIME-Version: 1.0 References: <20200826153723.1649036-1-alistair.francis@wdc.com> In-Reply-To: From: Alistair Francis Date: Wed, 26 Aug 2020 09:23:41 -0700 Message-ID: Subject: Re: [PATCH] elf/tst-libc_dlvsym: Add a TEST_COMPAT around some symbol tests To: Adhemerval Zanella Cc: GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-9.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Aug 2020 16:34:26 -0000 On Wed, Aug 26, 2020 at 9:20 AM Adhemerval Zanella via Libc-alpha wrote: > > > > On 26/08/2020 12:37, Alistair Francis via Libc-alpha wrote: > > The _sys_errlist and _sys_siglist symbols are deprecated since 2.32. > > This patch adds a TEST_COMPAT check around the tests. This fixes test > > failures on new architecutres (such as RV32) that don't have this > > s/architecutres/architectures Fixed. > > > symbol defined. > > > > Signed-off-by: Alistair Francis > > We don't use DCO, but rather Copyright assignment. Argh, I know that. Sorry it's just a hard habit to break. > > LGTM with the comment adjustment below, thanks. > > Reviewed-by: Adhemerval Zanella > > > --- > > elf/tst-libc_dlvsym.h | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/elf/tst-libc_dlvsym.h b/elf/tst-libc_dlvsym.h > > index 6b132dd7c3..4601e8869c 100644 > > --- a/elf/tst-libc_dlvsym.h > > +++ b/elf/tst-libc_dlvsym.h > > @@ -117,8 +117,12 @@ compare_vsyms (void) > > obtain an explicit handle for libc.so. */ > > void *libc_handle = xdlopen (LIBC_SO, RTLD_LAZY | RTLD_NOLOAD); > > > > + /* sys_errlist and sys_siglist were deprecated in glibc 2.32 and aren't > > + avaliable on newly linked binaries. */ > > This comment does not really apply here, since it is not using the static link > to generate a new binary. I think a better description would be: > > /* sys_errlist and sys_siglist were deprecated in glibc 2.32 and they are > not available on architectures with base ABI newer than 2.32. */ Fixed. Alistair > > > +#if TEST_COMPAT (libc, GLIBC_2_0, GLIBC_2_32) > > compare_vsyms_1 (libc_handle, "_sys_errlist"); > > compare_vsyms_1 (libc_handle, "_sys_siglist"); > > +#endif > > compare_vsyms_1 (libc_handle, "quick_exit"); > > > > xdlclose (libc_handle); > >