From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by sourceware.org (Postfix) with ESMTPS id C31D4393859C for ; Fri, 9 Dec 2022 04:35:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C31D4393859C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=sifive.com Received: by mail-lf1-x133.google.com with SMTP id c1so5255633lfi.7 for ; Thu, 08 Dec 2022 20:35:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=dNp1XcFZwRfXWt4PIYdlLIwYi5756zJ1n1RH9A4eyUc=; b=N9aTQIn1CAX2kiofIkyH5KcJXqjeUTIQTDU7n8D9O1fD1zdE5IFsaxrdsAlUu7uX6w 0CgJsVwLWHjrbbBCHI88wkjD2BnLwjKemPFyk28QdA/Q1rEH1ZxN8t/NOckRiLqd1b2g yorr5jcvP8z4j/G53F1damRt8nYuDaKUJNOzGl1debx/YiFvnef/D6ZODDmFOuLMeV7M YudFIowrCI4hhgKlw6FA84CaDxqxR0/UGTgDCnfgOPlwVGIjlaEFRHE57Dj0+hawYeYw s3ag/xE5ANnzzstENZ619XJ4SD9U1cRI6qQ5JwlYs48hTZtFAPOvd19z6dM2yyZpQKoC QfAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dNp1XcFZwRfXWt4PIYdlLIwYi5756zJ1n1RH9A4eyUc=; b=fdBLXG1/gBkX2k93r1icARhptZOe1Nc5UFgddZe6rYZrEc53+lcj5FOirQfpyqDvLf KUe2lWrgwmvgTOgsRMYItmDuUp8N502PIjb4RWS5J3TpOuces7IAq1IsQSSKemhUWNTJ LdZUx41iNebidFjO5/A91AL65a3+7r1V5YtCtMK2625CaA3l1IwpcDsE36qflPfvgfr6 rT+kYxml1A9FyswfVTAGXPwEsIsIGw5ag7zkP6AV/ykhiuvev0jfO2UY1Vp0r01V00Kq VqAQquZeeVVuJ573IMeANUSPOO0DAK6fDP2/c2DKbIbhQ1qw+YhqjZOTaX8EdE0B1arb F1qA== X-Gm-Message-State: ANoB5pl3YMt0mG5Lsf6TMqvPfTAFyovx2W/FpSGWlAK5c/TBeBFI/n70 x4K5GYjLkc/DXKWPSmfPUg2TkM4rrbFlVOGIN9kZdw== X-Google-Smtp-Source: AA0mqf7l7DK5SnUv8LSbBcQaPZvJQKEUIpGWoMi3PyxQ2wZgomNEFpwOn6CtqLfeJAvyxpgQi1CdlT/s95waJ6C0qiU= X-Received: by 2002:a05:6512:3193:b0:4b5:79c9:bf85 with SMTP id i19-20020a056512319300b004b579c9bf85mr4971919lfe.541.1670560530213; Thu, 08 Dec 2022 20:35:30 -0800 (PST) MIME-Version: 1.0 References: <20220118043159.27521-1-vincent.chen@sifive.com> <20220118043159.27521-3-vincent.chen@sifive.com> <76459bf7-10f9-ff70-d217-ed3298b88c4a@rivosinc.com> In-Reply-To: From: Kito Cheng Date: Fri, 9 Dec 2022 12:35:18 +0800 Message-ID: Subject: Re: [PATCH v2 2/2] riscv: Resolve symbols directly for symbols with STO_RISCV_VARIANT_CC. To: Vineet Gupta Cc: Vincent Chen , libc-alpha@sourceware.org, palmer@dabbelt.com, darius@bluespec.com, andrew@sifive.com, dj@redhat.com, greentime.hu@sifive.com, Andy Chiu , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , davidlt@rivosinc.com, Arnd Bergmann , Florian Weimer , Nelson Chu Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Not sure what you mean. Are you saying that even though the current ABI > doesn't require it, we should still add it to glibc, won't it bitrot. > I don't feel strongly either ways, but IMO this should be done when the > ABI is actually changed. STO_RISCV_VARIANT_CC has already been defined and released in psABI 1.0, and this patch is implementing a feature in released psABI, so I think this is fine to upstream from psABI perspective.