From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) by sourceware.org (Postfix) with ESMTPS id EEDC13858401 for ; Wed, 19 Jan 2022 14:50:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EEDC13858401 Received: by mail-qt1-f178.google.com with SMTP id w6so2522024qtk.4 for ; Wed, 19 Jan 2022 06:50:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=9vfM8g72TwF6zow4nuUq8XN0r4ZCEdEQNwxF90h1tss=; b=vrdnelmJKmBG1rCGVnxBBS/zuEvEzOzPEYHrNJCL74bz3Bv8ayqZkoGbE+WOCesTgO 9YIWXRdyut4EBPG4QxadUC8+KRXEiqz5IrdS5bU5trLgCMtSYwUsbmukOHG2XjXPqfWF wBS2QKtuGAE7JhPGU/F8r2LwJkbjpdRbYl8v/xetdOsGvcwXjnlox/pIQe459BRTT4Ev WmR4DzYsP9KmsMzvvROsin/t6ga9dAIWJW/pnhkVJDPgpmt4Ji7iy62Zj4lIXdPeBsNu sGhQUUmtAG4sz4Hp0K+Zo1wfNvi3Z1fmvPVNpUQAxNa1ZwWh4vq0u4IS4eACjBvZ5Ldu x7Tw== X-Gm-Message-State: AOAM530U4EHGiAOL0IUmLgMuQRt3SDrk/fv4lBecq2P8RjkHXXAno8qB CmuSdJ53NhmEN9thGFOt8GtJv/lPDGZB8k33FAaC8Q== X-Google-Smtp-Source: ABdhPJwCRdez45wQ4KQhMBTm0zqzO00DgPjF+rJurE3tHzbVVhb9yvyANqJFbIyFXt7Uj50N8s1gON4unzvQoTMh8LE= X-Received: by 2002:a05:622a:120b:: with SMTP id y11mr1309244qtx.307.1642603852875; Wed, 19 Jan 2022 06:50:52 -0800 (PST) MIME-Version: 1.0 References: <1642405014-3287-1-git-send-email-xuyang2018.jy@fujitsu.com> <61E6298D.80006@fujitsu.com> <61E64FED.2010906@fujitsu.com> <87r195i1lq.fsf@oldenburg.str.redhat.com> <61E7AC82.8080801@fujitsu.com> <61E7BBD6.3010706@fujitsu.com> In-Reply-To: From: "Andrew G. Morgan" Date: Wed, 19 Jan 2022 06:50:41 -0800 Message-ID: Subject: Re: [PATCH] src/ext4_resize.c: set errno to 0 before the strtoull call To: =?UTF-8?Q?Cristian_Rodr=C3=ADguez?= Cc: "xuyang2018.jy@fujitsu.com" , Florian Weimer , "Theodore Ts'o" , "libc-alpha@sourceware.org" , "fstests@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_NONE, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Jan 2022 14:50:57 -0000 Thanks for finding this. Fixed in: https://git.kernel.org/pub/scm/libs/libcap/libcap.git/commit/?id=3Df25a1b7e= 69f7b33e6afb58b3e38f3450b7d2d9a0 Cheers Andrew On Wed, Jan 19, 2022 at 6:08 AM Cristian Rodr=C3=ADguez wrote: > > On Wed, Jan 19, 2022 at 10:57 AM Cristian Rodr=C3=ADguez > wrote: > > > This is not a glibc problem though, looks like lcap is clobbering > > errno. I'd bet good CLP on the code called in > > __attribute__((constructor (300))) static void _initialize_libcap(void)= . > > I strongly suggest not to use constructors on shared libraries unless > > all the components using the library are in your control and you are > > sure constructors will not ruin some other application's day. > > __attribute__((constructor (300))) static void _initialize_libcap(void) > { > if (_cap_max_bits) { > return; > } > cap_set_syscall(NULL, NULL); --> nope > _binary_search(_cap_max_bits, cap_get_bound, 0, __CAP_MAXBITS, > __CAP_BITS); --> =F0=9F=A4=94 > cap_proc_root("/proc"); > } > > do, what cap_get_bound does ? > > int cap_get_bound(cap_value_t cap) > { > int result; > > result =3D prctl(PR_CAPBSET_READ, pr_arg(cap), pr_arg(0)); > if (result < 0) { > errno =3D -result; --> If all my bets paid , I would be rich.. > here is your 1 > return -1; > } > return result; > }