From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf30.google.com (mail-qv1-xf30.google.com [IPv6:2607:f8b0:4864:20::f30]) by sourceware.org (Postfix) with ESMTPS id 89ED53858D1E for ; Sun, 5 Mar 2023 06:14:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 89ED53858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qv1-xf30.google.com with SMTP id ne1so4537329qvb.9 for ; Sat, 04 Mar 2023 22:14:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677996874; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=CHCXMKKo1a6RwIbD8wJj8arUvfPAcNs2d2TPuOdjsmY=; b=PbgzjhoO6sQp6KtXGpS20CRWEJNsk4oqJU+u2F8efED1wCAyy92ySOEtTmHeFqnN78 ZFlvcLoqRB2TvTwtoBIZ69bsq/DcFTeSH24L6PFM0Qhq6wSjVudMKIJqzmUYTcIoT6ib PFD7tSfUL/c0/WARIaWCF65dRghnyBJ4rX7s/7vDZl82v2UobPTpFXpAbg28uSQYPcyJ rQqRX1sgQ1beEldoU/SaKMT3w092J2FszdToepHHjQZRGPATIg1Oq97K7gAncrFE6NAe eITePPJWUSE4i9wcms+ZFAC5h0hNHYeqIgBzDBElieU96KLMf9VACqMJbgVvQZvSapUh UOGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677996874; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CHCXMKKo1a6RwIbD8wJj8arUvfPAcNs2d2TPuOdjsmY=; b=oDQcb0XFkEjugABlnakQeSBZCbFOT+3lSaHVVrWQbafl+62t3xECZD2uKp4WgsUmtS 3ekmUWDPucQaFtNKVDXhoh7O+DI1PClQ1kBRuskWzPeP14BhOAQ4rPmCOXaoBVOg8mxG 5XvaFdL9CD5liuJoc+F3117X0Z0Mdo+myv0UNlQSR7dcodR7ayBIq/IpmkTaiQdJoc3I r0MVD73KQqcOcVVj05NZrp4Z4YZnDyzH7vJahL08nFiZu5qdWFhuE75HFs1PdRDcmLq9 syK1oC/RAcUdgswt8w0fB+0vjcPi7VFtjB5/GB5OZMsNhSEj5NIQ6FpIouxxePbLwpPu jahw== X-Gm-Message-State: AO0yUKVlNK5dF5ES1C7/s/FqaoJyNFxrmzdG4Q3HRu7cDZvXKchZBLHd vhHye7F79PyfJ44JorBDRGBzQqoHZse6McvYRjBULcN4Rhk= X-Google-Smtp-Source: AK7set99gdWKpTQyq5XEniJ+xhmrlH1qBXmJAnQ16ol4kUNK8DsB11ckqgjzBnfiExJ53H3SwCqzX3539AdaFZIRVNA= X-Received: by 2002:ad4:4bb1:0:b0:56f:a4:d7f5 with SMTP id i17-20020ad44bb1000000b0056f00a4d7f5mr1621739qvw.5.1677996873811; Sat, 04 Mar 2023 22:14:33 -0800 (PST) MIME-Version: 1.0 References: <877cw3kn65.fsf@oldenburg.str.redhat.com> In-Reply-To: <877cw3kn65.fsf@oldenburg.str.redhat.com> From: Girish Joshi Date: Sun, 5 Mar 2023 11:44:22 +0530 Message-ID: Subject: Re: [PATCH] manual: scripts/documented.sh updated To: Florian Weimer Cc: Girish Joshi via Libc-alpha Content-Type: multipart/mixed; boundary="00000000000099808605f62117bf" X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,CONTENT_AFTER_HTML_WEAK,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,URIBL_BLACK autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --00000000000099808605f62117bf Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Florian, Thanks for the review. Turns out `diff` was not working with the given input files, this patch fixes that. I'm not sure if there is a list of people who volunteered to document some specific functions. So that comment from the output html is removed. Thanks! Girish Joshi On Mon, Feb 27, 2023 at 11:26=E2=80=AFPM Florian Weimer wrote: > > * Girish Joshi via Libc-alpha: > > > Hello, > > As per the Missing Functions section of master Todo list[1], > > scripts/documented.sh needs to be updated. > > > > Could someone please review this patch? > > It removes the reference to linuxthreads/*.taxi files from the script > > and removes the individual email address from the output. > > The script still doesn't seem to work, probably because the symbol names > are not extract properly: > > 43120 T _dl_mcount_wrapper 43140 T _dl_mcount_wrapper_c 43320 W c= logf 43320 W clogf32 > 435c0 T _dl_find_object 43740 T realpath 43770 T quick_exi= t 43790 T _IO_vfscanf > 437c0 T _pthread_cleanup_pus 437d0 T _pthread_cleanup_pop 437d0 W c= projf 437d0 W cprojf32 > > _dl_find_object is documented. > > _IO_vfscanf should be recognized as an alias of vfscanf, but this is > more of an RFE than a bug fix. > > Thanks, > Florian > --00000000000099808605f62117bf Content-Type: text/x-patch; charset="US-ASCII"; name="0001-manual-scripts-documented.sh-updated.patch" Content-Disposition: attachment; filename="0001-manual-scripts-documented.sh-updated.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_leuzzimp0 RnJvbSA1MTQ4YzY1YWMwNzY4OGRjNWMzZWU3OWE5YjBmMDU0MjMyZDY0ZGYzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHaXJpc2ggSm9zaGkgPGdpcmlzaDk0NkBnbWFpbC5jb20+CkRh dGU6IFN1biwgNSBNYXIgMjAyMyAxMToxNTowMCArMDUzMApTdWJqZWN0OiBbUEFUQ0hdIG1hbnVh bDogc2NyaXB0cy9kb2N1bWVudGVkLnNoIHVwZGF0ZWQKClJlZmVyZW5jZXMgZm9yIGxpbnV4dGhy ZWFkcyBhcmUgcmVtb3ZlZCBmcm9tIHNjcmlwdHMvZG9jdW1lbnRlZC5zaC4KQWxzbyByZW1vdmVk IHRoZSBpbmRpdmlkdWFsIGVtYWlsIGFkZHJlc3MgZnJvbSB0aGUgaHRtbCBvdXRwdXQuCgpGaXhl ZCB0aGUgc3RlcHMgdG8gcmV0cml2ZSB1bmRvY3VtZW50ZWQgZnVuY3Rpb25zCi0tLQogc2NyaXB0 cy9kb2N1bWVudGVkLnNoIHwgNDQgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0t LS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDMyIGluc2VydGlvbnMoKyksIDEyIGRlbGV0aW9ucygt KQogbW9kZSBjaGFuZ2UgMTAwNjQ0ID0+IDEwMDc1NSBzY3JpcHRzL2RvY3VtZW50ZWQuc2gKCmRp ZmYgLS1naXQgYS9zY3JpcHRzL2RvY3VtZW50ZWQuc2ggYi9zY3JpcHRzL2RvY3VtZW50ZWQuc2gK b2xkIG1vZGUgMTAwNjQ0Cm5ldyBtb2RlIDEwMDc1NQppbmRleCA3ZDFmZmQ0YTkyLi5kZGE2YTMy MjgzCi0tLSBhL3NjcmlwdHMvZG9jdW1lbnRlZC5zaAorKysgYi9zY3JpcHRzL2RvY3VtZW50ZWQu c2gKQEAgLTEsOSArMSwxNSBAQAogIyEvYmluL3NoCiBiaW5kaXI9JDEKIAotVkVSU0lPTj0xLjAK KyMgdXNhZ2U6IHNjcmlwdHMvZG9jdW1lbnRlZC5zaCA8cGF0aCB0byBnbGliYyBidWlsZCBkaXJl Y3Rvcnk+CisjIGZvciBleGFtcGxlOgorIyBzY3JpcHRzL2RvY3VtZW50ZWQuc2ggJEhPTUUvYnVp bGQvZ2xpYmMKIAotZ3JlcCAtRSAtaCBAZGVmdHlwZWZ1P254PyAqLnRleGkgLi4vbGludXh0aHJl YWRzLyoudGV4aSB8CitWRVJTSU9OPTEuMQorCisjIENvbGxlY3QgdGhlIGRvY3VtZW50ZWQgZnVu Y3Rpb25zIGZyb20gbWFudWFsLyoudGV4aSBmaWxlcy4KKworZ3JlcCAtRSAtaCBAZGVmdHlwZWZ1 P254PyBtYW51YWwvKi50ZXhpIHwKIHNlZCAtZSAncy9AZGVmdHlwZWZ1bngqW1s6c3BhY2U6XV0q XCh7W157XSp9XHxbWzphbG51bTpdX10qXClbWzpzcGFjZTpdXSpcKFtbOmFsbnVtOl1fXSpcKS4q L1wyLycgLWUgJ3MvQGRlZnR5cGVmbiB7W159XSpmdW5jdGlvbn0qW1s6c3BhY2U6XV0qXCh7W157 XSp9XHxbWzphbG51bTpdX10qXClbWzpzcGFjZTpdXSpcKFtbOmFsbnVtOl1fXSpcKS4qL1wyLycg LWUgJy9eQC9kJyB8CiBzZWQgLWUgJy9eb2JzdGFja18vZCcgLWUgJy9eXChbbGZdXHxcKXN0YXRc KFx8NjRcKSQvZCcgLWUgJy9ebWtub2QkL2QnIHwKIHNlZCAtZSAnL15zaWduYml0JC9kJyAtZSAn L15zaWdzZXRqbXAkL2QnIHwKQEAgLTEyLDkgKzE4LDEyIEBAIHNlZCAtZSAnL15fX2Z3cml0aW5n JC9kJyAtZSAnL15fX2Z3cml0YWJsZSQvZCcgLWUgJy9eX19mc2V0bG9ja2luZyQvZCcgfAogc2Vk IC1lICcvXl9fZnJlYWRpbmckL2QnIC1lICcvXl9fZnJlYWRhYmxlJC9kJyAtZSAnL15fX2ZwdXJn ZSQvZCcgfAogc2VkIC1lICcvXl9fZnBlbmRpbmckL2QnIC1lICcvXl9fZmxiZiQvZCcgLWUgJy9e X19mYnVmc2l6ZSQvZCcgfAogc2VkIC1lICcvXmFsbG9jYSQvZCcgfAorc2VkIC1yICcvXlxzKiQv ZCcgfAogc29ydCAtdSA+IERPQ1VNRU5URUQKIAotbm0gLS1leHRlcm4gLS1kZWZpbmUgJGJpbmRp ci9saWJjLnNvICRiaW5kaXIvbWF0aC9saWJtLnNvICRiaW5kaXIvcnQvbGlicnQuc28gJGJpbmRp ci9saW51eHRocmVhZHMvbGlicHRocmVhZC5zbyAkYmluZGlyL2RsZmNuL2xpYmRsLnNvICRiaW5k aXIvY3J5cHQvbGliY3J5cHQuc28gJGJpbmRpci9sb2dpbi9saWJ1dGlsLnNvIHwKKworIyBleHRy YWN0IHRoZSBleHBvcnRlZCBzeW1ib2xzIGZyb20gdGhlIGxpYnJhcmllcy4KK25tIC0tZXh0ZXJu IC0tZGVmaW5lICRiaW5kaXIvbGliYy5zbyAkYmluZGlyL21hdGgvbGlibS5zbyAkYmluZGlyL3J0 L2xpYnJ0LnNvICRiaW5kaXIvbnB0bC9saWJwdGhyZWFkLnNvICRiaW5kaXIvZGxmY24vbGliZGwu c28gJGJpbmRpci9jcnlwdC9saWJjcnlwdC5zbyAkYmluZGlyL2xvZ2luL2xpYnV0aWwuc28gfAog Z3JlcCAtRSAiIFtUV10gKFtbOmFscGhhOl1dfF9bWzphbHBoYTpdXSkiIHwKIHNlZCAncy9cKEAu KlwpLy8nIHwKIGN1dCAtYiAxMi0gfApAQCAtMjUsNiArMzQsOSBAQCBzZWQgLWUgJy9eX21jbGVh bnVwJC9kJyAtZSAnL15fcnBjX2R0YWJsZXNpemUkL2QnIC1lICcvXl9zZXRlcnJfcmVwbHkkL2Qn IHwKIHNlZCAtZSAnL15fbnNzL2QnIC1lICcvXl9zZXRqbXAkL2QnIHwKIHNvcnQgLXUgPiBBVkFJ TEFCTEUKIAorIyByZW1vdmUgb2Zmc2V0IGRldGFpbHMgZnJvbSBubSBvdXRwdXQKK2NhdCBBVkFJ TEFCTEUgfCBjdXQgLWIgOS0gIHwgc29ydCAtdSAgPiBBVkFJTEFCTEVfV0lUSE9VVF9PRkZTRVQK KwogY2F0IDw8RU9GCiA8IURPQ1RZUEUgSFRNTCBQVUJMSUMgIi0vL0lFVEYvL0RURCBIVE1MLy9F TiI+CiA8aHRtbD4KQEAgLTM5LDkgKzUxLDcgQEAgY2F0IDw8RU9GCiAgICAgd2hpY2ggYXJlIG5v dCB5ZXQgZG9jdW1lbnRlZCBpbiB0aGUgbWFudWFsLiAgVGhpcyBsaXN0IGlzCiAgICAgYXV0b21h dGljYWxseSBjcmVhdGVkIGFuZCB0aGVyZWZvcmUgbWlnaHQgY29udGFpbiBlcnJvcnMuICBQbGVh c2UKICAgICBjaGVjayB0aGUgbGF0ZXN0IG1hbnVhbCAoYXZhaWxhYmxlIGZyb20gdGhlIENWUyBh cmNoaXZlKSBiZWZvcmUKLSAgICBzdGFydGluZyB0byB3b3JrLiAgSXQgbWlnaHQgYWxzbyBiZSBn b29kIHRvIGxldCBtZSBrbm93IGluCi0gICAgYWR2YW5hY2Ugb24gd2hpY2ggZnVuY3Rpb25zIHlv dSBpbnRlbmQgdG8gd29yayB0byBhdm9pZAotICAgIGR1cGxpY2F0aW9uLjwvcD4KKyAgICBzdGFy dGluZyB0byB3b3JrLjwvcD4KIAogICAgIDxwPkEgZmV3IGNvbW1lbnRzOjwvcD4KIApAQCAtNTIs MTUgKzYyLDIzIEBAIGNhdCA8PEVPRgogICAgICAgPGxpPlNpbWlsYXJseSBmb3IgdGhlIExGUyBm dW5jdGlvbnMgKHRob3NlIGVuZGluZyBpbiA2NCkuPC9saT4KICAgICA8L3VsPgogCi0gICAgPHA+ VGhlIGZ1bmN0aW9uIHNvbWJvZHkgYWxyZWFkeSB2b2x1bnRlZXJlZCB0byBkb2N1bWVudCBhcmUg bWFya2VkCi0gICAgd2l0aCBhIHJlZmVyZW5jZSB0byB0aGUgcGVyc29uLjwvcD4KIAogICAgIDxj ZW50ZXI+PHRhYmxlPgogRU9GCiAKIG49MAotZGlmZiAteSAtLXdpZHRoPTYwIC0tc3VwcHJlc3Mt Y29tbW9uLWxpbmVzIERPQ1VNRU5URUQgQVZBSUxBQkxFIHwKLWV4cGFuZCB8IGN1dCAtYiAzMy0g fCBzZWQgJy9eW1s6c3BhY2U6XV0qJC9kJyB8CisKKyMgZ2V0IHRoZSBsaXN0IG9mIHVuZG9jdW1l bnRlZCBmdW5jdGlvbnMKK2dyZXAgLUZ2eCAtZiBET0NVTUVOVEVEIEFWQUlMQUJMRV9XSVRIT1VU X09GRlNFVCA+IFVORE9DVU1FTlRFRF9XSVRIT1VUX09GRlNFVAorCisjIGdldCB1bmRvY3VtZW50 ZWQgZnVuY3Rpb25zIHdpdGggb2Zmc2V0IGluZm8KK2ZvciBmdW5jIGluIGBjYXQgVU5ET0NVTUVO VEVEX1dJVEhPVVRfT0ZGU0VUYAorZG8KKyAgZ3JlcCAiICRmdW5jJCIgQVZBSUxBQkxFID4+IFVO RE9DVU1FTlRFRAorZG9uZQorCitkaWZmIC15IC0td2lkdGg9MTIwIC0tc3VwcHJlc3MtY29tbW9u LWxpbmVzIERPQ1VNRU5URUQgVU5ET0NVTUVOVEVEIHwKK2V4cGFuZCB8IGN1dCAtYiA2MS0gfCBz ZWQgJy9eW1s6c3BhY2U6XV0qJC9kJyB8CiB3aGlsZSByZWFkIG5hbWU7IGRvCiAgIGxpbmU9IiRs aW5lCiA8dGQ+PHR0PiRuYW1lPC90dD48L3RkPiIKQEAgLTk1LDggKzExMywxMCBAQCBjYXQgPDxF T0YKICAgICA8L3RhYmxlPjwvY2VudGVyPgogCiAgICAgPGhyPgotICAgIDxhZGRyZXNzPjxhIGhy ZWY9Im1haWx0bzpkcmVwcGVyQHJlZGhhdC5jb20iPlVscmljaCBEcmVwcGVyPC9hPjwvYWRkcmVz cz4KLUdlbmVyYXRlZCBvbiAkKGRhdGUpIHdpdGggZG9jdW1lbnRlZC5zaCB2ZXJzaW9uICRWRVJT SU9OCisgICAgR2VuZXJhdGVkIG9uICQoZGF0ZSkgd2l0aCBkb2N1bWVudGVkLnNoIHZlcnNpb24g JFZFUlNJT04KICAgPC9ib2R5PgogPC9odG1sPgogRU9GCisKKyMgY2xlYW51cCB0aGUgZmlsZXMK K3JtIC1yZiBVTkRPQ1VNRU5URURfV0lUSE9VVF9PRkZTRVQgQVZBSUxBQkxFX1dJVEhPVVRfT0ZG U0VUIEFWQUlMQUJMRQotLSAKMi4zOS4yCgo= --00000000000099808605f62117bf--