From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by sourceware.org (Postfix) with ESMTPS id 9A78A3858D28 for ; Sun, 7 May 2023 03:12:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9A78A3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=google.com Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-3f1950f569eso21342015e9.2 for ; Sat, 06 May 2023 20:12:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1683429135; x=1686021135; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=jh+GLITkfpo82ZY4Z4rOesFyFC9KzN2liliD2+s7cKU=; b=vRnQUf8nJEbIz4/7HpeB5gUUxQblVHrq3yUJY2CG09/U7seisznUHqWgkkIQ5pPK3r Eab+5ItQi9xnkbqPTbjwVVU7fyf4ND185tmMMzLVrE5+pmKvHhQ31knn/f8fes4JZF/9 EE5L90k3xBU4y7olHCP1qAhO1DACay89sa2VIHRjt9DMV4Jnf+eQmkaT92MNCm8OtHBL /eo/RaOnQhP838loWte5YJywBYpLMsVLAl10JRIn8dGKG/DiuDVsXNf5CJtLARJjniOy RpxAf3oFaVdPnxImvVM3A6CupvhW69ugsti/Jy897V5HwF+jK6SCefIcGX46zgUNLfpv JYXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683429135; x=1686021135; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jh+GLITkfpo82ZY4Z4rOesFyFC9KzN2liliD2+s7cKU=; b=b09Z5jfAcHt4wpzgnv8oHSOWkjurzUKwzKumHPVUoHZZbDxtg1p9OdYVb5iBPyXMk+ udgvNRGW6i3DtFPIdwBs57oFInhEIfE/t8iL9adIrTq9dbr66UZIJXOhgzoPx1gI1GnO QN2ZRWk6XT78xm7lgZ0YzC2vJgLLBvyhi0HTazqY6B6EDJN2y9ZiYTVDicXA+XqwVzis wEETIb86CTjzsVzxgrc4r5H6BBvBSP8lLnABu8SBsoThp12dgI69OwCJ8t3zCybRNCjU qlhQiXmSOVSyxqIYc6WjmibXTrxP7Vuy0Tp54A2kAQt4suJuebOY/1DRSAYspK8/oCEy 55iw== X-Gm-Message-State: AC+VfDyUIldJUCPwYTJgjKKCmGgMLu4oULutq//n/ZQ43j5+5b23smp1 AL01/ueVZCzQ5A1JR1XZ/qOnK8rYAlWMzqxOdBiMJw== X-Google-Smtp-Source: ACHHUZ5sHGkpXzofAumSqWR16m9CNLBVFAiikA6TZfJ5qwdA5SYOGiskSqGGpCJY4U3TMqmpp92AqczNgMrmSGQzQOU= X-Received: by 2002:a7b:c7ce:0:b0:3f4:1dd9:e9de with SMTP id z14-20020a7bc7ce000000b003f41dd9e9demr1657326wmk.8.1683429135191; Sat, 06 May 2023 20:12:15 -0700 (PDT) MIME-Version: 1.0 References: <20230501084208.2h5k4hleimqmoopf@begin> In-Reply-To: From: Paul Pluzhnikov Date: Sat, 6 May 2023 20:11:48 -0700 Message-ID: Subject: Re: error: macro DT/STO_RISCV_VARIANT_CC redefined To: Fangrui Song Cc: Palmer Dabbelt , samuel.thibault@ens-lyon.org, libc-alpha@sourceware.org, vincent.chen@sifive.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-19.7 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, May 1, 2023 at 8:47=E2=80=AFPM Fangrui Song via Libc-alpha wrote: > > On Mon, May 1, 2023 at 5:42=E2=80=AFAM Palmer Dabbelt wrote: > I agree that committing a revert for > 117e8b341c5c0ace8d65feeef136fececb3fdc9c will be cleaner. > Then you may push another commit adding the macros to a conventional > location, avoiding the duplicate. > > Then some of the patches in "[PATCH v3 0/6] elf.h: Fix and cleanup the > RISC-V defines" can be avoided. In the meantime https://sourceware.org/bugzilla/show_bug.cgi?id=3D30402 was filed and I just sent a patch to clean this up. --=20 Paul Pluzhnikov