From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-92235-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 111438 invoked by alias); 8 May 2018 15:46:04 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 111425 invoked by uid 89); 8 May 2018 15:46:03 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-10.0 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.2 spammy=
X-HELO: mail-wm0-f43.google.com
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=z5SqIWe8O3ekTcbzbSPYZWy45M3Sf1DvLiZVVGZpbZQ=;
        b=i4Ml/KzQZTukscLeWvkaMmdfhpGR9EyaFVrZzXoSGdP9AYHHGeh7cIYjO62B5FTZXV
         j64GdOX2AmKl+FmlG081PudYTdpWLGsrY5mZ2M/1Pv64heHTUyCpZEj5mKYqQIv17VvE
         kh/IB8mhWVqpbQlm3lAESfFAY+frVUik1UNGnsCFHirj/qs8wzdFvPGn6zOL7U72e2XI
         s3FKa5/T9KHPZa4I1JG9TO6iMbh1dVxq5ozzo/oTdLoMkCQhOwXm9Q3A4HYcGKEtgjSl
         V0TaI7jonR9ryIB+oDqLhh0I2m2AXQeu3a7PTacKTPJJF4Se3+yX2Pe9bTDYKpZ8LV1l
         2fpA==
X-Gm-Message-State: ALKqPweVDjMivpatgOzB2vwIMH78casQu3nR5oqqqyhjaYkJ3C04DRPF
	Z1sd4ni9ZQzDLGvVCwuAm3GQVROpDuFHVKeiEfwMJQ==
X-Google-Smtp-Source: AB8JxZq6d+tj+3j9GCuF44k7w8Umvsj6komG2twsYY3kWmF03Z2Jlo4NjYTkZXjAi6Qa0rQwI2D7qeWFlXucw6Ye0q8=
X-Received: by 2002:a1c:b45:: with SMTP id 66-v6mr3453683wml.155.1525794360063;
 Tue, 08 May 2018 08:46:00 -0700 (PDT)
MIME-Version: 1.0
References: <CALoOobOyeu6SM7DGPRqmHE6Y7BckFGmEFGeeFKDKjskL4EJDuA@mail.gmail.com>
 <alpine.DEB.2.20.1804172059000.1402@digraph.polyomino.org.uk>
 <CALoOobNywsKOoamnNH7=eF28=yoQMsFPy+5O6cgD4oqpVDhARA@mail.gmail.com>
 <mvmzi1a5h39.fsf@suse.de> <CALoOobNzPmK+5fnxF-cFhkGjOuemGaa3GepJZnb_1m38wb-1xA@mail.gmail.com>
 <mvmvaby5fnz.fsf@suse.de>
In-Reply-To: <mvmvaby5fnz.fsf@suse.de>
From: Paul Pluzhnikov <ppluzhnikov@google.com>
Date: Tue, 08 May 2018 15:46:00 -0000
Message-ID: <CALoOobNsR7jomwkeL4aXD8njkSitpOdXeG81FDkNKHbJoTR+0w@mail.gmail.com>
Subject: Re: [patch] Fix path length overflow in realpath (BZ#22786)
To: Andreas Schwab <schwab@suse.de>
Cc: "Joseph S. Myers" <joseph@codesourcery.com>, GLIBC Devel <libc-alpha@sourceware.org>
Content-Type: text/plain; charset="UTF-8"
X-SW-Source: 2018-05/txt/msg00290.txt.bz2

On Tue, May 8, 2018 at 8:29 AM Andreas Schwab <schwab@suse.de> wrote:

> > The (stack) allocated buffer is large enough

> Is it?  The condition is about the limit of the buffer being written,
> and about overflow missing the limit.

Oops, I mixed up this patch with the other overflow (BZ 20419).
You are absolutely right. Will retest and commit shortly.

Thanks,
-- 
Paul Pluzhnikov