From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x112c.google.com (mail-yw1-x112c.google.com [IPv6:2607:f8b0:4864:20::112c]) by sourceware.org (Postfix) with ESMTPS id 1A7373853573 for ; Fri, 10 Feb 2023 17:16:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1A7373853573 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=google.com Received: by mail-yw1-x112c.google.com with SMTP id 00721157ae682-51ba4b1b9feso76054477b3.11 for ; Fri, 10 Feb 2023 09:16:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=OWkExu7MF5ujN3Z9Cn1c8J1zfKYBkc7nXOnRoJXff40=; b=TyFcGFoWqF2I90yBQxNyR+/yt35GFhik7ubbftxu+5iKZol51B8pBbXGVfno3cuaIb QoA3W7kGnq3rhrjYgCdMWFLssW4hVHIMqHxPrjMzdM0tmYKnrRW5UNujh6RcEUKYNqcQ WgRYLUnPW3YJeLhMnqKmAb/SEndhbFJBVOan1UUBfP+wZVU3G6PPwN38mvyDWv+T5J0Q MW41mVz2PFAzYTUXIOiDZK1aaLJGTagO6i7uHhKYrV2TLnjS278guNYNGvDCInDiGrjP KHXepBpxAYSpnfS+uqQ+ihY0zLvEJFrxtoHI1woubeEccSMIvaRVSO/MFFAIfMOaxu/9 e5zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OWkExu7MF5ujN3Z9Cn1c8J1zfKYBkc7nXOnRoJXff40=; b=wWhEWAS0QqnoftH7eemhT3a9XVE85CeDFFPUHMBL4bg65YCqCR2IlYxHXoubktMFy4 Bi66XQep3oxFkybHwZGgs3zIRB73INNeiwpi6fDkQgMal4Xc8BRbxzLPZS2Fqftt6ZyW dpM9Ww+iwj/M68HxJsphZKqOtUZSE+bs/X2nuG8mPG7QxamL4rtCO1umKyrNlBtJVuc7 PpWQdjQasxHhbWnb5Po8TZHOpRo1bLy/PnQfXb6zOauoFed+i4VgELw48CsiGBs/8i6g +notfJs1T8P/droEZVYNHIET7fe8PRxmu344NxXg+yzdF0ijICwYgdUIr2GKBOU1TcQm QNEA== X-Gm-Message-State: AO0yUKXBmz45q+30bwPTYtUgmIG1R2S682Pd4gXfvRSf0e9CTeTMSGWR 6EF12m00s/C/W3xs+i9ugVV0FK/sufXg2L5SOdoXHDGtYLtl9b+U X-Google-Smtp-Source: AK7set/gMOJz38ToqcWcG2Aug7Qasxt6rJK21obau1ZcUnnyuzITbPkrhcXdML0Ivlx3M2L1M8hLC24312ReJIjfhEg= X-Received: by 2002:a0d:dd53:0:b0:52e:c958:6902 with SMTP id g80-20020a0ddd53000000b0052ec9586902mr412034ywe.125.1676049377209; Fri, 10 Feb 2023 09:16:17 -0800 (PST) MIME-Version: 1.0 References: <20230210162626.3097660-1-ppluzhnikov@google.com> <87mt5lo3nm.fsf@igel.home> In-Reply-To: <87mt5lo3nm.fsf@igel.home> From: Paul Pluzhnikov Date: Fri, 10 Feb 2023 09:15:50 -0800 Message-ID: Subject: Re: [committed][PATCH] Use __builtin_FILE instead of __FILE__ in assert in C++. To: Andreas Schwab Cc: Paul Pluzhnikov via Libc-alpha Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-18.1 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Feb 10, 2023 at 9:01 AM Andreas Schwab wrote: > > On Feb 10 2023, Paul Pluzhnikov via Libc-alpha wrote: > > > +# if !defined(__ASSERT_FILE) > > Please remove the extra parens. Done. I was able to push amended patch (since there were no newer commits). Is that what I should have done? Thanks, -- Paul Pluzhnikov