From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x1135.google.com (mail-yw1-x1135.google.com [IPv6:2607:f8b0:4864:20::1135]) by sourceware.org (Postfix) with ESMTPS id 5DCDB3858D32 for ; Sun, 5 Feb 2023 21:51:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5DCDB3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=google.com Received: by mail-yw1-x1135.google.com with SMTP id 00721157ae682-501c3a414acso139270587b3.7 for ; Sun, 05 Feb 2023 13:51:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=pPfktCzBJ7gsEvHTtfmN541t/ju7jqYy3KTw8Ydk/D8=; b=rcIx6UV7EaAzsy72R1dFeZ0aUiOi1405L0VNWnQCIect5Qa1kX9KWYYLCxB4vBotB6 twBrjNpTZg6KOEaRuJb0KvP3Dcj0VZdCEtkK3RnoBXFpAYplNRc6UUOWj4L+pNhm4Ih0 amECSISk8KuZJUFBetzuRFdo6/vHyBCqj00pLy8qza4f7DokhuS+qqZGKajLd6ju6McK soDiUE69hOhjrUTeL8Hc7MsJ7jPeg+tGX65TKGHGmPq/d28G5CrpHGwTR0ikWT22ef8e U01zuMyZzxlE3deEovf2hWInUV3ZgNmSfe7Y0WYTzsDdsfr/U5mILEOZiaZ7Ow50PNdX D2qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pPfktCzBJ7gsEvHTtfmN541t/ju7jqYy3KTw8Ydk/D8=; b=Q4BzBOY67Y05xK0Ygi/9C0PCnhPCnTb5ay42864dTmNmY2fuUGtUfVGVuN5iPmjGWv eNANhzsIY48Ca1vH4/g59eLgJyZy0WDypEDlaymEnY4Iw3E1ojKhlLhoiOJRITFcNFjb ShOQK+zx4vk9uNakenrLiZ3RHbPA3w/HNJ6LRvAnGmONi5y/xl1VZUU4EbzgQ970nDVs POCXprPaMOuXakdWmxOBEnL05PVHn9SXXtRQYyX7Y1efgWgsKNwFFEDiHWef8hbdVKcU Rad6UOx/hL5dPctLW0KVobMKXHGy54zkqO8a+Gs0CvU5Xd1KFmYlER94bnt0hryKmWLB VGIQ== X-Gm-Message-State: AO0yUKWbxLrwWZT0Kdlix7f6JZWJNUgoLPtvlne5crnxvjmesj7h+6W9 7ze8VFa9r9Tv8rBBO6MWLr8zRkhjahfVeeMEpE7bi3konzSjK3TA X-Google-Smtp-Source: AK7set/ztJUG9BMwOY5sIeNfrJuEOFh4VcKOB261S57L6mTHLWZmR0iNkP3NCyB/reViw8rQx1ugbmoUhKn24oT63K4= X-Received: by 2002:a81:5c82:0:b0:4fd:870d:b6ce with SMTP id q124-20020a815c82000000b004fd870db6cemr1744699ywb.318.1675633915246; Sun, 05 Feb 2023 13:51:55 -0800 (PST) MIME-Version: 1.0 References: <871qnlfhtv.fsf@oldenburg.str.redhat.com> <20230124111019.GC3298@brightrain.aerifal.cx> <878rhsgoxn.fsf@oldenburg.str.redhat.com> <20230124112307.GE3298@brightrain.aerifal.cx> <87zga8f83f.fsf@oldenburg.str.redhat.com> <871qn3yix8.fsf@oldenburg.str.redhat.com> In-Reply-To: <871qn3yix8.fsf@oldenburg.str.redhat.com> From: Paul Pluzhnikov Date: Sun, 5 Feb 2023 13:51:25 -0800 Message-ID: Subject: Re: [patch] Use __builtin_FILE and __builtin_LINE in assert implementation in C++ To: Florian Weimer Cc: Jonathan Wakely , Szabolcs Nagy , Rich Felker , Paul Pluzhnikov via Libc-alpha Content-Type: multipart/mixed; boundary="0000000000004b90af05f3faec79" X-Spam-Status: No, score=-24.9 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,ENV_AND_HDR_SPF_MATCH,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000004b90af05f3faec79 Content-Type: text/plain; charset="UTF-8" On Sun, Feb 5, 2023 at 12:08 PM Florian Weimer wrote: > As I said before, use of these builtins needs to be conditionalized. Yes (revised patch attached). I was more asking whether there were any fundamental objections. Thanks, -- Paul Pluzhnikov --0000000000004b90af05f3faec79 Content-Type: text/plain; charset="US-ASCII"; name="assert-patch-20230205.txt" Content-Disposition: attachment; filename="assert-patch-20230205.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_ldrx54yo0 ZGlmZiAtLWdpdCBhL2Fzc2VydC9hc3NlcnQuaCBiL2Fzc2VydC9hc3NlcnQuaAppbmRleCA3MjIw OWJjNWU3Li42ZWRjYjAxZDBhIDEwMDY0NAotLS0gYS9hc3NlcnQvYXNzZXJ0LmgKKysrIGIvYXNz ZXJ0L2Fzc2VydC5oCkBAIC04NiwxMCArODYsMTggQEAgX19FTkRfREVDTFMKICAgIHBhcmVudGhl c2VzIGFyb3VuZCBFWFBSLiAgT3RoZXJ3aXNlLCB0aG9zZSBhZGRlZCBwYXJlbnRoZXNlcyB3b3Vs ZAogICAgc3VwcHJlc3Mgd2FybmluZ3Mgd2UnZCBleHBlY3QgdG8gYmUgZGV0ZWN0ZWQgYnkgZ2Nj J3MgLVdwYXJlbnRoZXNlcy4gICovCiAjIGlmIGRlZmluZWQgX19jcGx1c3BsdXMKKyMgIGlmIF9f aGFzX2J1aWx0aW4oX19idWlsdGluX0ZJTEUpCisjICAgZGVmaW5lIF9fQVNTRVJUX0ZJTEUgX19i dWlsdGluX0ZJTEUoKQorIyAgIGRlZmluZSBfX0FTU0VSVF9MSU5FIF9fYnVpbHRpbl9MSU5FKCkK KyMgIGVsc2UKKyMgICBkZWZpbmUgX19BU1NFUlRfRklMRSBfX0ZJTEVfXworIyAgIGRlZmluZSBf X0FTU0VSVF9MSU5FIF9fTElORV9fCisjICBlbmRpZgogIyAgZGVmaW5lIGFzc2VydChleHByKQkJ CQkJCQlcCiAgICAgIChzdGF0aWNfY2FzdCA8Ym9vbD4gKGV4cHIpCQkJCQkJXAogICAgICAgPyB2 b2lkICgwKQkJCQkJCQlcCi0gICAgICA6IF9fYXNzZXJ0X2ZhaWwgKCNleHByLCBfX0ZJTEVfXywg X19MSU5FX18sIF9fQVNTRVJUX0ZVTkNUSU9OKSkKKyAgICAgIDogX19hc3NlcnRfZmFpbCAoI2V4 cHIsIF9fQVNTRVJUX0ZJTEUsIF9fQVNTRVJUX0xJTkUsICAgICAgICAgICAgIFwKKyAgICAgICAg ICAgICAgICAgICAgICAgX19BU1NFUlRfRlVOQ1RJT04pKQogIyBlbGlmICFkZWZpbmVkIF9fR05V Q19fIHx8IGRlZmluZWQgX19TVFJJQ1RfQU5TSV9fCiAjICBkZWZpbmUgYXNzZXJ0KGV4cHIpCQkJ CQkJCVwKICAgICAoKGV4cHIpCQkJCQkJCQlcCg== --0000000000004b90af05f3faec79--