From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x112a.google.com (mail-yw1-x112a.google.com [IPv6:2607:f8b0:4864:20::112a]) by sourceware.org (Postfix) with ESMTPS id 148693858D1E for ; Mon, 6 Feb 2023 16:25:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 148693858D1E Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=google.com Received: by mail-yw1-x112a.google.com with SMTP id 00721157ae682-520dad0a7d2so162763477b3.5 for ; Mon, 06 Feb 2023 08:25:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=TP/cZq8Yf0k4rq5zDFJ0JYfZb3xE4rH60VwEC0oqCB4=; b=C6qQwJHrkc2SiQPWB6up48f2k2cLcQrvO77sMKXA0wnyN7v6fxdRkcBMj+O3uoYbVw 97B2T0GUo0yRi71y3vuypGzsfFx67P7zQ3oXtMBNznVuNxQ1odQoJwsFEgwiBG7RlFrK RbDGhXjc0HKARLNjoV25arxjj2QOpuwVoEy6GVgZkG0Ws2lNfQib5SfXAvnlbEX6u+zS sQOcAmWZbCgM0rB+/VEHOxTJdM9nYslgQeOsgdvO9mbvSPGkmgvwNI4zL8a6Ow0yy5gz gO9o/dOaWY3dL7vYbUL8PSG7mCJf4Q2bQ5TQqCESjG17tpTeaXXyggS8krbDD7giNTFU I6bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TP/cZq8Yf0k4rq5zDFJ0JYfZb3xE4rH60VwEC0oqCB4=; b=quJ/91+tnB3oOfAHFyaZaRG6aKQbbdhqf/8TRSWXgJPNbmCow1U0JFRuheYZ01WkNf 4POUq/QIbnr+SnHG/Dr6BgicOOdl9HSZxMzj20FhdUFB9w0KVtgXyzy0+ClQo2TgiwZH b7DBIHiI7HPsMgFGVgV2rZdnisH5TnTAItnuo2Ie3FKb30futAYw+VHtOqgp4HR1BcN9 RpIx3qNA9YU0Pk3uvDWGatVJ2jQeAaQKascVFBLXCNYzufN9JFiJeM/xlu3R50ZMV9Ps Q9ZEgBcXPeNJ8DYcpn0PIy0CPnxl++wru9LqnT9N5YqKd+Yp7yoMEGW4GkQhL81Jhv4+ BWRw== X-Gm-Message-State: AO0yUKWP2bxlliW3bBlHIqcEoW5w9zCa/gskxvS0PrgyA4ZyUOYMCc5h XEs/Yj11DRwhmYraArwUox1DgJ1Jd5Ppr7h0C8fmIQ== X-Google-Smtp-Source: AK7set+WPPlNlfI5PGXrcU/6N321RgnfEhr4nwAVFyGLbi/UzPwfzhFOYDuSe/Z+MKUF2NIeaWmQwl/sdqcYBPPmfYs= X-Received: by 2002:a0d:ff84:0:b0:506:523c:bcb2 with SMTP id p126-20020a0dff84000000b00506523cbcb2mr2067146ywf.473.1675700755015; Mon, 06 Feb 2023 08:25:55 -0800 (PST) MIME-Version: 1.0 References: <871qnlfhtv.fsf@oldenburg.str.redhat.com> <20230124111019.GC3298@brightrain.aerifal.cx> <878rhsgoxn.fsf@oldenburg.str.redhat.com> <20230124112307.GE3298@brightrain.aerifal.cx> <87zga8f83f.fsf@oldenburg.str.redhat.com> <871qn3yix8.fsf@oldenburg.str.redhat.com> <87o7q7wxli.fsf@oldenburg.str.redhat.com> <87fsbjwcw6.fsf@oldenburg.str.redhat.com> In-Reply-To: <87fsbjwcw6.fsf@oldenburg.str.redhat.com> From: Paul Pluzhnikov Date: Mon, 6 Feb 2023 08:25:24 -0800 Message-ID: Subject: Re: [patch] Use __builtin_FILE and __builtin_LINE in assert implementation in C++ To: Florian Weimer Cc: Jonathan Wakely , Szabolcs Nagy , Rich Felker , Paul Pluzhnikov via Libc-alpha Content-Type: multipart/mixed; boundary="00000000000041beab05f40a7c94" X-Spam-Status: No, score=-24.7 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,ENV_AND_HDR_SPF_MATCH,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --00000000000041beab05f40a7c94 Content-Type: text/plain; charset="UTF-8" On Sun, Feb 5, 2023 at 10:01 PM Florian Weimer wrote: > Missing spaces before '(', sorry. Done. Rest looks okay if we can assume that > __builtin_FILE and __builtin_LINE are implemented at the same time. GCC has added these so long ago, we don't care (I think). LLVM commit https://reviews.llvm.org/D37035 implemented both at the same time. -- Paul Pluzhnikov --00000000000041beab05f40a7c94 Content-Type: text/plain; charset="US-ASCII"; name="assert-patch-20230206.txt" Content-Disposition: attachment; filename="assert-patch-20230206.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_ldt0w1ex0 ZGlmZiAtLWdpdCBhL2Fzc2VydC9hc3NlcnQuaCBiL2Fzc2VydC9hc3NlcnQuaAppbmRleCA3MjIw OWJjNWU3Li42MzE5N2I4MTljIDEwMDY0NAotLS0gYS9hc3NlcnQvYXNzZXJ0LmgKKysrIGIvYXNz ZXJ0L2Fzc2VydC5oCkBAIC04NiwxMCArODYsMjEgQEAgX19FTkRfREVDTFMKICAgIHBhcmVudGhl c2VzIGFyb3VuZCBFWFBSLiAgT3RoZXJ3aXNlLCB0aG9zZSBhZGRlZCBwYXJlbnRoZXNlcyB3b3Vs ZAogICAgc3VwcHJlc3Mgd2FybmluZ3Mgd2UnZCBleHBlY3QgdG8gYmUgZGV0ZWN0ZWQgYnkgZ2Nj J3MgLVdwYXJlbnRoZXNlcy4gICovCiAjIGlmIGRlZmluZWQgX19jcGx1c3BsdXMKKyMgIGlmIGRl ZmluZWQgX19oYXNfYnVpbHRpbgorIyAgIGlmIF9faGFzX2J1aWx0aW4gKF9fYnVpbHRpbl9GSUxF KQorIyAgICBkZWZpbmUgX19BU1NFUlRfRklMRSBfX2J1aWx0aW5fRklMRSAoKQorIyAgICBkZWZp bmUgX19BU1NFUlRfTElORSBfX2J1aWx0aW5fTElORSAoKQorIyAgIGVuZGlmCisjICBlbmRpZgor IyAgaWYgIWRlZmluZWQoX19BU1NFUlRfRklMRSkKKyMgICBkZWZpbmUgX19BU1NFUlRfRklMRSBf X0ZJTEVfXworIyAgIGRlZmluZSBfX0FTU0VSVF9MSU5FIF9fTElORV9fCisjICBlbmRpZgogIyAg ZGVmaW5lIGFzc2VydChleHByKQkJCQkJCQlcCiAgICAgIChzdGF0aWNfY2FzdCA8Ym9vbD4gKGV4 cHIpCQkJCQkJXAogICAgICAgPyB2b2lkICgwKQkJCQkJCQlcCi0gICAgICA6IF9fYXNzZXJ0X2Zh aWwgKCNleHByLCBfX0ZJTEVfXywgX19MSU5FX18sIF9fQVNTRVJUX0ZVTkNUSU9OKSkKKyAgICAg IDogX19hc3NlcnRfZmFpbCAoI2V4cHIsIF9fQVNTRVJUX0ZJTEUsIF9fQVNTRVJUX0xJTkUsICAg ICAgICAgICAgIFwKKyAgICAgICAgICAgICAgICAgICAgICAgX19BU1NFUlRfRlVOQ1RJT04pKQog IyBlbGlmICFkZWZpbmVkIF9fR05VQ19fIHx8IGRlZmluZWQgX19TVFJJQ1RfQU5TSV9fCiAjICBk ZWZpbmUgYXNzZXJ0KGV4cHIpCQkJCQkJCVwKICAgICAoKGV4cHIpCQkJCQkJCQlcCg== --00000000000041beab05f40a7c94--