From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by sourceware.org (Postfix) with ESMTPS id 9F3A03858D28 for ; Wed, 25 Jan 2023 20:51:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9F3A03858D28 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=google.com Received: by mail-wr1-x429.google.com with SMTP id h16so18288489wrz.12 for ; Wed, 25 Jan 2023 12:51:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=UT84qiIQ0nHZm83YX0nwOakwZvlPDnne/TJe+mb3k0o=; b=nTw1X5ZdK24oAmFH5yfsbDlLRrlbQ5quFyf5FitGYJcpm2uo/PWLGr/1MM4kOwBWyl M+mTWq2q7AB763TWChJKcVuK0YucKO4m2kmGH7nx/E0sMeKWUpqTrU0aHK4n2d1nrwft SsIKVvAli0vEcofPR6Z58s/eZsL7Y+pjIzXylwM/XhPN2FMJGsWMXIaliHpXs3+FQ32K HKjxXzf9eShodisq4BnuCG/f35LaK6TbyeA6iv6rDkMv4QJauPhIpWMoB13UiyXsB39C jkkoaCnLTMfzWdgJ1Lv6PYLIXApFXNZUbmnuRWhcY881zlNqGVBjLHe/HI8hgftiZeE2 WMIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UT84qiIQ0nHZm83YX0nwOakwZvlPDnne/TJe+mb3k0o=; b=qMg7RqpPgKYLf0Vn3H8fVnBI3HtzT3gkYS43lF+c3jImE05h64q5Hs7z9yw5f5C5D8 iFYu9Y+ySEaMJdslMkhQg/1xGEeOGylNFkfc4HomV7YE2lavw6MAuAosoBhweb2yy3Lk uLvx1lLAFvFzfUxPzmJGYgaw1qhgpFQFQFlvHtaeHig2+v573o0B7wAgW/O0hqGb5nDD mqMoczcU+vnD3PpokQFQd7gHMc3zkzzgOkjVmAK1QpciESEtEXu+V5WxHPoI9VVQDZsz XSAweROUp6ifeeoalxrBu6hVCJRhE7r3Lk1+TojwTVrNjt1NZHuXFH2edvpRKdsbqkbK 5FfA== X-Gm-Message-State: AFqh2kqtmshfsqi7Guvp6BX0rkMQcmsxNR7tFa4BDBreyz12Jb+1GyXJ r2fO88nlr7LcJuEgQHolmnFXjPU+IbNI0ClGXgQ5d6GY3gDSCRZn X-Google-Smtp-Source: AMrXdXuzL+OVS/MGhSwhDQmufEyPT7ZTF2L60qhRgzDGrhdbDoPGl4UbxuNKQSOE38Wvhds16vmnazxi7D384+a3nLs= X-Received: by 2002:a5d:6b8b:0:b0:2be:3576:f208 with SMTP id n11-20020a5d6b8b000000b002be3576f208mr961831wrx.331.1674679869708; Wed, 25 Jan 2023 12:51:09 -0800 (PST) MIME-Version: 1.0 References: <871qnlfhtv.fsf@oldenburg.str.redhat.com> <20230124111019.GC3298@brightrain.aerifal.cx> <878rhsgoxn.fsf@oldenburg.str.redhat.com> <20230124112307.GE3298@brightrain.aerifal.cx> In-Reply-To: From: Paul Pluzhnikov Date: Wed, 25 Jan 2023 12:50:41 -0800 Message-ID: Subject: Re: [patch] Use __builtin_FILE and __builtin_LINE in assert implementation in C++ To: Jonathan Wakely Cc: Rich Felker , Florian Weimer , Paul Pluzhnikov via Libc-alpha Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-20.0 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Jan 24, 2023 at 3:54 AM Jonathan Wakely wrote: > Added to GCC 4.8.0 in 2012. I don't know about Clang. (Like I said in the original email.) Clang implementation is quite a bit more recent: commit 708afb56c125ca4f7db7070e836860076c7eafbc Author: Eric Fiselier Date: Thu May 16 21:04:15 2019 +0000 Implement __builtin_LINE() et. al. to support source location capture. I feel like a __has_builtin gate isn't really necessary here, but will put one in if people think it's necessary. On Tue, 24 Jan 2023 at 11:38, Rich Felker wrote: > (Also, C++ programmers should stop putting so much code in inline > functions in headers. There are C++ projects (Boost, Eigen) which consist _entirely_ of headers. It was Eigen that has triggered this thread. We could rewrite eigen_assert() to use source_location instead of assert(), but I thought fixing it here is better, since it fixes all C++ projects and not just Eigen. -- Paul Pluzhnikov