From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=Th5D=6B=google.com=ppluzhnikov@sourceware.org>
Received: from mail-yw1-x1133.google.com (mail-yw1-x1133.google.com [IPv6:2607:f8b0:4864:20::1133])
	by sourceware.org (Postfix) with ESMTPS id 773A23858D32
	for <libc-alpha@sourceware.org>; Sun,  5 Feb 2023 18:39:42 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 773A23858D32
Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=google.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=google.com
Received: by mail-yw1-x1133.google.com with SMTP id 00721157ae682-52770ee8cf0so56943577b3.2
        for <libc-alpha@sourceware.org>; Sun, 05 Feb 2023 10:39:42 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=google.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=9LJ5DZJaIGZjIR8LCsvjjDMi5Zb6RpFnDMeE35Wy2Kg=;
        b=DiMktDUKz9kyLqfqIoUh46I9fNvSYjIRRcXnGLyH/qY2+kD+hQUsNZJaQkfRliyNxE
         yV+wmZ8vrVKTYIKlzvpEe3ogr71u98decoDU5hQ+X8Asjht66hzS601Dv2ZfgKuSf9Op
         JaH9K7fronSVSQTNOqAulhw3+t0rhsyfLuGXpbG89mo31IK3/UdPE9hYAvc4jeWKrSKY
         ftErMc+MOPVWSCsrO7UIoW/YaobtV8/IwjsO8wLMyDbg2sKvTaxOUVCZ3X6zGYzuuIz3
         09u6cbRs3B1y0I3okeOeJe+vO3HqEz74+vjXO5Eh/SyggFB/4isn3DupUGQzcRYe0RwL
         tLhw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=9LJ5DZJaIGZjIR8LCsvjjDMi5Zb6RpFnDMeE35Wy2Kg=;
        b=tgs2URNSdqb7VBa1h+GXwVKDI9Jwbw3v3MF5TygpZ9vEjQHPrFtmeUgpfwfXcHiQRd
         MC6y+RQ0BvVkJqoPVofoliyGKww8ax025IK5dh73p4NogcsNs6HJBkcLF/bNrMKg0v/h
         tEF6Ivg94fyWYyFbbVvBUEpsFc8hngy/xBsEBBFdlvnGmUKZc8TbjKxAwrGMw3jT2zoS
         BcKlZ6wINb9Ls4aL6Jeltapkd+n01lxbWu2f58ELeI+cmfRyJ7AKMT5IDN3pi2yzQYYN
         q9SbeJaF0pqQWvaUdaplHY5Vu9TZ+q/mM/AYBQTQ8Ah8IIloiraqCiEBpWp+sLCiAKWP
         M/7g==
X-Gm-Message-State: AO0yUKULCq30xZ9/9ifCJwSMmkjeYfbaJ9cD/nRnKfky7gbY8Ck1N5Of
	vSOWshIsmoPTg7adiFgVa1Smve2mkO7KKB05FjxAug==
X-Google-Smtp-Source: AK7set9Huy4EfL+1lHCAcBrvREAP9w44WMCr5NI9A7Y5+tGdt1l2YdUO6si/yQaf+twQ7t3CPKWwKyR1+qULqVfBqhM=
X-Received: by 2002:a81:5c82:0:b0:4fd:870d:b6ce with SMTP id
 q124-20020a815c82000000b004fd870db6cemr1687775ywb.318.1675622381413; Sun, 05
 Feb 2023 10:39:41 -0800 (PST)
MIME-Version: 1.0
References: <CALoOobP+sGwmAA-14zxN+T_oxcdy-Nhfc-0qECZYsFvFNCKk1A@mail.gmail.com>
 <871qnlfhtv.fsf@oldenburg.str.redhat.com> <20230124111019.GC3298@brightrain.aerifal.cx>
 <878rhsgoxn.fsf@oldenburg.str.redhat.com> <20230124112307.GE3298@brightrain.aerifal.cx>
 <CACb0b4nXwwY73Eo3kFQ+cHs10GLgRd7SX15-YJo9EBV6hK6Piw@mail.gmail.com>
 <87zga8f83f.fsf@oldenburg.str.redhat.com> <CACb0b4nCx6MT+LSzMDo-k-9FODd3efb0YZ+YH7+UroJYp5bCxg@mail.gmail.com>
 <Y8/0O3XmWK+GJkCG@arm.com> <CACb0b4mOiRtajHKp=HeM4-pb=7=A0qtR0tnEX+9SqJ1ceMVfvQ@mail.gmail.com>
 <CALoOobNabo-6s1acjUCS9b2j+W1VfdcZV5AA7DX7LxU8kkQqSw@mail.gmail.com> <CACb0b4kB-e0W+4Kx4yw6MKnpCEKoiBV3rxL0FwKyMgOhM+royg@mail.gmail.com>
In-Reply-To: <CACb0b4kB-e0W+4Kx4yw6MKnpCEKoiBV3rxL0FwKyMgOhM+royg@mail.gmail.com>
From: Paul Pluzhnikov <ppluzhnikov@google.com>
Date: Sun, 5 Feb 2023 10:39:12 -0800
Message-ID: <CALoOobPysmS=ZJ_wMdogs1zqBBKPtR13akErpC8RcRJ+h3Uf5Q@mail.gmail.com>
Subject: Re: [patch] Use __builtin_FILE and __builtin_LINE in assert
 implementation in C++
To: Jonathan Wakely <jwakely@redhat.com>
Cc: Szabolcs Nagy <szabolcs.nagy@arm.com>, Florian Weimer <fweimer@redhat.com>, 
	Rich Felker <dalias@libc.org>, 
	Paul Pluzhnikov via Libc-alpha <libc-alpha@sourceware.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-18.9 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libc-alpha.sourceware.org>

Ping?

Are there any strong objections to this patch which haven't been addressed?

It seems that
- it's a complete no-op in plain-C
- it helps C++ modules
- it has no real negatives

and as such should be a "no brainer".

Thanks,
-- 
Paul Pluzhnikov