From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by sourceware.org (Postfix) with ESMTPS id 007DC3858CDB for ; Mon, 26 Feb 2024 17:58:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 007DC3858CDB Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 007DC3858CDB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::233 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708970283; cv=none; b=xI6tH4b/SF/qpXTMCEC2z+/FfA2UJsdP0YwmpbIIvp5ky049a3A9bGePSgg0Va2XFk/FblAZfB26mAGxHN3Nrwt5Zxy6e71Mp7Q+o57D9THConFhFbkoew3fOaKmeTSUojiW826usbZ2roHTrUm2MjBdzv5Ic0RVJhRCYZW8qa4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708970283; c=relaxed/simple; bh=ZMzU81Ia4anHRL8zB6xpdAqziYaEuJt3IvnixSibI6M=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=hUt1au4Gee32rH2mLevDhOyo5R5eI43D1WEczFkhLgpdbp/E7VTpdZ+9ViNp2PwPssWie+nawpKVMhwA8qj4PKZOfCvhHRV8Ukmb3osE5gCgtf4eaAYUEdqqNQoyk6fZWWyuw21l4ZUWtagaJ7l61X7vvDP9X6CjcBQN3hnmnW8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x233.google.com with SMTP id 38308e7fff4ca-2d24a727f78so47988531fa.0 for ; Mon, 26 Feb 2024 09:58:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1708970279; x=1709575079; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=L5Dw3nQqwKGY47Izaew4EjZcDYRF1HpfuOeAn/rT864=; b=P4+FZ/eQiT5Ye65V39AvmDrRBFtC9XV2cUyjgDjx2nZa9vzmxeNB4oqijipaz9Pqrt 3N3su1EiGGIRgelMHUNEyOP3zRy3BCWwIX6Gk6Q2QzN5nzbfGvEsu+zGVHMsjJWU08VX bMmftkAD47nUfWOs6edAp1pGBMwaUF63WRCC+AlH6Jy+wxLsKhmAVYZmD8ncOzNJPwJ1 Z9aLvsWvmXUUTQ6pmXSAW42NLBwecEB7Pe+HarDsteMILXErCjy82utEWr2HH6c4QcX+ 75mdDCJk8HgrSpqtmc/kQrS1gcGle6YTQCq5/ELKoHkgxgKWtG7Twu76hQIOFg2lJHJk wPEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708970279; x=1709575079; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=L5Dw3nQqwKGY47Izaew4EjZcDYRF1HpfuOeAn/rT864=; b=RZXv9XF/Ivt24ZTYGjs+HwKxmL/lRKkMsrPuLtPVQxt13tKhsXN3ji2pr0rSfIgEoa BMC5Pel8DZjYGGTvsKkLs4Uf+7MyP6Ie8dOKZuCZz2nfuO3D1sNCeZdPEbSe0eBjMTe5 VDuBR+0lZTrSzRYgzAdbnOfIxMdi/p4x2yFr0Zv6peURYr+T2OMzmf2GktBiHKLGi5Q1 80MhU2Ob2SPQxpodVrZvuYYID6Zab3vJHFDND+4bwKAAuPsKftEAbEvHjQsu4kzqgXZt uCJHzc+vC7uc6o2PYDRGPaXQ3x332WowzLsfVSDFWkQRM32O8oHx3hKQZve0L+bgSiIO ZBfg== X-Forwarded-Encrypted: i=1; AJvYcCUAAtpFn6Unx0C7eUB7OyVguo9DYblEifxtxbyob1wGSs+d0DsFyIbBHR1/62Z34dyY1eSq8hpWEtYTmVk/9P1CIK3aA3HSsRb3 X-Gm-Message-State: AOJu0Yz9WUbewMz2GoyG94sVSZtVbE+y7bO/dnEgb2+HcWOzW/oSQ15F V0upbudj991DN4HyzO8YGdgr3RpQE/G58vNtmJDNpa7VP/NxUJmfgDuLlVbn2UaTJfN4ai15Mn6 Y91pca8lc+9oGVz64UPsrKPhgc8RnPc/hYRs89g== X-Google-Smtp-Source: AGHT+IGSETSdkLCbFkVkI4HSBxuVadjizgATF/VHooCuB6LF/b2dk3ytWJ3VayGvPrMmx0iMAIsNcl2mJDJOhI9mLxc= X-Received: by 2002:a05:651c:2112:b0:2d2:892a:62 with SMTP id a18-20020a05651c211200b002d2892a0062mr3753237ljq.46.1708970279259; Mon, 26 Feb 2024 09:57:59 -0800 (PST) MIME-Version: 1.0 References: <20240214143159.2951158-1-evan@rivosinc.com> <20240214143159.2951158-3-evan@rivosinc.com> <877cj47t0f.fsf@oldenburg.str.redhat.com> <87sf1iw0nu.fsf@mid.deneb.enyo.de> <87v86byx0a.fsf@mid.deneb.enyo.de> In-Reply-To: <87v86byx0a.fsf@mid.deneb.enyo.de> From: Evan Green Date: Mon, 26 Feb 2024 09:57:23 -0800 Message-ID: Subject: Re: [PATCH v12 2/7] linux: Introduce INTERNAL_VSYSCALL To: Florian Weimer Cc: Florian Weimer , libc-alpha@sourceware.org, vineetg@rivosinc.com, slewis@rivosinc.com, palmer@rivosinc.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Feb 26, 2024 at 9:07=E2=80=AFAM Florian Weimer w= rote: > > * Evan Green: > > > I like it! I'm guessing I should continue to use the > > INTERNAL_SYSCALL_ERRNO_P() and INTERNAL_SYSCALL_ERRNO(), and you > > omitted it for example's sake. Will plan to spin with this. > > We already hard-code the Linux convention in a few places, e.g. > sysdeps/unix/sysv/linux/fstatat64.c, > sysdeps/unix/sysv/linux/clock_gettime.c. I don't think the macros add > value here. We also don't have a macro to inject the error code, I > believe, so one -ENOSYS will stick around. But I don't feel strongly > about it. Got it, will spin with this as-is then. Thanks for the clarification. -Evan