From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb33.google.com (mail-yb1-xb33.google.com [IPv6:2607:f8b0:4864:20::b33]) by sourceware.org (Postfix) with ESMTPS id 2A2233857BB8 for ; Thu, 14 Jul 2022 03:03:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2A2233857BB8 Received: by mail-yb1-xb33.google.com with SMTP id 64so1009047ybt.12 for ; Wed, 13 Jul 2022 20:03:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fQnOlgGhX0tnX5Cnpx1aFtcnU+Xw5rlq2JgSuZMlt08=; b=8HkZdmdQ68TFUZcbakgocEXooqVgoQq/3cxR0hE4cZ2UoIRN9lDK/2vmBofotDBJsP NRmSsFcvZWWBh9xmXqyVWdAELYNUiwLMWZ1C7mqn7nX8G9MCmPas4L1FFb1YZ4EfzWxD mKxeffvMkDnj4cWt+G1NRplDUMEtyQqQX1Ti1TI4ZvglOdaZrscu/CFSWmzJWxdJGY01 Ng94JbDrXisDX7uh3SbKemNbtCulVuggW18XE/AC7Vq7suiul9tUj8uc2lwcmkSRXVgW K7V4Qp0vbZkcOvlmPFqSf5A7qrlg+mhDxy+PpUKvLP4EGoi6wRtuxXxkisKR0Y2HBuRL nVfQ== X-Gm-Message-State: AJIora/Nk53WeViDziEgwR2Jn2ciKu5xMj6VbADikOaPZ4lJWxvMjkU9 i4VAuN3GfRU36xK47ITOwRbPfkOvXyHeePxhx1s= X-Google-Smtp-Source: AGRyM1srmKnvOJYDr5W/LpSC8OlegdZ9KgH14d/qGnAXUAuwhyYzZ7v9gNoYLm51hjrsMCXdfW3qhjMTZ0R4sPcXQPc= X-Received: by 2002:a05:6902:102c:b0:66e:ac5b:7053 with SMTP id x12-20020a056902102c00b0066eac5b7053mr6442957ybt.60.1657767833632; Wed, 13 Jul 2022 20:03:53 -0700 (PDT) MIME-Version: 1.0 References: <20220628152735.17863-1-goldstein.w.n@gmail.com> In-Reply-To: From: Sunil Pandey Date: Wed, 13 Jul 2022 20:03:17 -0700 Message-ID: Subject: Re: [PATCH v1 1/3] x86: Add definition for __wmemset_chk AVX2 RTM in ifunc impl list To: Noah Goldstein Cc: "H.J. Lu" , GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, HK_RANDOM_ENVFROM, HK_RANDOM_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jul 2022 03:03:55 -0000 On Wed, Jun 29, 2022 at 4:09 PM Noah Goldstein via Libc-alpha wrote: > > On Wed, Jun 29, 2022 at 12:22 PM H.J. Lu wrote: > > > > On Tue, Jun 28, 2022 at 8:27 AM Noah Goldstein wrote: > > > > > > This was simply missing and meant we weren't testing it properly. > > > --- > > > sysdeps/x86_64/multiarch/ifunc-impl-list.c | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/sysdeps/x86_64/multiarch/ifunc-impl-list.c b/sysdeps/x86_64/multiarch/ifunc-impl-list.c > > > index 251b0022d9..3ae4d49bee 100644 > > > --- a/sysdeps/x86_64/multiarch/ifunc-impl-list.c > > > +++ b/sysdeps/x86_64/multiarch/ifunc-impl-list.c > > > @@ -1028,6 +1028,10 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array, > > > IFUNC_IMPL_ADD (array, i, __wmemset_chk, > > > CPU_FEATURE_USABLE (AVX2), > > > __wmemset_chk_avx2_unaligned) > > > + IFUNC_IMPL_ADD (array, i, wmemset_chk, > This wasn't __wmemset_chk > > > + (CPU_FEATURE_USABLE (AVX2) > > > + && CPU_FEATURE_USABLE (RTM)), > > > + __wmemset_chk_avx2_unaligned_rtm) > > > IFUNC_IMPL_ADD (array, i, __wmemset_chk, > > > (CPU_FEATURE_USABLE (AVX512VL) > > > && CPU_FEATURE_USABLE (AVX512BW) > > > -- > > > 2.34.1 > > > > > > > LGTM. > > > > Thanks. > > > > There was an issue with this patch standalone. > > Fixed in V3. > > -- > > H.J. I would like to backport this patch to release branches. Any comments or objections? --Sunil