From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x22f.google.com (mail-oi1-x22f.google.com [IPv6:2607:f8b0:4864:20::22f]) by sourceware.org (Postfix) with ESMTPS id 71F143858D1E for ; Mon, 3 Oct 2022 20:52:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 71F143858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oi1-x22f.google.com with SMTP id v130so12521985oie.2 for ; Mon, 03 Oct 2022 13:52:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date; bh=p2Hc+k5XgfFb+iMfQZxOC2AZFmiqEQdG4ZiP8gN+DCA=; b=YA/JNaZJiX96BNyNJj1f336VBYIrUmfhaETXTuugiet7AiWXNWpOpamy0JN2FvUR0w tjww4ZO84VDrQgcJZ8cR+tUtw9tFTLTsIDTyQqpMi5Gexhqqha9RE4IQakQvI+b4Sn6h p+JTJxA3lbDg4FeL3AqJSxVG7bBvhuMKmH6/BNp4hLAPRCzkqdyEQneuaPZs8Nw1yclr KSoNfW8H7fbjNP4A7/3fCi2GVZ/88qg8IoHdk8KODvQ9DRl7Xyjvby6HEQ+pQOx9PM7Y LsVT1nvokle0ZdPOYGDMv+QbkP9NYFYmqzVv5y/x5o1Ul8EuetWH2IHGFbmCtRl/3Sjg RlHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date; bh=p2Hc+k5XgfFb+iMfQZxOC2AZFmiqEQdG4ZiP8gN+DCA=; b=z+TMMOvTkZg0KhZG0Q9YlSHqgdS64xgPDiDCltnxFR2efo1/A4gcknRXtmy8Vrbw3S KsKuLGz5p6MOS/rk2s+l7MIn3OIxm+bHCY0d+evZAwVlWVlukSSzC74W0ZK4d8h6cxXO q/HNElJ2gNXiupUN9n9VZeM38LF1Lpa1As86MAXGVsA4BA6MgY6Iy7MXRRtj5jFZFPfs etOtdjf2LfnwCqTUq89g9hyBdErdJGncZWArLGbzfxGOmGwTRvaEgO5agOTtfHR6L9yC +USZSD+ScRELOIvPNdiXdLg2Q6UP91uSdA/PqZmgK0p929yRScIau+CWMN0cDf7LTUvx 9VjQ== X-Gm-Message-State: ACrzQf1adjQwiGDEfl0MMTpoaRqZg3uVZkL4OZyHc0cEoBgjhYbKizYT UxZWuFRwmA7c2P/t3Cna7IW3hgizJLaDISC7uD0Baflf X-Google-Smtp-Source: AMsMyM4R/OsF4klgf4IxQ3XQVh2iwHRb60EONO2V44+Uc9HsB51LvnqN4RnuNXYwgINzVmbFIbMU/7E18aSTU7moXs8= X-Received: by 2002:a05:6808:2116:b0:350:189d:306e with SMTP id r22-20020a056808211600b00350189d306emr4865287oiw.154.1664830339800; Mon, 03 Oct 2022 13:52:19 -0700 (PDT) MIME-Version: 1.0 References: <20221002123424.3079805-1-aurelien@aurel32.net> <20221002123424.3079805-3-aurelien@aurel32.net> In-Reply-To: From: Sunil Pandey Date: Mon, 3 Oct 2022 13:51:43 -0700 Message-ID: Subject: Re: [PATCH v2 2/6] x86-64: Require BMI2 for AVX2 str*cmp and wcs(n)cmp implementations To: Sunil Pandey , Noah Goldstein , Hongjiu Lu , libc-alpha@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,HK_RANDOM_ENVFROM,HK_RANDOM_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Oct 3, 2022 at 12:59 PM Aurelien Jarno wrote: > > On 2022-10-03 21:21, Aurelien Jarno wrote: > > On 2022-10-03 11:43, Sunil Pandey wrote: > > > On Mon, Oct 3, 2022 at 10:50 AM Noah Goldstein wrote: > > > > > > > > On Mon, Oct 3, 2022 at 10:35 AM Aurelien Jarno wrote: > > > > > > > > > > On 2022-10-03 09:19, Sunil Pandey via Libc-alpha wrote: > > > > > > Please separate this patch into 4 separate patches. > > > > > > > > > > > > Patch1: sysdeps/x86_64/multiarch/strncmp.c > > > > > > Patch2: sysdeps/x86_64/multiarch/strcmp.c > > > > > > Patch3: sysdeps/x86_64/multiarch/ifunc-strcasecmp.h > > > > > > Patch4: sysdeps/x86_64/multiarch/ifunc-impl-list.c > > > > > > > > > > > > Rest of them looks OK to me. > > > > > > > > > > I don't fully see the point of doing that, but i'll do it in the next > > > > > version. > > > > > > > > I think to make backporting easier. > > > > > > Exactly. > > > > > > If you look closely, this patch combines 4 independent ifunc > > > functionality in one single patch. > > > > It's partially true. I actually count 3 different functionalities. The > > changes in ifunc-impl-list are all related to the other 3. > > I have just sent a v3 that split that patch in smaller pieces: > - str(n)casecmp > - strcmp > - strncmp > - wcs(n)cmp > > I do not see the point in separating the changes from ifunc-impl-list.c, > as we should actually ensure that they are in sync with the ifunc > selector so that the testing is done properly. My feedback was for the specific patch for your previous arrangement. After you rearrange in v3, it looks ok. > > -- > Aurelien Jarno GPG: 4096R/1DDD8C9B > aurelien@aurel32.net http://www.aurel32.net