From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x22c.google.com (mail-oi1-x22c.google.com [IPv6:2607:f8b0:4864:20::22c]) by sourceware.org (Postfix) with ESMTPS id A47B23858D38 for ; Mon, 3 Oct 2022 18:44:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A47B23858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oi1-x22c.google.com with SMTP id d64so12200396oia.9 for ; Mon, 03 Oct 2022 11:44:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=yjPP0+xpqKY+OW67YM+EPEFxrj4rCIkqxlgM4bCvEUI=; b=XwAH1eEC3jwH5EYinVMdZIf0KaqvDcQ78PzoDLzwAmuoYDQ6zWqaoqj9NGNabJgwiy KZGNUiqZyAVKFMDMjhHQwlkGufmMNhpI6baEU/ReW5uZ6vxRmdZLdeicxFqs/9YanJGC PMmKogPQDJRE6nLHo8RkInQtNj1MF0foQoj3zzb6HjOHb4TiUCJ1Sg2UshTQ/6wgEucI trJ73NDq6p9G8/tWpQI503ehyiIHz/wT1cJz6pYthv5/tG2PYLPaRMZ3WKYFIN12MNuG +oTIdjJ/1JxlzztbSpnJS/XrSzdreB0SSOTl5ThuLZJjiOBO+aDnE4GiQodZnk0Yq0kh lhCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=yjPP0+xpqKY+OW67YM+EPEFxrj4rCIkqxlgM4bCvEUI=; b=r02K7SeaKWZVFuChPI2JR0307SofV0m5WujaeK0zcCAgIXmXv2LKYxvjetSah2FtZy /T1NhAVb2I7vOx26pIA3QonNg6eml5KN/+6TNFMHleIaDiP5VM/6Ie6GfsRBYYcKpbAZ XiS4i7MfRbzjfVkPPL7isHeEklxSB7exZvwxGGS1NMolGyOM0ZNEvCllehDxDmcbz2oT WSdPUp7yKY89dpRxTS0RJyeib4GlUlmJ69tXuZRw/6zvDCCxmj7L3Hw2VyibxWxwrheO Kw5b7d3QJWZPZ2m03FJY0W6T3V01goxrXv1kDFBU8b+l5k652GYQ/9xTlzFfL3H6y1V2 Wn3Q== X-Gm-Message-State: ACrzQf2IYdQNoDOXGOP/tl8ZxI4aYHFbWsNsNWRfwvoWH8l/6AXHWQDz dddpVbVxWQENa3AnWUusZEWz8+aIjy59QQ4GkTc5EMav X-Google-Smtp-Source: AMsMyM5TaAC+io3Aq1v9+QB3QENMVDrzHgAU92ndVGshii3/javx6OeWliUByWoRCE4qM5v89MTIKReL3KVBziog9Ng= X-Received: by 2002:a05:6808:1187:b0:353:a617:6acd with SMTP id j7-20020a056808118700b00353a6176acdmr2906483oil.105.1664822664903; Mon, 03 Oct 2022 11:44:24 -0700 (PDT) MIME-Version: 1.0 References: <20221002123424.3079805-1-aurelien@aurel32.net> <20221002123424.3079805-3-aurelien@aurel32.net> In-Reply-To: From: Sunil Pandey Date: Mon, 3 Oct 2022 11:43:49 -0700 Message-ID: Subject: Re: [PATCH v2 2/6] x86-64: Require BMI2 for AVX2 str*cmp and wcs(n)cmp implementations To: Noah Goldstein , Aurelien Jarno , Hongjiu Lu Cc: libc-alpha@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,HK_RANDOM_ENVFROM,HK_RANDOM_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Oct 3, 2022 at 10:50 AM Noah Goldstein wrote: > > On Mon, Oct 3, 2022 at 10:35 AM Aurelien Jarno wrote: > > > > On 2022-10-03 09:19, Sunil Pandey via Libc-alpha wrote: > > > Please separate this patch into 4 separate patches. > > > > > > Patch1: sysdeps/x86_64/multiarch/strncmp.c > > > Patch2: sysdeps/x86_64/multiarch/strcmp.c > > > Patch3: sysdeps/x86_64/multiarch/ifunc-strcasecmp.h > > > Patch4: sysdeps/x86_64/multiarch/ifunc-impl-list.c > > > > > > Rest of them looks OK to me. > > > > I don't fully see the point of doing that, but i'll do it in the next > > version. > > I think to make backporting easier. Exactly. If you look closely, this patch combines 4 independent ifunc functionality in one single patch. As per latest backporting guideline, backport patches must apply cleanly without any change. Having small independent patches makes backporting a little easier. > > > > -- > > Aurelien Jarno GPG: 4096R/1DDD8C9B > > aurelien@aurel32.net http://www.aurel32.net