From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) by sourceware.org (Postfix) with ESMTPS id 31A173858C2C for ; Thu, 14 Oct 2021 16:36:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 31A173858C2C Received: by mail-qt1-x82d.google.com with SMTP id z24so6271518qtv.9 for ; Thu, 14 Oct 2021 09:36:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vd7HYutsiFOCOsTeIqlwfB3e4nQIo90np/HuTEX8TlI=; b=nJO9g/6aaC6LdfsdUnki95U/d5HmTaIsIY2byrgvZpYEQ88Dr4TYY0HrUbfjvL0ZKM nRIMT/EPPiUjVDVPrsplYzAAKtCgKpVRXvUXIxqFl7jNEamJaMAyIpPOW7ME9b1xRZwb marXdusBAhdi832wRHAPNCo/bSZNVm47Sq4uhBp2BaVwvH+fEejwI4PDVBAcTu0fCsl6 Zw6cLcCl7IV4bp+lrU2SOGZxGVIbbU2FXL0UQgLWupy8fVeKtcpO4klv6z45zuXF4/Li 8g9kRGG/eaxQvUc3zYeGTrWbd0SMUjE+SZHQtMWCqCCsXaGpb1Fey8WU6Rui/45xzE5R sP3A== X-Gm-Message-State: AOAM533Ct/DfD0h4yInrEUF+pAsKxCgmSzfKWGfMioqCC0qit/pmYsy+ rhtk5Vlq7GJ/+vj3dtGh7G464RC+j3Gl5Dp5Y9U= X-Google-Smtp-Source: ABdhPJwQgDwfVxVaeekJZTevar54484zr/Y4P7JeMbZhu71GwgQkDLg0PsevWkdhwdPn6bSA+zeixD2122b69JET4kg= X-Received: by 2002:ac8:58c6:: with SMTP id u6mr7840939qta.230.1634229396810; Thu, 14 Oct 2021 09:36:36 -0700 (PDT) MIME-Version: 1.0 References: <20211014035435.6339-1-hjl.tools@gmail.com> In-Reply-To: From: Sunil Pandey Date: Thu, 14 Oct 2021 09:36:01 -0700 Message-ID: Subject: Re: [PATCH v2] x86-64: Add test-vector-abi.h/test-vector-abi-sincos.h To: Noah Goldstein Cc: "H.J. Lu" , GNU C Library , "Pandey, Sunil K" X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, HK_RANDOM_ENVFROM, HK_RANDOM_FROM, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Oct 2021 16:36:39 -0000 On Thu, Oct 14, 2021 at 9:13 AM Noah Goldstein via Libc-alpha < libc-alpha@sourceware.org> wrote: > On Thu, Oct 14, 2021 at 8:32 AM H.J. Lu wrote: > > > > On Wed, Oct 13, 2021 at 9:23 PM Noah Goldstein > wrote: > > > > > > On Wed, Oct 13, 2021 at 11:54 PM H.J. Lu via Libc-alpha > > > wrote: > > > > > > > > Add a template for vector ABI test and use it for vector > sincos/sincosf > > > > ABI tests. > > > > --- > > > > sysdeps/x86_64/fpu/Makefile | 6 --- > > > > .../fpu/test-double-libmvec-sincos-avx.c | 1 + > > > > .../fpu/test-double-libmvec-sincos-avx2.c | 3 +- > > > > .../fpu/test-double-libmvec-sincos-avx512.c | 3 +- > > > > .../fpu/test-double-libmvec-sincos-main.c | 2 +- > > > > .../x86_64/fpu/test-double-libmvec-sincos.c | 45 > +------------------ > > > > .../fpu/test-float-libmvec-sincosf-avx.c | 3 +- > > > > .../fpu/test-float-libmvec-sincosf-avx2.c | 3 +- > > > > .../fpu/test-float-libmvec-sincosf-avx512.c | 3 +- > > > > .../fpu/test-float-libmvec-sincosf-main.c | 2 +- > > > > .../x86_64/fpu/test-float-libmvec-sincosf.c | 45 > +------------------ > > > > sysdeps/x86_64/fpu/test-vector-abi.h | 41 +++++++++++++++++ > > > > 12 files changed, 56 insertions(+), 101 deletions(-) > > > > create mode 100644 sysdeps/x86_64/fpu/test-vector-abi.h > > > > > > > > diff --git a/sysdeps/x86_64/fpu/Makefile > b/sysdeps/x86_64/fpu/Makefile > > > > index 1b4406380d..6643f77c5d 100644 > > > > --- a/sysdeps/x86_64/fpu/Makefile > > > > +++ b/sysdeps/x86_64/fpu/Makefile > > > > @@ -108,19 +108,13 @@ CFLAGS-test-double-vlen4-avx2-wrappers.c = > $(double-vlen4-arch-ext2-cflags) > > > > CFLAGS-test-float-vlen8-avx2-wrappers.c = > $(float-vlen8-arch-ext2-cflags) > > > > > > > > CFLAGS-test-double-libmvec-sincos-main.c = $(libmvec-sincos-cflags) > > > > -CFLAGS-test-double-libmvec-sincos-avx.c = -DREQUIRE_AVX > > > > CFLAGS-test-double-libmvec-sincos-avx-main.c = > $(libmvec-sincos-cflags) $(double-vlen4-arch-ext-cflags) > > > > -CFLAGS-test-double-libmvec-sincos-avx2.c = -DREQUIRE_AVX2 > > > > CFLAGS-test-double-libmvec-sincos-avx2-main.c = > $(libmvec-sincos-cflags) $(double-vlen4-arch-ext2-cflags) > > > > -CFLAGS-test-double-libmvec-sincos-avx512.c = -DREQUIRE_AVX512F > > > > CFLAGS-test-double-libmvec-sincos-avx512-main.c = > $(libmvec-sincos-cflags) $(double-vlen8-arch-ext-cflags) > > > > > > > > CFLAGS-test-float-libmvec-sincosf-main.c = $(libmvec-sincos-cflags) > > > > -CFLAGS-test-float-libmvec-sincosf-avx.c = -DREQUIRE_AVX > > > > CFLAGS-test-float-libmvec-sincosf-avx-main.c = > $(libmvec-sincos-cflags) $(float-vlen8-arch-ext-cflags) > > > > -CFLAGS-test-float-libmvec-sincosf-avx2.c = -DREQUIRE_AVX2 > > > > CFLAGS-test-float-libmvec-sincosf-avx2-main.c = > $(libmvec-sincos-cflags) $(float-vlen8-arch-ext2-cflags) > > > > -CFLAGS-test-float-libmvec-sincosf-avx512.c = -DREQUIRE_AVX512F > > > > CFLAGS-test-float-libmvec-sincosf-avx512-main.c = > $(libmvec-sincos-cflags) $(float-vlen16-arch-ext-cflags) > > > > endif > > > > endif > > > > diff --git a/sysdeps/x86_64/fpu/test-double-libmvec-sincos-avx.c > b/sysdeps/x86_64/fpu/test-double-libmvec-sincos-avx.c > > > > index 896f1bcbaf..fbc0dbe3d9 100644 > > > > --- a/sysdeps/x86_64/fpu/test-double-libmvec-sincos-avx.c > > > > +++ b/sysdeps/x86_64/fpu/test-double-libmvec-sincos-avx.c > > > > @@ -1 +1,2 @@ > > > > +#define REQUIRE_AVX > > > > #include "test-double-libmvec-sincos.c" > > > > > > Should this be: #include "test-vector-abi.h"? > > > > Yes. > > > > > If so can test-double-libmvec-sincos.c be deleted? > > > > No. We need it to build test-double-libmvec-sincos. > > > > Here is the v2 patch. The main changes are > > > > 1. Rename all test-XXX-main.c files to test-XXX.c. > > 2. Use test-libmvec*.c to run the libmvec ABI tests. > > > > OK for master? > > Should "mathvec/check-abi-libmvec'' be the only test in mathvec? > > If so then LGTM. > > > > > Thanks. > > > > -- > > H.J. > v2 patch, file name looks inconsistent. sysdeps/x86_64/fpu/test-double-libmvec-sincos-avx512f.c sysdeps/x86_64/fpu/test-float-libmvec-sincosf-avx512f.c sysdeps/x86_64/fpu/test-libmvec-avx512f.c Should these file named as sysdeps/x86_64/fpu/test-double-libmvec-sincos-avx512.c sysdeps/x86_64/fpu/test-float-libmvec-sincosf-avx512.c sysdeps/x86_64/fpu/test-libmvec-avx512.c