From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf2b.google.com (mail-qv1-xf2b.google.com [IPv6:2607:f8b0:4864:20::f2b]) by sourceware.org (Postfix) with ESMTPS id F1EE13858416 for ; Fri, 22 Oct 2021 23:12:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F1EE13858416 Received: by mail-qv1-xf2b.google.com with SMTP id b1so1473743qvk.5 for ; Fri, 22 Oct 2021 16:12:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=y7BUj4KcsKzytd7Hobo6Tci+2cVLdyBZCVa7iDzKuvA=; b=Ul41nALjwPNQr+4nhVTRovGEg2KRZ6P51gm70qYQuFARNs6ZsTbsUnIAaeicDOkO4B v/u3FUlpep3bqRiS4mr1eso9HAP0WZfRiKCjAX3ychXOZysV3tbiT7woCj9fcXyDSkLM Ls2h23f0NcFkU/biIgVOi6jPhIqqm5WbdpT6IFoHEGW2jd3wqOXpwucrTC+9Lu6tVzv6 UCm53f6P1Dkge9Dxb3VYFKdFhfzbWKDQnMNTwmQhjoVDxNzT8RSXqWs8KYjEGHt5WCue kGAI7eoHLm7JqspJT5sP7OcXN400124tYMAAafW+ILi280aGs4uMaBZ243UC7VpC2t/g 20mA== X-Gm-Message-State: AOAM532SjzEyCiUFCWNl2p9uypnwJE86c884obECcPcnuJltj09ZY997 2yAZQunEmjImN+QYLvXyqc66iB7A3mgPIWofoE5Q4DI148Q= X-Google-Smtp-Source: ABdhPJzILXk76hmEBJpxCTZl4T+AYGXF1F4fZQhhmNB/qeRvO4Ejcaak/jrLEyE9Bczh38vrXELggnZTAx5VzoUi10Q= X-Received: by 2002:a05:6214:dc6:: with SMTP id 6mr2596994qvt.60.1634944377545; Fri, 22 Oct 2021 16:12:57 -0700 (PDT) MIME-Version: 1.0 References: <20211022190416.1736398-1-skpgkp2@gmail.com> <3dc02603-3318-e0d3-8c67-8610e923e751@linaro.org> In-Reply-To: <3dc02603-3318-e0d3-8c67-8610e923e751@linaro.org> From: Sunil Pandey Date: Fri, 22 Oct 2021 16:12:21 -0700 Message-ID: Subject: Re: [PATCH] Add missing math functions to benchtests To: Adhemerval Zanella Cc: GNU C Library X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, HK_RANDOM_ENVFROM, HK_RANDOM_FROM, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2021 23:13:00 -0000 On Fri, Oct 22, 2021 at 1:39 PM Adhemerval Zanella < adhemerval.zanella@linaro.org> wrote: > > > On 22/10/2021 16:04, Sunil K Pandey via Libc-alpha wrote: > > Add acosf, acoshf, asinf, asinhf, atan2f, atanf, atanhf, cbrtf, coshf, > > erfcf, erff, expm1f, hypotf, log10f, log1pf, sinhf, tanf and tanhf > > functions to math benchtests. > > Please split one patch per function and add a rationale on how each input > were generate. Keep in mind that using pure random values might not be > meaningful (as Joseph has noted for my recent hypot/hypotf one [1]. > > [1] https://sourceware.org/pipermail/libc-alpha/2021-October/131753.html Thank you so much for your feedback. I will split the patch for each function and fix the makefile as suggested. In this patch, float input file is just a copy of the corresponding double input file. Looking for help, how to correctly generate float input files? > > diff --git a/benchtests/Makefile b/benchtests/Makefile > > index 4fcd73131a..a250a41664 100644 > > --- a/benchtests/Makefile > > +++ b/benchtests/Makefile > > @@ -28,6 +28,9 @@ bench-math := acos acosh asin asinh atan atanh cos > cosh exp exp2 log log2 \ > > exp10f ilogb ilogbf cbrt erf erfc exp10 expm1 j0 j1 lgamma > \ > > log10 log1p tgamma y0 y1 atan2 > > > > +bench-math += acosf acoshf asinf asinhf atan2f atanf atanhf cbrtf coshf > \ > > + erfcf erff expm1f hypotf log10f log1pf sinhf tanf tanhf > > + > > ifneq (,$(filter yes,$(float96-fcts))) > > bench-math += cbrtl > > endif > > For new rules I is better one input per line. In this case: > > bench-math += \ > acosf \ > acoshf \ > ... > tanhf \ > > (the last line does have a line continuation, it helps git diff). >