From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) by sourceware.org (Postfix) with ESMTPS id 0AE10385840B for ; Sat, 13 Nov 2021 06:14:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0AE10385840B Received: by mail-qk1-x72e.google.com with SMTP id t83so8891077qke.8 for ; Fri, 12 Nov 2021 22:14:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tfEDQQDKXJJ4EkJpSNFaKTWoYbx+m5BoyCroRiXuQwc=; b=TwnlmQbzIZtth+dXJhw8IvlqwWO8rW/doAKy3EYIbfQj0tfyMZxcoU9CyPhjqIafgg UQZtNfrFql2hOX+abm7MKwZVG50yN7Q0Qy+Ptd/oNMzwXG4JKNjgVzdOT1mHRK5A9q00 MGTle81ixEGBntQviguvhP88NX+dmJ/472v7P0Yq2RT/c4m7BWN399bMAbbanBQRXIvW E/e3WKLwEJjioQPhShfb2OtyrGLgm9II99A9PSk2knj4ItSDMqrSFexGDIuycEXsGzR5 tlc4R6QgqXcEa9OgN4S7gjPSpUgpNoHdg10/iKK7QI9f4aolPUA/rnggHlmgEqgVA1CA QhaA== X-Gm-Message-State: AOAM5323Wms1ELT4h6AhzEqu8Rzb1TqYcm3383SNEKDJiiIHsRkXFq/E +7Ffi4zYD6EvDsvcTOJfr7Hr8AOENOn+yD/C6UCjnVTJHdw= X-Google-Smtp-Source: ABdhPJysSJ/FlYxyWSEcWbDJJHuH1LoFzbSZGF8yf7AY3CaoKv4r4sTo1qSNyF+He9ViuWTxmKetfqJ7zxVZfEsokhA= X-Received: by 2002:a05:620a:14ab:: with SMTP id x11mr16461827qkj.84.1636784079704; Fri, 12 Nov 2021 22:14:39 -0800 (PST) MIME-Version: 1.0 References: <20211112191800.790574-1-skpgkp2@gmail.com> <20211112191800.790574-5-skpgkp2@gmail.com> In-Reply-To: From: Sunil Pandey Date: Fri, 12 Nov 2021 22:14:03 -0800 Message-ID: Subject: Re: [PATCH v2 4/6] x86-64: Add vector log/logf to libmvec microbenchmark To: Joseph Myers Cc: andrey.kolesov@intel.com, GNU C Library X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, HK_RANDOM_ENVFROM, HK_RANDOM_FROM, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Nov 2021 06:14:41 -0000 On Fri, Nov 12, 2021 at 5:44 PM Joseph Myers wrote: > On Fri, 12 Nov 2021, Sunil Pandey via Libc-alpha wrote: > > > On Fri, Nov 12, 2021 at 3:18 PM Joseph Myers > > wrote: > > > > > On Fri, 12 Nov 2021, Sunil K Pandey via Libc-alpha wrote: > > > > > > > +# Random inputs in [a=1.10,b=100.00] > > > > > > It seems odd not to have any inputs in (0, 1.10), or larger than 100 > (in > > > the absence of actual evidence that such numbers are rare as arguments > to > > > log in practice). All positive numbers are reasonable arguments to > log. > > > > > On some cpu there may be a slow path around 0 and 1, hence range > > selected from 1.10 to avoid slow path which may distort microbenchmark > > number on some cpu. There is no such issue for numbers larger than 100, > > we have to pick some number and choose 100 for microbenchmark. > > I think the point of such benchmarks should be to provide typical inputs > to the function such as might be found in ordinary programs using the > function, and provide a sensible way in which completely different > implementations of the same function can be compared. It should not be > based on the details of where slow paths in a particular implementation > are; that artificially advantages the current implementation against any > alternative implementation that might be proposed. > Hi Joseph, Can you please provide some suggestions on input range, if it looks OK or it should be changed to some specific value to make it fair for different implementations. cos/cosf: Random inputs in [a=-100.00,b=100.00] exp/expf: Random inputs in [a=-10.00,b=50.00] log/logf: Random inputs in [a=1.10,b=100.00] pow/powf: Random inputs in [a=0.01,b=100.00], [c=0.01,d=10.00] sin/sinf: Random inputs in [a=-100.00,b=100.00] Thanks, Sunil > -- > Joseph S. Myers > joseph@codesourcery.com >