From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf2c.google.com (mail-qv1-xf2c.google.com [IPv6:2607:f8b0:4864:20::f2c]) by sourceware.org (Postfix) with ESMTPS id 20A143858430 for ; Thu, 24 Feb 2022 03:33:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 20A143858430 Received: by mail-qv1-xf2c.google.com with SMTP id e22so1608247qvf.9 for ; Wed, 23 Feb 2022 19:33:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=anQ3/TzvNxcU3waJsjhUHufGaq4CYxX6d2uzWP4QEx4=; b=iLAOMa0WNrdbjXOuQZM+AB5zG5QHnSbdwQeLahn4nYUd4l0+aYaYOyIqcVHAO0b9BU KQbPaXwjR83hmMVuPv57eQ35tlSmfaImAGMichP4jHPbM5fClVmODNXMQ7O1wh2Rr8PP UgyUdNQpk8h4UV/5rKD3xlrFLc9Nx1iNUJQW1RQ5rDIoSR3J5Ag/MQfGhjQ4AgUungNo sj+WeCudLDEc+XUh0RUnV7OxK1fXhGwcE26vwLeDH2fzfFqKvQrd7hfzHaYyG6j2pSIM e9dsyE0QY7CBXzJkqYPcZ4kxgLTfXGJ9x3olGbQ7e/Y+KlPsJFDraSXBZRNhEWA53LCC PJPA== X-Gm-Message-State: AOAM5323eMHYBo02eSjZkt439Pq0D/woMJBXyf1uDZbxzO7HYmWVKx8o v/yCoHl18xXAEPVvdSN/jUuUd+mB89rccNftItY= X-Google-Smtp-Source: ABdhPJxhXeWM+H8P+XMoA8yCxcgW1zdfjWeBsm1ADzcTinhATqSbPch+0R49f8d4K7KhxLepMpUbxhLYxrQhfgFXL+g= X-Received: by 2002:ac8:5c92:0:b0:2de:4dc5:1621 with SMTP id r18-20020ac85c92000000b002de4dc51621mr654590qta.247.1645673595730; Wed, 23 Feb 2022 19:33:15 -0800 (PST) MIME-Version: 1.0 References: <20220216025723.1495555-1-skpgkp2@gmail.com> In-Reply-To: From: Sunil Pandey Date: Wed, 23 Feb 2022 19:32:39 -0800 Message-ID: Subject: Re: [PATCH] math: Add more input to atanh accuracy tests To: Paul Zimmermann Cc: GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=0.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, HK_RANDOM_ENVFROM, HK_RANDOM_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Feb 2022 03:33:20 -0000 On Fri, Feb 18, 2022 at 8:01 PM Paul Zimmermann wrote: > > Dear Sunil, > > here is what I get with glibc master (b98d0bb): > > $ LIBMVEC=512 GLIBC=glibc ./doit.libmvec atanh > LIBMVEC=512 -mavx512f > 00000000004148f0 T mpfr_atanh > 0000000000401668 t mpfr_atanh.cold > U _ZGVeN16v_atanhf@GLIBC_2.35 > Checking atanh with libmvec from glibc and rndn > Sat 19 Feb 2022 04:48:53 AM CET > MPFR library: 4.1.0 > MPFR header: 4.1.0 (based on 4.1.0) > Checking function atanhf with MPFR_RNDN > libm wrong by up to 1.45e+00 ulp(s) [1] for x=0x1.f2100ap-9 > atanh gives 0x1.f210aap-9 > mpfr_atanh gives 0x1.f210a8p-9 > Total: errors=58600734 (1.37%) errors2=0 maxerr=1.45e+00 ulp(s) > > The maximal error is still 1.45 ulps. > > Anyway, I guess the comment in auto-libm-test-in should say this is for > libmvec, and with -avx512. Comment fixed in v2. > > Paul > > > From: Sunil Pandey > > Date: Wed, 16 Feb 2022 10:40:06 -0800 > > Cc: GNU C Library > > > > Hi Paul, > > > > I got an optimization patch for function _ZGVeN16v_atanhf_skx. As a result of > > optimization, ulps for(input 0x1.f80094p-8) jumped from ~1.4 to ~2.4 and none > > of the existing glibc atanh input catches it. > > > > Currently at glibc master I am getting the following result. > > > > Test: atanh_vlen16 (0x1.f80094p-8) > > Result: 0x1.f80322p-8 > > > > I also tried input 0x1.ec2dd8p-4 but it doesn't catch the optimization accuracy > > error jump for the proposed patch. > > > > Thanks, > > Sunil > > > > > > On Tue, Feb 15, 2022 at 11:43 PM Paul Zimmermann > > wrote: > > > > > > Dear Sunil, > > > > > > > +# the next value generates larger error bounds on x86_64 (binary32) > > > > +atanh 0x1.f80094p-8 > > > > > > I only find a error of 0.598 ulp, whereas the largest error for binary32 > > > is obtained for 0x1.ec2dd8p-4 (1.73 ulp). More precisely for x=0x1.f80094p-8 > > > glibc 2.35 returns 0x1.f8031ep-8 (x86_64, skylake). Do you get a different value? > > > Maybe you used different CFLAGS than the default ones? > > > > > > Best regards, > > > Paul > >