From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb34.google.com (mail-yb1-xb34.google.com [IPv6:2607:f8b0:4864:20::b34]) by sourceware.org (Postfix) with ESMTPS id 96C543858C20 for ; Thu, 14 Jul 2022 02:52:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 96C543858C20 Received: by mail-yb1-xb34.google.com with SMTP id p129so1011903yba.7 for ; Wed, 13 Jul 2022 19:52:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YWf0eqiGM+59GXFcHXIC45jbOXRcvk6CLYZlSTAOofQ=; b=MnaXrUzzO4OHey9rbLjehZjoVrw9upXhOsYn5g/jnx3+qvyKJoy+x/mXJt8YT/oKP6 Y98Pjc4+q5MgkJ/X4pmRQiQJMSindRacFqFYw2bgzJ1m8RkwWw9t/k3bWphv+NfQ/iYz PytYPw20LqhPFzZ2tRUqb+A9g5cg1C8+KeL2n3Un3bWrflbOXlwIaI74YdlNU3UV9cGG VgKwintB0IB+85hF7nOPquP3+mP9kcqUzLhAXSWly1No6RVVnTnWubBTqnkGyRtbCREH tnhkj/jlzYTzf2uU2x79IShFn+Z0T/Uq2X1kLdJuhsAkU1EtXn+PSdxLv3gD/N9EET9p WOJQ== X-Gm-Message-State: AJIora9hHpV6Nv3uFU1RS/4pKJXLsX30SWWTodR4hgr7pp/yQCgijXQh XvUU+ylEI5nIssobySJB9svNuOI9tXHmZKNvXUu2CXXd8Ag= X-Google-Smtp-Source: AGRyM1t57W3kDjxBuFVeJfJGiBoUJEPxAcbS0ARZN8RruNTyHF/E2V9YtdrbXZVWguiJNb3btbAwVoRlpLLCqauRp98= X-Received: by 2002:a25:1545:0:b0:668:ea04:1bf1 with SMTP id 66-20020a251545000000b00668ea041bf1mr6768793ybv.164.1657767125110; Wed, 13 Jul 2022 19:52:05 -0700 (PDT) MIME-Version: 1.0 References: <20220609041653.2515397-1-goldstein.w.n@gmail.com> In-Reply-To: From: Sunil Pandey Date: Wed, 13 Jul 2022 19:51:29 -0700 Message-ID: Subject: Re: [PATCH v1 1/3] x86: Align varshift table to 32-bytes To: "H.J. Lu" Cc: Noah Goldstein , GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, HK_RANDOM_ENVFROM, HK_RANDOM_FROM, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jul 2022 02:52:07 -0000 On Thu, Jun 9, 2022 at 8:15 AM H.J. Lu via Libc-alpha wrote: > > On Wed, Jun 8, 2022 at 9:16 PM Noah Goldstein wrote: > > > > This ensures the load will never split a cache line. > > --- > > sysdeps/x86_64/multiarch/varshift.c | 5 +++-- > > sysdeps/x86_64/multiarch/varshift.h | 3 ++- > > 2 files changed, 5 insertions(+), 3 deletions(-) > > > > diff --git a/sysdeps/x86_64/multiarch/varshift.c b/sysdeps/x86_64/multiarch/varshift.c > > index c8210f0546..d27767520a 100644 > > --- a/sysdeps/x86_64/multiarch/varshift.c > > +++ b/sysdeps/x86_64/multiarch/varshift.c > > @@ -16,9 +16,10 @@ > > License along with the GNU C Library; if not, see > > . */ > > > > -#include "varshift.h" > > +#include > > > > -const int8_t ___m128i_shift_right[31] attribute_hidden = > > +const int8_t ___m128i_shift_right[31] attribute_hidden > > + __attribute__((aligned(32))) = > > { > > 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, > > -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1 > > diff --git a/sysdeps/x86_64/multiarch/varshift.h b/sysdeps/x86_64/multiarch/varshift.h > > index af30694488..ffd12d79e4 100644 > > --- a/sysdeps/x86_64/multiarch/varshift.h > > +++ b/sysdeps/x86_64/multiarch/varshift.h > > @@ -19,7 +19,8 @@ > > #include > > #include > > > > -extern const int8_t ___m128i_shift_right[31] attribute_hidden; > > +extern const int8_t ___m128i_shift_right[31] attribute_hidden > > + __attribute__ ((aligned (32))); > > > > static __inline__ __m128i > > __m128i_shift_right (__m128i value, unsigned long int offset) > > -- > > 2.34.1 > > > > LGTM. > > Thanks. > > -- > H.J. I would like to backport this patch to release branches. Any comments or objections? --Sunil