From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb2c.google.com (mail-yb1-xb2c.google.com [IPv6:2607:f8b0:4864:20::b2c]) by sourceware.org (Postfix) with ESMTPS id 758383856DFB for ; Fri, 29 Jul 2022 18:02:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 758383856DFB Received: by mail-yb1-xb2c.google.com with SMTP id e127so8734548yba.12 for ; Fri, 29 Jul 2022 11:02:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AO4mjXzSxr9wASR21zdEeqKr6qDZNayvc6acBuDaJ34=; b=RgVv/TvhHYQBaed3/M9QHGLHy5a51sDa/x3cB87+H+Xm6vRCzFfPSfcjEKM8D0VGZZ dsLDi3lKM7mb4YqrwiwHdoW+OMyZtkeLFyHsUjJ/ImFY4x9OpTIRow6Bdy8HrJQoyBKr 17L085GvOyea+1MxP1lQBmUVZ1X6vrgyGjF0ocyJXT+B0vFTIjHErx0vx1+64eLJXtKY rSRj4346IbeZXVsUFbHQwpyzvFM7ptq4os9pyvlDnjfGmBCJirKpvzhi7QAhmu6qFcWf zi5bnVZEAJ1Fmic1bjGsYUX91VGloyh4bf4WPHHiBVkMq+brB/SKj3OXf6X/i7KuA9v6 kxdA== X-Gm-Message-State: ACgBeo2q+b2F7rdh8JdpDP0P5VoCDrcj4lDl916SBpNeZPec7bG2PwG/ a3PZ4hYsMHGMzuFMkJ9XBH26f8MZc3Ku/PzdTsuIn7Sz X-Google-Smtp-Source: AA6agR5/WpsBEYNQWaLS5abWo0h0bkBone/1ZYONXhbFwHfg3I7+JCFFmUTQvs033s/uSfVKuvpf6+Gx5vl1AAUbyGQ= X-Received: by 2002:a5b:20b:0:b0:65c:a0cf:812b with SMTP id z11-20020a5b020b000000b0065ca0cf812bmr3365789ybl.48.1659117756870; Fri, 29 Jul 2022 11:02:36 -0700 (PDT) MIME-Version: 1.0 References: <20220729175056.268461-1-hjl.tools@gmail.com> In-Reply-To: <20220729175056.268461-1-hjl.tools@gmail.com> From: Sunil Pandey Date: Fri, 29 Jul 2022 11:02:00 -0700 Message-ID: Subject: Re: [PATCH] wcsmbs: Add missing test-c8rtomb/test-mbrtoc8 dependency To: "H.J. Lu" Cc: GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, HK_RANDOM_ENVFROM, HK_RANDOM_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jul 2022 18:02:38 -0000 On Fri, Jul 29, 2022 at 10:51 AM H.J. Lu via Libc-alpha wrote: > > Make test-c8rtomb.out and test-mbrtoc8.out depend on $(gen-locales) for > > xsetlocale (LC_ALL, "de_DE.UTF-8"); > xsetlocale (LC_ALL, "zh_HK.BIG5-HKSCS"); > --- > wcsmbs/Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/wcsmbs/Makefile b/wcsmbs/Makefile > index e6b9e8743a..3d19d5556f 100644 > --- a/wcsmbs/Makefile > +++ b/wcsmbs/Makefile > @@ -73,6 +73,8 @@ $(objpfx)tst-wcstol-locale.out: $(gen-locales) > $(objpfx)tst-wcstod-nan-locale.out: $(gen-locales) > $(objpfx)tst-c16-surrogate.out: $(gen-locales) > $(objpfx)tst-c32-state.out: $(gen-locales) > +$(objpfx)test-c8rtomb.out: $(gen-locales) > +$(objpfx)test-mbrtoc8.out: $(gen-locales) > endif > > $(objpfx)tst-wcstod-round: $(libm) > -- > 2.37.1 > Fixes the issue. LGTM Reviewed-by: Sunil K Pandey