From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) by sourceware.org (Postfix) with ESMTPS id 367583858D28 for ; Tue, 23 Nov 2021 18:31:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 367583858D28 Received: by mail-qt1-x831.google.com with SMTP id q14so140188qtx.10 for ; Tue, 23 Nov 2021 10:31:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6V8W9OItuCPQSXWJCjg+4yues0uN+veOfjXo8RggWac=; b=2+A4CRQ1fQyVRvYK8GJ0w3jlnUMBlJZcIvirIUn9Ks0PQtC1Gub0/i9iBFk1BJvpxW GQEumK3/IgnL4wgaDg8e/EQvF8YahM+HNx22L5evUm0aNT6GD6S0l3XulAQNHIp/6s8j 9ZLjfdlmVj+A4CrUqSPkuRg3/zU15CGbSymMFnjv7u0TqqA/+P/1ekTU0iaqW/2DVsHy toqL45ZtGSfeQxLC7MjrtBkwFIr5CDn5gZML2Coq2Nr9mb6audiNVwWopfxG/+AIMacJ Rb0aI3VRXyMOkIa9jOh7c9ezm3jFTalQG7bTA2HoydIJcgQme2itQtZ7q5i4vD8pa58V nxHQ== X-Gm-Message-State: AOAM532TACKMACyY32TbOYynjbwAzMVgxkLfyrmkeWzrHQrIt0ts3P+S JslNvhGguVBWuRpNW23wpNbs7IV2AycolQ+zJrtPigyFq/E= X-Google-Smtp-Source: ABdhPJw9DbjbC8SO9wRHfNb5WHF0EyHhXb6juqbXec2Bwp6nHMCN/s8TZ+VP6ljTAtKuPaA8gtlcXljHj+YtxE3LNBo= X-Received: by 2002:ac8:7d45:: with SMTP id h5mr8590410qtb.256.1637692279849; Tue, 23 Nov 2021 10:31:19 -0800 (PST) MIME-Version: 1.0 References: <20211112191800.790574-1-skpgkp2@gmail.com> <20211112191800.790574-5-skpgkp2@gmail.com> In-Reply-To: From: Sunil Pandey Date: Tue, 23 Nov 2021 10:30:44 -0800 Message-ID: Subject: Re: [PATCH v2 4/6] x86-64: Add vector log/logf to libmvec microbenchmark To: Joseph Myers Cc: andrey.kolesov@intel.com, GNU C Library X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, HK_RANDOM_ENVFROM, HK_RANDOM_FROM, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Nov 2021 18:31:21 -0000 On Mon, Nov 15, 2021 at 4:12 PM Joseph Myers wrote: > On Fri, 12 Nov 2021, Sunil Pandey via Libc-alpha wrote: > > > Can you please provide some suggestions on input range, if it looks OK or > > it should be changed to some specific value to make it fair for different > > implementations. > > > > cos/cosf: Random inputs in [a=-100.00,b=100.00] > > sin/sinf: Random inputs in [a=-100.00,b=100.00] > > My guess is that most inputs are actually in say [-10, 10], but [-100, > 100] seems reasonable as limits on what values are benchmarked at all. > > > exp/expf: Random inputs in [a=-10.00,b=50.00] > > I suggest a roughly symmetric range (lower limit being a bit above what > would cause a subnormal result, upper limit being a bit below what would > overflow - note that means different limits for exp and expf). > > > log/logf: Random inputs in [a=1.10,b=100.00] > > I suggest a lower limit of 0 and an upper limit of FLT_MAX / DBL_MAX (note > this means different limits for log and logf), but with a substantial > proportion of inputs being closer to 1 (say in the range [0.01, 100]). > > > pow/powf: Random inputs in [a=0.01,b=100.00], [c=0.01,d=10.00] > > I think negative exponents should be included, about as many as positive > exponents (similar range, so that results are neither subnormal nor > overflowing). > Hi Joseph, I submitted patch v4 to address the input data set issue for vector cos, cosf, sin, sinf, exp, expf, log, logf, pow and powf. Let me know if it looks ok to you. --Sunil > -- > Joseph S. Myers > joseph@codesourcery.com >