From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb2a.google.com (mail-yb1-xb2a.google.com [IPv6:2607:f8b0:4864:20::b2a]) by sourceware.org (Postfix) with ESMTPS id D98833857C7D for ; Thu, 14 Jul 2022 02:59:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D98833857C7D Received: by mail-yb1-xb2a.google.com with SMTP id 64so997556ybt.12 for ; Wed, 13 Jul 2022 19:59:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=r7LttbcQLvKv26gI09VNHZ4vD1zv9+PkriByZJiUXd0=; b=CtLQU61ZkHFiXCwpv+KztOWLLrx77P5waFnCt6YS0BbxtEEEk2Alqk3TO2zGTGGagC 4Gizm1KARqqtN4Lfd/aOPKsqhpE+Bf8epGpDlEHb74s83VTy60Mwt45BXmrHsM9nraMe 5cnDDttOWYjmAECvAE6b8v71gXOk/3HtjLv9S2N3kxHDuhka035ZwCMCGNfJp5HXGnTI QDkEmUnPxXX2E3+tjCpswmkGCNCukktuZ581o4LwOqls2AFN5kqGnZQWVNVz9eo0GqBQ /1jyzpClG748BJHUdcFulUhoUY2I9Ekq4386NK+axVtXQO6lIXhE5OF76KW9JadmJ+QY 5GbA== X-Gm-Message-State: AJIora9euaCfgewSUo1vnmpjaCSRjOXCgzqBevw6oZtnWWbWoN4oYMDc aaSu7kKWYFk9cGUKUWFw5dPNejHoXq2T1OOsfcGUmWWpnRQ= X-Google-Smtp-Source: AGRyM1skzFXmGmmXIrHBxC6W+fFjCUBMCJ3NN3so1JI8qABlM9V3B02Mna6LF41KbK+itkaSTHZUrq8Ny2wJ5gENpwc= X-Received: by 2002:a25:8709:0:b0:66e:d9e0:48d3 with SMTP id a9-20020a258709000000b0066ed9e048d3mr6679059ybl.650.1657767588373; Wed, 13 Jul 2022 19:59:48 -0700 (PDT) MIME-Version: 1.0 References: <20220624164216.2129400-1-goldstein.w.n@gmail.com> In-Reply-To: From: Sunil Pandey Date: Wed, 13 Jul 2022 19:59:12 -0700 Message-ID: Subject: Re: [PATCH v2] x86: Align entry for memrchr to 64-bytes. To: "H.J. Lu" Cc: Noah Goldstein , GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, HK_RANDOM_ENVFROM, HK_RANDOM_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jul 2022 02:59:50 -0000 On Fri, Jun 24, 2022 at 10:16 AM H.J. Lu via Libc-alpha wrote: > > On Fri, Jun 24, 2022 at 9:42 AM Noah Goldstein wrote: > > > > The function was tuned around 64-byte entry alignment and performs > > better for all sizes with it. > > > > As well different code boths where explicitly written to touch the > > minimum number of cache line i.e sizes <= 32 touch only the entry > > cache line. > > --- > > sysdeps/x86_64/multiarch/memrchr-avx2.S | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/sysdeps/x86_64/multiarch/memrchr-avx2.S b/sysdeps/x86_64/multiarch/memrchr-avx2.S > > index 9c83c76d3c..f300d7daf4 100644 > > --- a/sysdeps/x86_64/multiarch/memrchr-avx2.S > > +++ b/sysdeps/x86_64/multiarch/memrchr-avx2.S > > @@ -35,7 +35,7 @@ > > # define VEC_SIZE 32 > > # define PAGE_SIZE 4096 > > .section SECTION(.text), "ax", @progbits > > -ENTRY(MEMRCHR) > > +ENTRY_P2ALIGN(MEMRCHR, 6) > > # ifdef __ILP32__ > > /* Clear upper bits. */ > > and %RDX_LP, %RDX_LP > > -- > > 2.34.1 > > > > LGTM. > > Thanks. > > -- > H.J. I would like to backport this patch to release branches. Any comments or objections? --Sunil