From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x112a.google.com (mail-yw1-x112a.google.com [IPv6:2607:f8b0:4864:20::112a]) by sourceware.org (Postfix) with ESMTPS id E32B33857BB8 for ; Thu, 14 Jul 2022 03:08:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E32B33857BB8 Received: by mail-yw1-x112a.google.com with SMTP id 00721157ae682-31bf3656517so4255847b3.12 for ; Wed, 13 Jul 2022 20:08:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eyONbltfnbmKCischokCUVUD6pMuDL/x55Y3qsxr2K8=; b=PifTMGEGELX0mcJhIhuVh8GkyBtZ1olfIGmNMWubJlLRmFa6tenSJzLLng3xGLCEfL U60+QEsgK9ZAu8LDjtIGVV+SbG4fDOaWelHXXVAw5q35Pn9kOi9nG4EqAFfHQQX70zf2 RshFhJYbGRbTouNmXFOUnv8+YojaMkY1k6AfWbG0a+RPAF6/m6qphgJ/tKeDcOtnoL78 GOrdecnLJ+zhilVBAwlLDQDCqPIIzASPfmzuokasAhW4N+Tbak4h5JsBk/p7i7IYaPqX fEACFZTHe7dUxPIG8+ZjroC9BHtpCY+JiJ30TJ+RfZygDmfdM/QPMeXJCwcPsHepH028 BzKw== X-Gm-Message-State: AJIora+i2bUrGvvnTrPYntHlbxqqMZAz0LBSQyLbJygXgLrI8eAsXvE2 02RpXmP3Wzzkot9PaGXnvsWtvd1YjIIQqKJmwmqSDKgDNQk= X-Google-Smtp-Source: AGRyM1udQQ0OfH3uKUy9fPoP4/9lX6AdquHSw/aMbeLuB5tP+nNI1J/Na/J38Tt+QeiN0Vg6fKXA6tB2MpZZUrSoDEw= X-Received: by 2002:a81:cd6:0:b0:31d:72e3:8b81 with SMTP id 205-20020a810cd6000000b0031d72e38b81mr7511894ywm.301.1657768122432; Wed, 13 Jul 2022 20:08:42 -0700 (PDT) MIME-Version: 1.0 References: <20220630015618.3586787-1-goldstein.w.n@gmail.com> <20220630015618.3586787-3-goldstein.w.n@gmail.com> In-Reply-To: From: Sunil Pandey Date: Wed, 13 Jul 2022 20:08:06 -0700 Message-ID: Subject: Re: [PATCH v1] x86: Add missing IS_IN (libc) check to strncmp-sse4_2.S To: "H.J. Lu" Cc: Noah Goldstein , GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, HK_RANDOM_ENVFROM, HK_RANDOM_FROM, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jul 2022 03:08:44 -0000 On Wed, Jun 29, 2022 at 7:04 PM H.J. Lu via Libc-alpha wrote: > > On Wed, Jun 29, 2022 at 6:56 PM Noah Goldstein wrote: > > > > Was missing to for the multiarch build rtld-strncmp-sse4_2.os was > > being built and exporting symbols: > > > > build/glibc/string/rtld-strncmp-sse4_2.os: > > 0000000000000000 T __strncmp_sse42 > > > > Introduced in: > > > > commit 11ffcacb64a939c10cfc713746b8ec88837f5c4a > > Author: H.J. Lu > > Date: Wed Jun 21 12:10:50 2017 -0700 > > > > x86-64: Implement strcmp family IFUNC selectors in C > > --- > > sysdeps/x86_64/multiarch/strncmp-sse4_2.S | 8 +++++--- > > 1 file changed, 5 insertions(+), 3 deletions(-) > > > > diff --git a/sysdeps/x86_64/multiarch/strncmp-sse4_2.S b/sysdeps/x86_64/multiarch/strncmp-sse4_2.S > > index 9773e5fc09..310a6dbe77 100644 > > --- a/sysdeps/x86_64/multiarch/strncmp-sse4_2.S > > +++ b/sysdeps/x86_64/multiarch/strncmp-sse4_2.S > > @@ -16,6 +16,8 @@ > > License along with the GNU C Library; if not, see > > . */ > > > > -#define STRCMP_SSE42 __strncmp_sse42 > > -#define USE_AS_STRNCMP > > -#include "strcmp-sse42.S" > > +#if IS_IN (libc) > > +# define STRCMP_SSE42 __strncmp_sse42 > > +# define USE_AS_STRNCMP > > +# include "strcmp-sse42.S" > > +#endif > > -- > > 2.34.1 > > > > LGTM. > > Thanks. > > -- > H.J. I would like to backport this patch to release branches. Any comments or objections? --Sunil