From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by sourceware.org (Postfix) with ESMTPS id 12D18385841C for ; Mon, 8 Apr 2024 16:40:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 12D18385841C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 12D18385841C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::333 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712594421; cv=none; b=KpT67xrow9WCmWe6JQVU3kDS9/3kHfAm0Zd357+4LULNn78u9nBOsuRgqzGODoBNMaea7QJZ2+4ccaifCx9Ro6p8ZucdbK0UEhCe8cTyV/MXa6mwPmxO9+pDOxLUkvAFUtH+p6bzn59RkUFrMB7JrjWQQlnEOIzQVGDBf/HYFc0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712594421; c=relaxed/simple; bh=mQpj6BDdLFNg9Hi8T5h02x/Qy6v3fP+n1XVWIOjt5FQ=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=w3r8Bgb32m74VN33P3saaFU2AU8dDDgKFLwcd88Ev8gDyuO6khAhStmu58225xgzfQlz625yHWJRGKbDYEaKHTrafcDXShpdT1VZOND3RNpIvd1ucDLAq9G/YECRLCtc4QHlceGPZ/v86Kolq0/DMUPww6X7MwnKGfHnLBHWlw4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-4156c4fe401so30378115e9.1 for ; Mon, 08 Apr 2024 09:40:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712594419; x=1713199219; darn=sourceware.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=SaM9Y1/y03yYyGhRe9/r4MO99sLlo3b8gwXzt23P6kc=; b=O8QqyWgrWFd0ayFtGelBS5Ji5VB9fff0dlz6Y8X4qzRnv09jDrDsDzSC8Wn5Xz7ZVj foKZQsV8RvRMaC/UxY+YIRrCoGnl0lhWTAZrg0qImahJxIoAV1cIO5ZIJScL5wa0Hfw7 uJDawtPnyRFOYtB6EABjBXu8p9PY8vOGXui+o0kNkir02XW+aZb83QTbu4arlJ1McZnG S0w+meKiZh0Wj3FdbbF6L0cTDLSjm+ukQUD+rsfA5qltF/UlrByLSP72PlJuzXhpHhTU IKBTJlyPVPmDPy/6qBWJwy6VTeo0yCxlJ3tI8tO+ECmhhD2EL3LNnzPtTXNLhy0Rpbyu GG0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712594419; x=1713199219; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SaM9Y1/y03yYyGhRe9/r4MO99sLlo3b8gwXzt23P6kc=; b=ad2qdmZ8OcZt89iuq9lBK5bwvahBtbFatD0Bi22F51ZIXj4ptM1WVW2Md7HKKSm/tR Cn9Y/J+gdybbkW0szC9BOiOl/h8TVpwe3pe3CrX0wy/z9JD1yqK9mDIeARYbmh8fjrQ3 LyKU5RFwMYMf3XyMmtBVRGx0zxdU2sdA4b4BMfpv4/4LoKxv1iKWdzj7XgMfbpivnJbR 4YhKWmqTks5vW6hnAwzN0JAv92AsoYsqidMzQELDI1pl3Xhjxpi53a+gWuncPU0cvbL0 voPJFBTrlj9Q34qMShM+LJr7Ob16QMESh0FjpTXYPptJRNb/UhyEI47brdFzaeVF8ZZI J+Rg== X-Gm-Message-State: AOJu0YwjOiH9UijEkt1MxgS6/36HNEzChJ2753oR0KBpgd5O1wV7H9VN UiwmXUwKInhLT3bgF1Rv+7/LcDc9gqSCo4zOvlb8/FtJ+1PowLcEuu0RH6c2l0YH6BPDg6lXP/B V+p0NM6Cz+SoqIh6/9PIdvjV1u80= X-Google-Smtp-Source: AGHT+IE1L/5aI36oSJpcsPjj+ZJtbshI3bOI17to1q9StnnL5b0YY8hwx/ZweDAmv1W/bpvc0AyJTA+B+XkZD/VwYtA= X-Received: by 2002:a05:600c:5249:b0:415:52f3:e9f7 with SMTP id fc9-20020a05600c524900b0041552f3e9f7mr7775607wmb.21.1712594418678; Mon, 08 Apr 2024 09:40:18 -0700 (PDT) MIME-Version: 1.0 References: <20240408160609.1264205-1-hjl.tools@gmail.com> In-Reply-To: <20240408160609.1264205-1-hjl.tools@gmail.com> From: Sunil Pandey Date: Mon, 8 Apr 2024 09:39:42 -0700 Message-ID: Subject: Re: [PATCH] elf: Check objname before calling fatal_error To: "H.J. Lu" Cc: libc-alpha@sourceware.org Content-Type: multipart/alternative; boundary="000000000000f8417506159875e9" X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,GIT_PATCH_0,HK_RANDOM_ENVFROM,HK_RANDOM_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000f8417506159875e9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Apr 8, 2024 at 9:06=E2=80=AFAM H.J. Lu wrote: > _dl_signal_error may be called with objname =3D=3D NULL. _dl_exception_c= reate > checks objname =3D=3D NULL. But fatal_error doesn't. Check objname befo= re > calling fatal_error. This fixes BZ #31596. > --- > elf/dl-catch.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/elf/dl-catch.c b/elf/dl-catch.c > index 2109516dba..8ef7a4c706 100644 > --- a/elf/dl-catch.c > +++ b/elf/dl-catch.c > @@ -126,7 +126,11 @@ _dl_signal_error (int errcode, const char *objname, > const char *occasion, > __longjmp (lcatch->env[0].__jmpbuf, 1); > } > else > - fatal_error (errcode, objname, occasion, errstring); > + { > + if (objname =3D=3D NULL) > + objname =3D ""; > + fatal_error (errcode, objname, occasion, errstring); > + } > } > rtld_hidden_def (_dl_signal_error) > > -- > 2.44.0 > > LGTM Reviewed-by: Sunil K Pandey -Sunil --000000000000f8417506159875e9--