From: Sunil Pandey <skpgkp2@gmail.com>
To: "H.J. Lu" <hjl.tools@gmail.com>,
Libc-stable Mailing List <libc-stable@sourceware.org>
Cc: Joseph Myers <joseph@codesourcery.com>,
GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH v4 3/5] x86: Optimize strcmp-avx2.S
Date: Tue, 3 May 2022 22:40:13 -0700 [thread overview]
Message-ID: <CAMAf5_erMMJ0A64UWhde881xktcCMJzKK2VPqumSKQXcJsqzDg@mail.gmail.com> (raw)
In-Reply-To: <CAMe9rOq3UdBSO8_YKcwKTRVAPTdM8odDYN1iyRqCX_=YF1Nz7A@mail.gmail.com>
On Fri, Feb 4, 2022 at 11:14 AM H.J. Lu via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> On Fri, Feb 4, 2022 at 10:57 AM Joseph Myers <joseph@codesourcery.com> wrote:
> >
> > I've seeing a build failure for x32 that looks likely to be caused by this
> > patch.
> >
> > ../sysdeps/x86_64/multiarch/strcmp-avx2.S: Assembler messages:
> > ../sysdeps/x86_64/multiarch/strcmp-avx2.S:109: Error: unsupported instruction `mov'
> > /scratch/jmyers/glibc-bot/build/glibcs/x86_64-linux-gnu-x32/glibc/sysd-rules:847: recipe for target '/scratch/jmyers/glibc-bot/build/glibcs/x86_64-linux-gnu-x32/glibc/string/strncmp-avx2.o' failed
> > make[3]: *** [/scratch/jmyers/glibc-bot/build/glibcs/x86_64-linux-gnu-x32/glibc/string/strncmp-avx2.o] Error 1
> >
>
> Fixed by:
>
> commit 0e0199a9e02ebe42e2b36958964d63f03573c382
> Author: H.J. Lu <hjl.tools@gmail.com>
> Date: Fri Feb 4 11:11:08 2022 -0800
>
> x86-64: Fix strcmp-evex.S
>
> Change "movl %edx, %rdx" to "movl %edx, %edx" in:
>
> commit 8418eb3ff4b781d31c4ed5dc6c0bd7356bc45db9
> Author: Noah Goldstein <goldstein.w.n@gmail.com>
> Date: Mon Jan 10 15:35:39 2022 -0600
>
> x86: Optimize strcmp-evex.S
>
> commit c15efd011cea3d8f0494269eb539583215a1feed
> Author: H.J. Lu <hjl.tools@gmail.com>
> Date: Fri Feb 4 11:09:10 2022 -0800
>
> x86-64: Fix strcmp-avx2.S
>
> Change "movl %edx, %rdx" to "movl %edx, %edx" in:
>
> commit b77b06e0e296f1a2276c27a67e1d44f2cfa38d45
> Author: Noah Goldstein <goldstein.w.n@gmail.com>
> Date: Mon Jan 10 15:35:38 2022 -0600
>
> x86: Optimize strcmp-avx2.S
>
> --
> H.J.
I would like to backport this patch to release branches.
Any comments or objections?
--Sunil
next prev parent reply other threads:[~2022-05-04 5:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-03 21:42 [PATCH v4 1/5] string/test-str*cmp: remove stupid_[strcmp, strncmp, wcscmp, wcsncmp] Noah Goldstein
2022-02-03 21:42 ` [PATCH v4 2/5] string: Improve coverage in test-strcmp.c and test-strncmp.c Noah Goldstein
2022-02-03 22:28 ` H.J. Lu
2022-02-07 13:59 ` Matheus Castanho
2022-02-07 19:03 ` Noah Goldstein
2022-02-07 20:17 ` Noah Goldstein
2022-02-03 21:42 ` [PATCH v4 3/5] x86: Optimize strcmp-avx2.S Noah Goldstein
2022-02-03 22:29 ` H.J. Lu
2022-02-04 18:57 ` Joseph Myers
2022-02-04 19:13 ` H.J. Lu
2022-05-04 5:40 ` Sunil Pandey [this message]
2022-02-03 21:42 ` [PATCH v4 4/5] x86: Optimize strcmp-evex.S Noah Goldstein
2022-02-03 22:30 ` H.J. Lu
2022-05-04 5:38 ` Sunil Pandey
2022-02-03 21:42 ` [PATCH v4 5/5] benchtests: Add more coverage for strcmp and strncmp benchmarks Noah Goldstein
2022-02-03 22:30 ` H.J. Lu
2022-02-03 22:28 ` [PATCH v4 1/5] string/test-str*cmp: remove stupid_[strcmp, strncmp, wcscmp, wcsncmp] H.J. Lu
2022-02-03 23:30 ` Noah Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMAf5_erMMJ0A64UWhde881xktcCMJzKK2VPqumSKQXcJsqzDg@mail.gmail.com \
--to=skpgkp2@gmail.com \
--cc=hjl.tools@gmail.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=libc-stable@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).