From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) by sourceware.org (Postfix) with ESMTPS id 422393858C2C; Sat, 23 Apr 2022 01:14:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 422393858C2C Received: by mail-qk1-x732.google.com with SMTP id q75so7021009qke.6; Fri, 22 Apr 2022 18:14:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RzSjj0WLlpCyeD55fTCpdVh900jFKo0xwYcAzTwnIa4=; b=4y3RQOwKNpsQRQ7WyLzlmq7hIxiX2KIQO4ZB7NeQ+YeCtsbSyVn8fGspyETE4aEHsF hYQG7Hdj1Clxfo5/DOPd2gGNebdtuVeC1IvPqDDZbFLTq33SINbMPAygy3oN0cxffaN8 3KXOhRtSU4/2IzFGgvlOffKOs1Fe1k9uCou5ji3EDdcQWp+wrjwcY84rtjTV8I+ipEQT YgUEcY8tBJPN6v/yR0/XtI2v9flyqQuQ3+tv4wrcDsEUTbNEBsKBfuxQWu6OqLTgI0XR roZbu/dgMik9hNWUS9qjoaZlzXmtxU8XqYabY9TOqrNz09SsbgfNPJhRPEsrjri7Pd3P 49+w== X-Gm-Message-State: AOAM531W9kday0z7yd0yKHOia17cdEhE/XqxDv30rTSu/Z5gSZc3yrbd ZBE/rBVt47jOUCIxA19LrTTLZ3qmHErA7hZig8c= X-Google-Smtp-Source: ABdhPJza7Z1neu7Pqr71mkyjTHCwT/LwcSJHtO5zoF6D+5gU6R6wpLT/pyq22UiTYmSJLiTbSdOD2VrpotgQVHV3bCA= X-Received: by 2002:a05:620a:1a9a:b0:69c:4a99:ea50 with SMTP id bl26-20020a05620a1a9a00b0069c4a99ea50mr4383087qkb.632.1650676440729; Fri, 22 Apr 2022 18:14:00 -0700 (PDT) MIME-Version: 1.0 References: <20210926205306.900081-1-goldstein.w.n@gmail.com> <20210926205306.900081-2-goldstein.w.n@gmail.com> In-Reply-To: From: Sunil Pandey Date: Fri, 22 Apr 2022 18:13:24 -0700 Message-ID: Subject: Re: [PATCH v1 2/3] x86: Modify ENTRY in sysdep.h so that p2align can be specified To: Noah Goldstein , libc-stable@sourceware.org Cc: "H.J. Lu" , GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, HK_RANDOM_ENVFROM, HK_RANDOM_FROM, KAM_STOCKGEN, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Apr 2022 01:14:02 -0000 On Fri, Oct 8, 2021 at 10:20 AM Noah Goldstein via Libc-alpha wrote: > > On Fri, Oct 8, 2021 at 9:27 AM H.J. Lu wrote: > > > On Sun, Sep 26, 2021 at 1:53 PM Noah Goldstein > > wrote: > > > > > > No bug. > > > > > > This change adds a new macro ENTRY_P2ALIGN which takes a second > > > argument, log2 of the desired function alignment. > > > > > > The old ENTRY(name) macro is just ENTRY_P2ALIGN(name, 4) so this > > > doesn't affect any existing functionality. > > > > > > Signed-off-by: Noah Goldstein > > > --- > > > Note this is a duplicate of: > > > [v2,1/2] x86: Modify ENTRY in sysdep.h so that p2align can be specified > > > > > https://patchwork.sourceware.org/project/glibc/patch/20210922051657.1655745-1-goldstein.w.n@gmail.com/ > > > > > > sysdeps/x86/sysdep.h | 7 +++++-- > > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > > > diff --git a/sysdeps/x86/sysdep.h b/sysdeps/x86/sysdep.h > > > index cac1d762fb..937180c1bd 100644 > > > --- a/sysdeps/x86/sysdep.h > > > +++ b/sysdeps/x86/sysdep.h > > > @@ -78,15 +78,18 @@ enum cf_protection_level > > > #define ASM_SIZE_DIRECTIVE(name) .size name,.-name; > > > > > > /* Define an entry point visible from C. */ > > > -#define ENTRY(name) > > \ > > > +#define ENTRY_P2ALIGN(name, alignment) > > \ > > > .globl C_SYMBOL_NAME(name); > > \ > > > .type C_SYMBOL_NAME(name),@function; > > \ > > > - .align ALIGNARG(4); > > \ > > > + .align ALIGNARG(alignment); > > \ > > > C_LABEL(name) > > \ > > > cfi_startproc; > > \ > > > _CET_ENDBR; > > \ > > > CALL_MCOUNT > > > > > > +/* Common entry 16 byte aligns. */ > > > +#define ENTRY(name) ENTRY_P2ALIGN (name, 4) > > > + > > > #undef END > > > #define END(name) > > \ > > > cfi_endproc; > > \ > > > -- > > > 2.25.1 > > > > > > > LGTM. > > > > Reviewed-by: H.J. Lu > > > > Thanks. > > > > Thanks. Pushed. > > > > > > -- > > H.J. > > I would like to backport this patch to release branches. Any comments or objections? --Sunil