From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x112f.google.com (mail-yw1-x112f.google.com [IPv6:2607:f8b0:4864:20::112f]) by sourceware.org (Postfix) with ESMTPS id 17C8F3857C7D for ; Thu, 14 Jul 2022 03:02:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 17C8F3857C7D Received: by mail-yw1-x112f.google.com with SMTP id 00721157ae682-31c89653790so4137317b3.13 for ; Wed, 13 Jul 2022 20:02:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7ECyEzS8yAbpgqEvYx2HAE2Hz+/RvtKpy3K6kuR6eFo=; b=DP5jg2/LAEsfUe2UqQFcTL6jPjI60zOji9MP6zujSWwlnuvUwwDzqSSBlDsqIdcEU8 a9twpbRryACxnzWBbVoQxaVN6kOChdUHZJtpIeT7ikVLH26KIkg+iyyQZQLMc1sZVYsz 6rzRXCQ1P+TV+jF7ro9tZ1j7TQtPqQVZ9BfCxhhsR+sjQxmqtt9Ow9qSM5+xux0tFzTN higK0EdvJfuUR1WkOsIgZrvXl4w/PkedJyOZ2N0oV/MLogBn06y7Or0gvE0tYJuOSLsd txDKSWSNdKh4An09b6mwXR4hAJkdCGKKiS85HM7iYWGcyTlBzichMe/+O2cOPbeBbFQY 5RPw== X-Gm-Message-State: AJIora8Wpsbr1E6BQuXbgBPTeDvEvqwkfJ57SEGz1MLxIJttCMkRoFek aSPblB46E9p9a4ZxO3Fdrdgu1qssG0jMNeWGwBAVtr9/VXU= X-Google-Smtp-Source: AGRyM1tpYmcK+nbI8iKlPI/wG1jDJINvEZ2t0U1yNJkAUEr7bdfBKEldXEFmMmFONtPeGi0RuKyA+MpwGEOeUM0y7q8= X-Received: by 2002:a81:a1ca:0:b0:31c:9af0:ab6 with SMTP id y193-20020a81a1ca000000b0031c9af00ab6mr7959000ywg.120.1657767760432; Wed, 13 Jul 2022 20:02:40 -0700 (PDT) MIME-Version: 1.0 References: <20220624164216.2129400-1-goldstein.w.n@gmail.com> <20220624164216.2129400-4-goldstein.w.n@gmail.com> In-Reply-To: From: Sunil Pandey Date: Wed, 13 Jul 2022 20:02:04 -0700 Message-ID: Subject: Re: [PATCH v2] x86: Put wcs{n}len-sse4.1 in the sse4.1 text section To: "H.J. Lu" Cc: Noah Goldstein , GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, HK_RANDOM_ENVFROM, HK_RANDOM_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jul 2022 03:02:42 -0000 On Fri, Jun 24, 2022 at 10:08 AM H.J. Lu via Libc-alpha wrote: > > On Fri, Jun 24, 2022 at 9:42 AM Noah Goldstein wrote: > > > > Previously was missing but the two implementations shouldn't get in > > the sse2 (generic) text section. > > --- > > sysdeps/x86_64/multiarch/strlen-vec.S | 6 +++++- > > sysdeps/x86_64/multiarch/wcslen-sse4_1.S | 1 + > > sysdeps/x86_64/multiarch/wcsnlen-sse4_1.S | 1 + > > 3 files changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/sysdeps/x86_64/multiarch/strlen-vec.S b/sysdeps/x86_64/multiarch/strlen-vec.S > > index 42b6124dfd..874123d604 100644 > > --- a/sysdeps/x86_64/multiarch/strlen-vec.S > > +++ b/sysdeps/x86_64/multiarch/strlen-vec.S > > @@ -28,6 +28,10 @@ > > # define SHIFT_RETURN > > #endif > > > > +#ifndef SECTION > > +# define SECTION(p) p > > +#endif > > + > > /* Long lived register in strlen(s), strnlen(s, n) are: > > > > %xmm3 - zero > > @@ -37,7 +41,7 @@ > > */ > > > > > > -.text > > + .section SECTION(.text),"ax",@progbits > > ENTRY(strlen) > > > > /* Test 64 bytes from %rax for zero. Save result as bitmask in %rdx. */ > > diff --git a/sysdeps/x86_64/multiarch/wcslen-sse4_1.S b/sysdeps/x86_64/multiarch/wcslen-sse4_1.S > > index 7e62621afc..e306a77f51 100644 > > --- a/sysdeps/x86_64/multiarch/wcslen-sse4_1.S > > +++ b/sysdeps/x86_64/multiarch/wcslen-sse4_1.S > > @@ -1,4 +1,5 @@ > > #define AS_WCSLEN > > #define strlen __wcslen_sse4_1 > > +#define SECTION(p) p##.sse4.1 > > > > #include "strlen-vec.S" > > diff --git a/sysdeps/x86_64/multiarch/wcsnlen-sse4_1.S b/sysdeps/x86_64/multiarch/wcsnlen-sse4_1.S > > index 5fa51fe07c..d2f7dd6e22 100644 > > --- a/sysdeps/x86_64/multiarch/wcsnlen-sse4_1.S > > +++ b/sysdeps/x86_64/multiarch/wcsnlen-sse4_1.S > > @@ -1,5 +1,6 @@ > > #define AS_WCSLEN > > #define AS_STRNLEN > > #define strlen __wcsnlen_sse4_1 > > +#define SECTION(p) p##.sse4.1 > > > > #include "strlen-vec.S" > > -- > > 2.34.1 > > > > LGTM. > > Thanks. > > -- > H.J. I would like to backport this patch to release branches. Any comments or objections? --Sunil