From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by sourceware.org (Postfix) with ESMTPS id D8D14385840D for ; Tue, 7 May 2024 18:59:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D8D14385840D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D8D14385840D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::32c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715108400; cv=none; b=VNgwi8/F6i51Jz1ozgy/NbfFhL+hCV4UXAeeRA6J6rfsjz+8n5oyC65rmETorV36a5JCPgaEBzXCRUcRC74PkmiYdudKPJGhxYFCXlzQsObyCU+lvhlfvp//lEJsptDEbyOyUI9WyOXKkpCZgq0LqXQkJL8nnDhBdIeZ+ZcVBC4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715108400; c=relaxed/simple; bh=ngrmpwEHvtrKbS8/H7BYyQMF7Flz5ibMsrapa3e9+OU=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=GNP7+9g33yFB/BcJt2B6n1Ysrt/TevahSgpXuROB+F+1/Yx+peZAN8g8KUpK1PmpA7xqal4RWKUBR/7eI2SgT6LkvR8b/1KaDKknQ7Ytcujk8wfB//8F2if9cUIHcEOT4XpGOXDHdPRRrMiZclrUbf7ZYuZlSjtmOYNSPriq4SI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-41b5e74fa83so26601605e9.0 for ; Tue, 07 May 2024 11:59:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715108397; x=1715713197; darn=sourceware.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=/Xap/AhnjmhyZfRzM+F68/bxit2OGvUHLgi+4HS1Iws=; b=ZZX6smOOqMCvhgopnvTwV9kWTBPTVL8xaDn5yNbhGTdaNr1fJtEjrmaGfQxTXZ1E6v lq2vtDNMvc2qSRg1tMUcUYOipmbLtosI69jWBvffR13TIe1+UkOh3EyiO7zaHsVtjjzJ XIHzqzKq5e8vHqD9cn9QsOet2SMExQQsH0DpiZlARCxpPqUL2v91NtFYHq1ydsCMl9+p 41OvOnhKIpsgrvsfcjzjMreUW5RL+GviA/9ycp/mDgo/hsqIpBxZBUsKxDm0eIxmNE4f MUXBogVlTRnS3/Z+w2XCyL3xKzFIw6Uo5HsVe/QegGBYOD5Rd8JBx9f1Zn1VNwL2suhs oiBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715108397; x=1715713197; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/Xap/AhnjmhyZfRzM+F68/bxit2OGvUHLgi+4HS1Iws=; b=Zzvl7n9T7+NqK+dtQCWk9jtMLm3uL25oRI2iBPV8nP6XZ6/KSAja1+h4JXPtVm2OcP wmxKdZVPrVC2NiCCAonr5PI3kMCUr8AMHOU98Omt5M3Tsuj/MjETwK6v7h/NMzKzJyCp mr0ZKAa2HZjg8carmx7w+0MSV+MExdqM1+G4PxeyxCVZiXfsWR59rDDzn7/xHukmCW6/ gJ+KbFS5WctLI5GXUCvqJXKmHpiJS2qsYpjzbJKGh4heoonH/dw3GneV/v+zwqDs15qq 6BsaIpw8pefF59zDTBquxZz5OLUdgMg2JHxlqX0FYAtVmpr0Yl2iG3vYo547vXFY/9UM TEnQ== X-Gm-Message-State: AOJu0YxzU6sg/ZkLC9iD8tsZNR267D14JG9kYiSEmgabYaPl1HowgM3X /q7mBAW9J0TNESrEreAZn8UiOywU/lig7/0CdcSz7nMAg+kgYPywSpes2nAFOFd7JFc/otkj2vm bF1IJh5HJt9jR7GblFov3C3ECW51o08Xq X-Google-Smtp-Source: AGHT+IFtsyw/lscQp/+lgfJrOg/E2ZEfdaVwrT0Q0oNIYDXX7RSXZYMCugoHjm8VC1dQm6+whJgZngsAK0vNWyTHxAQ= X-Received: by 2002:a5d:5908:0:b0:34a:2d0c:4463 with SMTP id ffacd0b85a97d-34fca149bbdmr558876f8f.4.1715108397098; Tue, 07 May 2024 11:59:57 -0700 (PDT) MIME-Version: 1.0 References: <20240507182502.3820027-1-gabifalk@gmx.com> In-Reply-To: <20240507182502.3820027-1-gabifalk@gmx.com> From: Sunil Pandey Date: Tue, 7 May 2024 11:59:20 -0700 Message-ID: Subject: Re: [PATCH] x86_64: Fix missing wcsncat function definition without multiarch (x86-64-v4) To: Gabi Falk Cc: libc-alpha@sourceware.org, Sam James Content-Type: multipart/alternative; boundary="000000000000c2af060617e1ca5c" X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,GIT_PATCH_0,HK_RANDOM_ENVFROM,HK_RANDOM_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000c2af060617e1ca5c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, May 7, 2024 at 11:27=E2=80=AFAM Gabi Falk wrote: > This code expects the WCSCAT preprocessor macro to be predefined in case > the evex implementation of the function should be defined with a name > different from __wcsncat_evex. However, when glibc is built for > x86-64-v4 without multiarch support, sysdeps/x86_64/wcsncat.S defines > WCSNCAT variable instead of WCSCAT to build it as wcsncat. Rename the > variable to WCSNCAT, as it is actually a better naming choice for the > variable in this case. > > Reported-by: Kenton Groombridge > Link: https://bugs.gentoo.org/921945 > Fixes: 64b8b6516b ("x86: Add evex optimized functions for the wchar_t > strcpy family") > Signed-off-by: Gabi Falk > --- > sysdeps/x86_64/multiarch/wcsncat-evex.S | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/sysdeps/x86_64/multiarch/wcsncat-evex.S > b/sysdeps/x86_64/multiarch/wcsncat-evex.S > index 392215950a..10bfb0a531 100644 > --- a/sysdeps/x86_64/multiarch/wcsncat-evex.S > +++ b/sysdeps/x86_64/multiarch/wcsncat-evex.S > @@ -1,9 +1,9 @@ > -#ifndef WCSCAT > -# define WCSCAT __wcsncat_evex > +#ifndef WCSNCAT > +# define WCSNCAT __wcsncat_evex > #endif > > #define USE_AS_WCSCPY > #define USE_AS_STRCAT > > -#define STRNCAT WCSCAT > +#define STRNCAT WCSNCAT > #include "strncat-evex.S" > -- > gabi > > LGTM Reviewed-by: Sunil K Pandey --Sunil --000000000000c2af060617e1ca5c--