public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] x86: Don't check XFD against /proc/cpuinfo
@ 2024-02-27 19:43 H.J. Lu
  2024-02-28 18:26 ` Sunil Pandey
  0 siblings, 1 reply; 2+ messages in thread
From: H.J. Lu @ 2024-02-27 19:43 UTC (permalink / raw)
  To: libc-alpha

Since /proc/cpuinfo doesn't report XFD, don't check it against
/proc/cpuinfo.
---
 sysdeps/x86/tst-cpu-features-cpuinfo.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/sysdeps/x86/tst-cpu-features-cpuinfo.c b/sysdeps/x86/tst-cpu-features-cpuinfo.c
index c11c6951c3..0251fb5460 100644
--- a/sysdeps/x86/tst-cpu-features-cpuinfo.c
+++ b/sysdeps/x86/tst-cpu-features-cpuinfo.c
@@ -294,7 +294,10 @@ do_test (int argc, char **argv)
   fails += CHECK_PROC (waitpkg, WAITPKG);
   fails += CHECK_PROC (wbnoinvd, WBNOINVD);
   fails += CHECK_PROC (x2apic, X2APIC);
+#if 0
+  /* NB: /proc/cpuinfo doesn't report this feature.  */
   fails += CHECK_PROC (xfd, XFD);
+#endif
   fails += CHECK_PROC (xgetbv1, XGETBV_ECX_1);
   fails += CHECK_PROC (xop, XOP);
   fails += CHECK_PROC (xsave, XSAVE);
-- 
2.43.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] x86: Don't check XFD against /proc/cpuinfo
  2024-02-27 19:43 [PATCH] x86: Don't check XFD against /proc/cpuinfo H.J. Lu
@ 2024-02-28 18:26 ` Sunil Pandey
  0 siblings, 0 replies; 2+ messages in thread
From: Sunil Pandey @ 2024-02-28 18:26 UTC (permalink / raw)
  To: H.J. Lu; +Cc: libc-alpha

[-- Attachment #1: Type: text/plain, Size: 961 bytes --]

On Tue, Feb 27, 2024 at 11:44 AM H.J. Lu <hjl.tools@gmail.com> wrote:

> Since /proc/cpuinfo doesn't report XFD, don't check it against
> /proc/cpuinfo.
> ---
>  sysdeps/x86/tst-cpu-features-cpuinfo.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/sysdeps/x86/tst-cpu-features-cpuinfo.c
> b/sysdeps/x86/tst-cpu-features-cpuinfo.c
> index c11c6951c3..0251fb5460 100644
> --- a/sysdeps/x86/tst-cpu-features-cpuinfo.c
> +++ b/sysdeps/x86/tst-cpu-features-cpuinfo.c
> @@ -294,7 +294,10 @@ do_test (int argc, char **argv)
>    fails += CHECK_PROC (waitpkg, WAITPKG);
>    fails += CHECK_PROC (wbnoinvd, WBNOINVD);
>    fails += CHECK_PROC (x2apic, X2APIC);
> +#if 0
> +  /* NB: /proc/cpuinfo doesn't report this feature.  */
>    fails += CHECK_PROC (xfd, XFD);
> +#endif
>    fails += CHECK_PROC (xgetbv1, XGETBV_ECX_1);
>    fails += CHECK_PROC (xop, XOP);
>    fails += CHECK_PROC (xsave, XSAVE);
> --
> 2.43.2
>

LGTM

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-02-28 18:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-27 19:43 [PATCH] x86: Don't check XFD against /proc/cpuinfo H.J. Lu
2024-02-28 18:26 ` Sunil Pandey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).