From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) by sourceware.org (Postfix) with ESMTPS id 875073858D28 for ; Sat, 9 Apr 2022 15:50:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 875073858D28 Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-2ebf3746f87so30100037b3.6 for ; Sat, 09 Apr 2022 08:50:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=htx6ulfxpBP7lHh4CfMdHy7DG48gd1f/KicDt8Ja0gc=; b=6PiE27F1SQ4rXBn2vnVti7dSg7eK5xMLCIGx84jS1ObqhAO6AZRmhvZQjQINMIs4YG aLHvjR7zDCVXFWoPQQPfG4oS1SkdphFeT5qhA0PxjImNSIxYSzx0KYxyfO01ZVkTQ/FF dbkKEAICf4yZqH4JbLXlcklI++HEhkhI+trkaiGDBknc9qqtlsodW+N4+bC9NjSkf6uO vOKhQBhKiTSCyUg5Qwh+RnGLHzkZcRxpG6OHA0WxPRR+f2KifiDJv2qcLCB1LBzR5iUn 1ie2QJBzkZY7MnDW0NOg9Iqd9+/M7toL0FRVpXHVcTvE5wFiaIvWhJxjmqEu4Ebj3y3o AUjA== X-Gm-Message-State: AOAM5327yY8sSLUGFr4y7YlOTFdv9NReinrhTDnKArgKfkDCx4jRvLXZ hPnl3XNaPJl8YpX6QWfJHf+h/m620SIJNctloICMRJZT X-Google-Smtp-Source: ABdhPJwhfx0kFPEtKboEAQ/5KkLOY6Fw+Zs5f6Ud0bVMNvwKGxeVGDfvviCjZo7/m2lrQImypS4CHgZRIqo+agM8NXU= X-Received: by 2002:a81:4655:0:b0:2eb:2e0e:9d47 with SMTP id t82-20020a814655000000b002eb2e0e9d47mr19746272ywa.455.1649519415840; Sat, 09 Apr 2022 08:50:15 -0700 (PDT) MIME-Version: 1.0 References: <20220320010442.991728-1-bluepenguin@gmail.com> In-Reply-To: From: Ricardo Bittencourt Date: Sat, 9 Apr 2022 12:50:04 -0300 Message-ID: Subject: Re: [PATCH] string: Replace outdated comments in strlen(). To: Joseph Myers Cc: libc-alpha@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Apr 2022 15:50:18 -0000 Hi people, by any chance can someone commit this change? I asked for a sourceware account to do it myself, but it's taking a while, so it would be best if someone applies this patch meanwhile. -- Ricardo On Mon, Mar 21, 2022 at 3:50 PM Ricardo Bittencourt wrote: > > I checked the bug and it's the same comment issue (the comments > describe an earlier version of the algorithm). After sending this > patch I can update the others. > > The generic string improvements in the bug are better than the current > implementation, is there something stopping us from just applying it? > > -- > Ricardo > > On Mon, Mar 21, 2022 at 3:18 PM Joseph Myers wrote: > > > > Some incidental comments (this is not a review of the patch and should not > > delay it going in): > > > > * Do I understand correctly that this is a *different* comment issue from > > the one described in bug 5806 with comments in various string functions? > > (Maybe the issue described in comment#10 in that bug?) > > > > * I'd still like to see the generic string function improvements discussed > > in that bug getting into glibc at some point. > > > > -- > > Joseph S. Myers > > joseph@codesourcery.com