From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-f173.google.com (mail-yb1-f173.google.com [209.85.219.173]) by sourceware.org (Postfix) with ESMTPS id A2E04385EC56 for ; Mon, 21 Mar 2022 18:50:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A2E04385EC56 Received: by mail-yb1-f173.google.com with SMTP id h126so29803914ybc.1 for ; Mon, 21 Mar 2022 11:50:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EtAj+T54ORU0SK5qb46dbyl06hqyKmtIGl9i35rfLtY=; b=mfFyefNTekQrtzGkFMwtPp34X4KIjk6BaTIAqrgyvgNUoU1ArauxV0BKeAGHmzy1E8 5O9ReVRDYjL8ONj75aL4wFIuNQEIq3UENhQYNCwkrhQsxQsFPcz4ztKQ4wqc1fgu5mcF RW6t0+4rV/ITO5FoC1KbUNMxjgD2V3yvqH+Sry8y5AUfbtLXrijWGx6rMPKt3QmuZCRU 4xBbYIWsi9ZdGoNhC/PNwPloDuhWtwtSNvtSprOEN/AghKm6ig7lVkMPniy+s0Vufvry DSmObmC1LUwTsaZTs48UY0J/qsK0gScvkL8kHNdCCCt0PlShw2KFR2DSDdgknjAslfnv YTBA== X-Gm-Message-State: AOAM531iuZ6NzzNp8ci9OqqKBgo/ya1Jb9XK3My9pfoBc72T5qsAVomH Z5nmXapCk3jzhwC5An2KfGiuKNmORTMAT66cIQ1Glx4f X-Google-Smtp-Source: ABdhPJw4eekBIQvttO8+XDpGrgxEN56T0nH0eln/Z2/+D7msUd4wwcQAxDstA450KCyV/avVVnDfwrMHje6zzZ/j+y0= X-Received: by 2002:a25:4150:0:b0:633:65f5:8910 with SMTP id o77-20020a254150000000b0063365f58910mr23040975yba.210.1647888610937; Mon, 21 Mar 2022 11:50:10 -0700 (PDT) MIME-Version: 1.0 References: <20220320010442.991728-1-bluepenguin@gmail.com> In-Reply-To: From: Ricardo Bittencourt Date: Mon, 21 Mar 2022 15:50:00 -0300 Message-ID: Subject: Re: [PATCH] string: Replace outdated comments in strlen(). To: Joseph Myers Cc: libc-alpha@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Mar 2022 18:50:13 -0000 I checked the bug and it's the same comment issue (the comments describe an earlier version of the algorithm). After sending this patch I can update the others. The generic string improvements in the bug are better than the current implementation, is there something stopping us from just applying it? -- Ricardo On Mon, Mar 21, 2022 at 3:18 PM Joseph Myers wrote: > > Some incidental comments (this is not a review of the patch and should not > delay it going in): > > * Do I understand correctly that this is a *different* comment issue from > the one described in bug 5806 with comments in various string functions? > (Maybe the issue described in comment#10 in that bug?) > > * I'd still like to see the generic string function improvements discussed > in that bug getting into glibc at some point. > > -- > Joseph S. Myers > joseph@codesourcery.com