Dear Carlos,

On Fri, 3 May 2024 at 17:32, Carlos O'Donell <carlos@redhat.com> wrote:

> On 4/16/24 12:59, Job Snijders wrote:
> > Dear all,
> >
> > The below patch is a new revision to add IPv6 support to
> > inet_net_pton(). The patch is based on the OpenBSD implementation.
> >
> > Kind regards,
> >
> > Job
> >
> > Signed-off: Job Snijders <job@fastly.com>
>
> In my context as a project steward, and because DJ asked me to look at
> this patch
> with regards to the license changes, I'm going to ask some clarifying
> questions to
> make sure we respect your wishes as the contributor of the patch.
>
> For the review I will note that:
>
> (a) You are using DCO...



What does “DCO” mean?


> ---
> >  resolv/inet_net_pton.c | 69 +++++++++++++++++++++++++++++++++++++++---
> >  1 file changed, 65 insertions(+), 4 deletions(-)
> >
> > diff --git a/resolv/inet_net_pton.c b/resolv/inet_net_pton.c
> > index 63a47b7394..93753cb37f 100644
> > --- a/resolv/inet_net_pton.c
> > +++ b/resolv/inet_net_pton.c
> > @@ -1,4 +1,6 @@
> >  /*
> > + * Copyright (c) 2024 Job Snijders <job@fastly.com>
> > + * Copyright (c) 2012 by Gilles Chehade <gilles@openbsd.org>
>
> ... and (b) You add new copyright notices for specific individuals to the
> ISC
> license portion.
>
> Now the questions:
>
> (1) May you please confirm that you are contributing your own changes under
>     the ISC License?



Yes, confirmed.


    - Gilles Chehade <gilles@openbsd.org> changes were already contributed
>       under that license to OpenBSD.
>
>     - The other acceptable license in this case, and it's up to you, would
>       be LGPLv2.1+. The choice here is a balance between what glibc
>       will accept e.g. compatible free license, and what you want to
>       contribute under. If you are considering keeping this code in sync
>       with OpenBSD, then it would be simpler to stay with the ISC License
>       that we already have here.
>
> (2) Would you be amenable to using "Copyright The GNU Toolchain Authors."
>     as your notice instead?



I’d prefer to be listed by my own name.


    - You are absolutely entitled to a copyright notice if you request
>       it, but glibc project maintenance is simplified by a using a general
>       notice.
>       Please see:
> https://www.linuxfoundation.org/blog/blog/copyright-notices-in-open-source-software-projects
>
>     - The notice from Gilles Chehade must be preserved because it comes
>       from the copy of the OpenBSD implementation.
>
> Thank you for contributing to glibc! :-)



You are welcome, thanks for taking a look!

Kind regards,

Job