From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x2e.google.com (mail-oa1-x2e.google.com [IPv6:2001:4860:4864:20::2e]) by sourceware.org (Postfix) with ESMTPS id 8BCAD3846059 for ; Fri, 3 May 2024 15:55:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8BCAD3846059 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=fastly.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=fastly.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8BCAD3846059 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:4860:4864:20::2e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714751706; cv=none; b=nsgulDkisujejeElOeHz5CacPCd+DUX4136Qg4BqU6XRm54/fCcwMnuzAr2haiFderWEeXO8tHIg8kzOvUxRnfcNzxhcjoj6uEJs5Law/T5vucYhoUIiFBT9pO1RVwWfNJbsg4YhGIyiBwOHv6TBwqD4oLtIvQvv3L8mBuwUON0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714751706; c=relaxed/simple; bh=dskQnsCuNj1xqSgJPFgHixYPG8WbEjh7y0fYwt0PR+o=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=YoqhTRNZRfzh3B1cluKL8+zpu1RyHO3CvL7wn9tWhGU1hu7IHloC7TMTeznTyYb/3NyYSDOJWhzaOr6vqYbvuPb2k/Fntk41YYN0Gs2+4f8yDApkWN4XSYEJsJXETBHtbivHc/+S8vFHmbrG9bqJl1NWaDWCFM4mIxjkvQKBYVo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oa1-x2e.google.com with SMTP id 586e51a60fabf-23cd15209fdso2744939fac.3 for ; Fri, 03 May 2024 08:55:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1714751700; x=1715356500; darn=sourceware.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=FxqtxxmpjJ1X+xMEoeYw+CnVqFJuvdedfct8BGy9bQQ=; b=D7D2A/dqFU3WCtsCq3NaHr908G7/msoWPQgo/AVdNotLp4az6BP96uNUd0XAQ0V1GM ndLLFuUDtfGZ3bx64PTlgtd9dg7UWcIlXpAMD3w37f1BJrPERwaTMmVPa6HJz60c9hEJ /C88G9ch3RRpu7zNOfnBo1cp8HZX4KmkRr8Y0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714751700; x=1715356500; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FxqtxxmpjJ1X+xMEoeYw+CnVqFJuvdedfct8BGy9bQQ=; b=UfANnObnI8dYPOkB50QAs57NA7kS3sGu9/oUmtsOl8B1R+IlcAFPcKYdP7wGA600MR DV8VX2ybdwO2ticvqDJlB6lG+xa9YLqQJ8hM792NrbZJCeWJiqzI/I7FeCuaR4moHR54 Pncxs39rety+isdxfWVo6aIJQ/K34AnDGtz0K/cTOtL2EMqMsM0czgsh80Y1i17Ttx4d 77/iQ7vDPahep3CgV+TRVvgGXMjoiT5Z2hYgyNIiui5WAlCgB2k/mZp1bMYQmrs/LHLX nBU49N4OSLLVVh3sARRMMNjVO8q6dhZ/ENgx/D4tHIAYv9vIrIxX5in9R0XJdgxD3HqC 4x+Q== X-Gm-Message-State: AOJu0Yzv9idNyKPjdYviq29i2NxnrgwbfvcWAIn+1yatR2ElUv6eID70 vmG6owy6KXhT1LQz/xTJKft87ZocZur3oyN7r64fH/ahvL5ge97jwDBKVZmVRE+bhCe4t2DpqL5 F88pIPc6gIMgdPk1g4jHQGJqHhOoOUipjMSSYww== X-Google-Smtp-Source: AGHT+IFktxNDR04VNAQdhH7PLcS5YWlnHYNC4jic4k+IjQbU8w6zZhj7EIJdpR8vS0L16dm8wUh//SPJKONICBysvNY= X-Received: by 2002:a05:6871:590:b0:23c:d140:fe83 with SMTP id u16-20020a056871059000b0023cd140fe83mr3522089oan.54.1714751699926; Fri, 03 May 2024 08:54:59 -0700 (PDT) MIME-Version: 1.0 References: <6f5750e3-8ed4-47af-8e6a-857b7784d0d2@redhat.com> In-Reply-To: <6f5750e3-8ed4-47af-8e6a-857b7784d0d2@redhat.com> From: Job Snijders Date: Fri, 3 May 2024 17:54:49 +0200 Message-ID: Subject: Re: [PATCH v2] resolv: add IPv6 support to inet_net_pton() To: "Carlos O'Donell" Cc: libc-alpha@sourceware.org Content-Type: multipart/alternative; boundary="000000000000f3da5706178ebda7" X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPAM_FROM,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000f3da5706178ebda7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Dear Carlos, On Fri, 3 May 2024 at 17:32, Carlos O'Donell wrote: > On 4/16/24 12:59, Job Snijders wrote: > > Dear all, > > > > The below patch is a new revision to add IPv6 support to > > inet_net_pton(). The patch is based on the OpenBSD implementation. > > > > Kind regards, > > > > Job > > > > Signed-off: Job Snijders > > In my context as a project steward, and because DJ asked me to look at > this patch > with regards to the license changes, I'm going to ask some clarifying > questions to > make sure we respect your wishes as the contributor of the patch. > > For the review I will note that: > > (a) You are using DCO... What does =E2=80=9CDCO=E2=80=9D mean? > --- > > resolv/inet_net_pton.c | 69 +++++++++++++++++++++++++++++++++++++++--- > > 1 file changed, 65 insertions(+), 4 deletions(-) > > > > diff --git a/resolv/inet_net_pton.c b/resolv/inet_net_pton.c > > index 63a47b7394..93753cb37f 100644 > > --- a/resolv/inet_net_pton.c > > +++ b/resolv/inet_net_pton.c > > @@ -1,4 +1,6 @@ > > /* > > + * Copyright (c) 2024 Job Snijders > > + * Copyright (c) 2012 by Gilles Chehade > > ... and (b) You add new copyright notices for specific individuals to the > ISC > license portion. > > Now the questions: > > (1) May you please confirm that you are contributing your own changes und= er > the ISC License? Yes, confirmed. - Gilles Chehade changes were already contributed > under that license to OpenBSD. > > - The other acceptable license in this case, and it's up to you, would > be LGPLv2.1+. The choice here is a balance between what glibc > will accept e.g. compatible free license, and what you want to > contribute under. If you are considering keeping this code in sync > with OpenBSD, then it would be simpler to stay with the ISC License > that we already have here. > > (2) Would you be amenable to using "Copyright The GNU Toolchain Authors." > as your notice instead? I=E2=80=99d prefer to be listed by my own name. - You are absolutely entitled to a copyright notice if you request > it, but glibc project maintenance is simplified by a using a general > notice. > Please see: > https://www.linuxfoundation.org/blog/blog/copyright-notices-in-open-sourc= e-software-projects > > - The notice from Gilles Chehade must be preserved because it comes > from the copy of the OpenBSD implementation. > > Thank you for contributing to glibc! :-) You are welcome, thanks for taking a look! Kind regards, Job --000000000000f3da5706178ebda7--