From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) by sourceware.org (Postfix) with ESMTPS id 42DD6385802D for ; Fri, 30 Apr 2021 19:23:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 42DD6385802D Received: by mail-qk1-x72e.google.com with SMTP id u20so39717982qku.10 for ; Fri, 30 Apr 2021 12:23:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=PsdNsBLZSDtwUf8yLWCouhUzzgnA+7zMJZTU4M4tVPA=; b=HnjENPsKtXi4PRe+TP90z/HIYQm+XqDGktbL6619ps0C7XpdxWp66cQa4+ueKGLFfP XnFPDkmGkC+GcEHGesF468QOPBFRPzzyGdP+BvomdoOT31mAmjPchZn8BTESuUERrGhU eK7jwq+gh8nFUoVYmZK4ErlWw78W65hA3N24DBIDWKLolfX6O/7wH3UBpxTb4daRtdAx IiLp3RbiW+VYOZSZygqo2mAbLdtHJ0afNWSJQxRwJp/nf0hwBMIHWIAggYOJ8Q3UHvEc W9EL3buYJtYcWwQJa2+didPH758bVkMXVPtUUvA+P3j+3jatb/3DH1NAXY7Di3uGEokR xBwQ== X-Gm-Message-State: AOAM533Rc0+ZzUaXhmQdteDZP3n6Q91ADnosok5JL5JiQw6nG5kZBL6m /qbHmaskl2sTXE+qUiKtpUERIakl6d/dDnzM2Ux2ue1BQh9ZDw== X-Google-Smtp-Source: ABdhPJzxlL22vTzJJbdLSW19aOXs0wxQUV18Fc3tuzIK3Un0XhmpS5Rud4QvCenCFyxpeqwcwkNUJJ42FcZ3JOFxW8g= X-Received: by 2002:a37:624c:: with SMTP id w73mr7010880qkb.125.1619810585640; Fri, 30 Apr 2021 12:23:05 -0700 (PDT) MIME-Version: 1.0 References: <20210430182814.1164481-1-raj.khem@gmail.com> In-Reply-To: From: Khem Raj Date: Fri, 30 Apr 2021 12:22:39 -0700 Message-ID: Subject: Re: [PATCH] Propagate -ffile-prefix-map from CFLAGS to ASFLAGS. To: GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-10.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Apr 2021 19:23:07 -0000 On Fri, Apr 30, 2021 at 12:08 PM Khem Raj wrote: > > On Fri, Apr 30, 2021 at 11:28 AM Khem Raj wrote: > > > > -ffile-prefix-map could be used as superset to imply -fdebug-prefix-map > > as well, therefore it should be propagated too, so cases when > > -ffile-prefix-map is used but -fdebug-prefix-map is not, then it should > > still rewire the paths in debug info > > hmm noticed that when I remove -fdebug-prefix-map then > -ffile-prefix-map did not work and its because GCC is not > translating -ffile-prefix-map to equivalent assembler option > --debug-prefix-map like it does for -fdebug-prefix-map > it seems a bug in GCC driver. infact there already is a bug for gcc driver for this https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93371 > > > --- > > Makeconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Makeconfig b/Makeconfig > > index 01f8638c2e..5a675e20e3 100644 > > --- a/Makeconfig > > +++ b/Makeconfig > > @@ -1067,7 +1067,7 @@ endif > > > > # The assembler can generate debug information too. > > ifndef ASFLAGS > > -ASFLAGS := $(filter -g% -fdebug-prefix-map=%,$(CFLAGS)) > > +ASFLAGS := $(filter -g% -ffile-prefix-map=% -fdebug-prefix-map=%,$(CFLAGS)) > > endif > > override ASFLAGS += -Werror=undef $(ASFLAGS-config) $(asflags-cpu) > > > > -- > > 2.31.1 > >