Re: [PATCH] timezone: re-written tzselect as posix sh

[Khem Raj <raj.khem@gmail.com>]

On Thu, Dec 2, 2021 at 7:38 AM Florian Weimer <fweimer@redhat.com> wrote:
>
> * Khem Raj via Libc-alpha:
>
> > To avoid the bash dependency.
> >
> > Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > ---
> >  timezone/tzselect.ksh | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/timezone/tzselect.ksh b/timezone/tzselect.ksh
> > index 18fce27e24..7705df83d7 100755
> > --- a/timezone/tzselect.ksh
> > +++ b/timezone/tzselect.ksh
> > @@ -1,4 +1,4 @@
> > -#!/bin/bash
> > +#!/bin/sh
> >  # Ask the user about the time zone, and output the resulting TZ value to stdout.
> >  # Interact with the user via stderr and stdin.
> >
> > @@ -34,7 +34,7 @@ REPORT_BUGS_TO=tz@iana.org
> >
> >  # Specify default values for environment variables if they are unset.
> >  : ${AWK=awk}
> > -: ${TZDIR=`pwd`}
> > +: ${TZDIR=$(pwd)}
> >
> >  # Output one argument as-is to standard output.
> >  # Safer than 'echo', which can mishandle '\' or leading '-'.
>
> Is this really a bashism?  I'm surprised.

you are right. I tested it on bash/dash/zsh/ash it works as expected.
Let me find
the real reason for this patch and come back.

>
> Thanks,
> Florian
>