From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by sourceware.org (Postfix) with ESMTPS id 67DDA3858D20 for ; Tue, 2 Apr 2024 02:17:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 67DDA3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 67DDA3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::629 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712024279; cv=none; b=vaeVNdGFY1OyYvYoQ0XOj0L86gVEZZ8sopQcXrW0t2ZoUrfb5/JClN/fhXgX0stzrQxQVJgtppLdUP7h00YCO/ttrhQSWS70mBCI/lAuiUc6//5EJjIGGROI8khYKzkGaffaGJOvqS5766xpa2Q155qqaseSi1ovprx5+0iWxns= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712024279; c=relaxed/simple; bh=gDykaVFI0rN9ktVjxltGnWXtWFtxC7Uo3fQsjpg1hBY=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=iCQNjOOXE3tG0Msugf2NdNSlFs0f7MlsC9qrPkNHqrKwsKCY9LOYkesKo319tCZFN99KbRovHEmktLPeRB7G7iPaaKV3XzIGndtockSuVGJO1faCjfDqnJZ03MQTpqF4HptPgI/0pwHLOc+SPQDG6SnYEdxacxH9xddSd753yew= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-1e0edd0340fso41757705ad.2 for ; Mon, 01 Apr 2024 19:17:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712024276; x=1712629076; darn=sourceware.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=bAT9vPpVT3CteocsY5DlZxMqd574qK3IAn4SRlsqnEs=; b=Up53XrfADlP8jnSKFzIJaswFkZGaRdVtzU2s4GaHMcStK2Orka0pn3i1RaHSvAs7wg ldGcdwTwOuknCjRl1CH/BT1HyQcJ6YTB3IKX8BsAooaRuDzc6HvDT78n7cmqYs4dacLQ R3kHQD38OHx4zvwH69IofTLm12cL4T9vcPY0MiZmoz2+bIkYa5ogw5YrP02prnXLdAHg mt+F15C4I7+5QttDfQvVRiaXXk48saePRaXD/dZaseYTLNvHdZxocOQxxy13BfM5msVk 2oX583ZU3crqDQfeWMj7qK9EKiyPLjQexqkGF57kky2Omhx36/L6jmcn2LRCbN7gGb5V FV1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712024276; x=1712629076; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bAT9vPpVT3CteocsY5DlZxMqd574qK3IAn4SRlsqnEs=; b=Rk0eHk4rLpEXS22NvKCwP8Q3GVI1G9C716wuSDtONlmLiNrTlFbzEsKwQAH4ZSTmIn V5u70R2ax0lysrpjeb171n2Dr7FFKXU6imdOfeTORlppRH1IDDKGYawMhhsWkrx9kr6A CommGTjogdeqoncfGeqzg6kUAHBdGz9MrgIM49nNpL8+9riEC+W0W0RMFj2u5mYufrom dIdhTiX0wtUCjC0L5zDgZ+ipIekjlJk86sTTuklsKK05u2gsn/i6dkkGYwrtgejWFd61 6jhjK+QnWXr+Tj13Zyhe68uCta4Xb8Ww3NmvYZTeXRFEzeIVwbyU2h+NwYVB7NHhz4Of qsRA== X-Gm-Message-State: AOJu0Yz/bQKaE49FNdf09tYluZHvUaFWHye68Yt57YTfNqnr+VnMLAqZ 4E/0OtViKui8zrwRgYOtoVg3RAUUWLZabWNmWyTMPS2LmMI2I0A4+hAssRHKOIdsFB0MArifo4V riXS+dHmuVhbDw5psarxnLC9Y8ISnphIDniGRsw== X-Google-Smtp-Source: AGHT+IEPR8jWY63BxuWOfurQsphAX/9IEIQt4AEkDRjK7RTxZLD02yhxFn++6GokvX/gC3LxHcM8SNJ7lzqsko8NUlg= X-Received: by 2002:a17:903:11d2:b0:1e0:62bc:68d4 with SMTP id q18-20020a17090311d200b001e062bc68d4mr15215154plh.14.1712024276352; Mon, 01 Apr 2024 19:17:56 -0700 (PDT) MIME-Version: 1.0 References: <87plv91b22.fsf@oldenburg3.str.redhat.com> In-Reply-To: <87plv91b22.fsf@oldenburg3.str.redhat.com> From: abush wang Date: Tue, 2 Apr 2024 10:17:45 +0800 Message-ID: Subject: Re: [PATCH] stdlib: reorganize stdlib Makefile routines by functionality To: Florian Weimer Cc: abushwang via Libc-alpha , adhemerval.zanella@linaro.org Content-Type: multipart/alternative; boundary="000000000000d6cd9a061513b600" X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000d6cd9a061513b600 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Yes=EF=BC=8Con x86-64. I just compare the disassemble between d275970ab and before commit by objdump. And __drand48_iterate will be more long distance after d275970ab, so I revert this commit and found the performance will recover a little. Thanks, abush On Mon, Apr 1, 2024 at 9:12=E2=80=AFPM Florian Weimer = wrote: > * abush wang: > > > This is test: > > ``` > > uint64_t getnsecs() { > > uint32_t lo, hi; > > __asm__ __volatile__ ( > > "rdtsc" : "=3Da"(lo), "=3Dd"(hi) > > ); > > return ((uint64_t)hi << 32) | lo; > > } > > > > int main() { > > const int num_iterations =3D 1; > > uint64_t start, end, total_time =3D 0; > > > > start =3D getnsecs(); > > for (int i =3D 0; i < num_iterations; i++) { > > (void) lrand48(); > > } > > end =3D getnsecs(); > > total_time +=3D (end - start); > > > > printf("Average time for lrand48: %lu cycles\n", total_time / > num_iterations); > > return 0; > > } > > ``` > > before: > > Average time for lrand48: 21418 cycles > > > > after: > > Average time for lrand48: 9892 cycles > > Do you see this on x86-64? So this isn't a displacement range issue? > > It could be that this is a random performance change due to code > alignment, and not actually caused by the direct call distance. > > Thanks, > Florian > > --000000000000d6cd9a061513b600--