From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x1129.google.com (mail-yw1-x1129.google.com [IPv6:2607:f8b0:4864:20::1129]) by sourceware.org (Postfix) with ESMTPS id 69F40385AC29 for ; Tue, 7 Mar 2023 08:53:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 69F40385AC29 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yw1-x1129.google.com with SMTP id 00721157ae682-536be69eadfso233002917b3.1 for ; Tue, 07 Mar 2023 00:53:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678179231; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=xMC7D1P4NyjAsRHUF0IbHpA0LVN06yqE33bmbRh4hw8=; b=ZDYZjmd70VsDhF6BwIWqA4RjANuHzJWba3unLXGAaPOQmyZ7ruWLonhYdOPlqUW4lv jBC/p+//IuGq6C9C2hSi/US9asTFhsXYoQvjNuFcM+Bcd9oacnXG9OcyTXVYxTaMAEht JClznoGwoQXjkhzKt5j02oBPhrh+O4ZtuWNLOtrJnDlkxyCi+PZGSOgOuEVqg5F8nfKI eXhO28MRdbM5GOY8jKpz7RKpxZlgLgSkGVlTG+K0KajLQzQrt/rYuxdiCV/WWwwtf7H5 zqxmPL8h/sopzki/Yw2pmFtU5UKYLyRnIOAxcf6fXwUT4Y2vmRQViS1/u9xIpFxFVmky lRcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678179231; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xMC7D1P4NyjAsRHUF0IbHpA0LVN06yqE33bmbRh4hw8=; b=L26DRPysdGmrVdIoWtioT6uWR0uHI3fj6TBfKplRJoaXtdJCQIn0TbUqQp6Rxgvkj3 BSgvIoHBaNZLiK822NQBM+APnPP33dnxgaoAomUUXsguz82kJnxQySDXHyVuT2MCiG9y ySf4D2sUpeRHP5HVeDpqBEINAXB3Z16DLpSIpbY1o+x6CqMNxjerAzD7Qbz+d8MNR0C0 4lHl5g3uuZJw3q8M+sEGrK9Hm3mHWRHYKTM4LrCB0IvR8aJkKK/RRmCkxBztMCd3cyMt OkdCSFrt5sOg24OoDBJxT+NqRPBaqou6HEHfFLuxN/1ip0x9dkitapgeTINlz2GaozTB 29Sg== X-Gm-Message-State: AO0yUKWi2rwhSoV6zr3fncReZF+D8DPeFks4+iGl9J9OMwkBVDLpYKiT U+iPeGHwJCRQ+tAq/7zk85rtXyGHObB2n3Kufss= X-Google-Smtp-Source: AK7set9w7di63iMDGAxyTCaX07aoXob8aitmnGkxrnX99YG3RgJP0mZKzs1M1VIDbAQ5DwY8Rpbc+k6a/enO/paVSok= X-Received: by 2002:a81:ae1d:0:b0:524:5bc5:a3d5 with SMTP id m29-20020a81ae1d000000b005245bc5a3d5mr8450186ywh.4.1678179230873; Tue, 07 Mar 2023 00:53:50 -0800 (PST) MIME-Version: 1.0 References: <20230307035030.437573-1-abushwangs@gmail.com> <38edf460b4dba6f33af637f15a528076b1ce5777.camel@xry111.site> In-Reply-To: <38edf460b4dba6f33af637f15a528076b1ce5777.camel@xry111.site> From: abush wang Date: Tue, 7 Mar 2023 16:53:39 +0800 Message-ID: Subject: Re: [PATCH] nptl: pthread_rwlock_rdlock return in low priority To: Xi Ruoyao Cc: libc-alpha@sourceware.org, drepper.fsp@gmail.com Content-Type: multipart/alternative; boundary="000000000000ecfd9905f64b8c9a" X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000ecfd9905f64b8c9a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable ignore this empty line, i just want send this mail Xi Ruoyao =E4=BA=8E2023=E5=B9=B43=E6=9C=887=E6=97=A5= =E5=91=A8=E4=BA=8C 16:40=E5=86=99=E9=81=93=EF=BC=9A > On Tue, 2023-03-07 at 11:50 +0800, abushwang via Libc-alpha wrote: > > Signed-off-by: abushwang > > --- > > nptl/pthread_rwlock_common.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/nptl/pthread_rwlock_common.c b/nptl/pthread_rwlock_common.c > > index 5266a00ed1..35b00fc14f 100644 > > --- a/nptl/pthread_rwlock_common.c > > +++ b/nptl/pthread_rwlock_common.c > > @@ -389,6 +389,7 @@ __pthread_rwlock_rdlock_full64 (pthread_rwlock_t > *rwlock, clockid_t clockid, > > complexity. */ > > if (__glibc_likely ((r & PTHREAD_RWLOCK_WRPHASE) =3D=3D 0)) > > return 0; > > + > > I don't think simply adding an empty line can fix anything. > > > /* Otherwise, if we were in a write phase (states #6 or #8), we must > wait > > for explicit hand-over of the read phase; the only exception is if > we > > can start a read phase if there is no primary writer currently. = */ > > -- > > 2.36.1 > > -- > Xi Ruoyao > School of Aerospace Science and Technology, Xidian University > --000000000000ecfd9905f64b8c9a--