From: Andrew Senkevich <andrew.n.senkevich@gmail.com>
To: "Carlos O'Donell" <carlos@redhat.com>
Cc: Joseph Myers <joseph@codesourcery.com>,
libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH x86-64][BZ #20024] Fixed vector sincos/sincosf ABI
Date: Sat, 18 Jun 2016 10:03:00 -0000 [thread overview]
Message-ID: <CAMXFM3tBA=R=hXrCYyXcWCCwJjd+nSYq2XBZmzn0+uYC42c05A@mail.gmail.com> (raw)
In-Reply-To: <CAMXFM3snbXbRLRuCTRgtnp4QLsfvtWYSZx=mT6qdFC+HYPYTkQ@mail.gmail.com>
2016-06-11 15:56 GMT+03:00 Andrew Senkevich <andrew.n.senkevich@gmail.com>:
> 2016-06-07 3:02 GMT+03:00 Carlos O'Donell <carlos@redhat.com>:
>> On 06/06/2016 10:08 AM, Joseph Myers wrote:
>>> C tests seem safer where possible. For example: the existing functions
>>> are said to take vectors of pointers. Does that mean vectors of 8-byte
>>> pointers for the 64-bit ABI and vectors of 4-byte pointers for x32? If
>>> so, a C test is more likely to get right that the ABI to test is different
>>> in those cases.
>>
>> +1
>
> Here is new version of patch with fixed implementations for x32 and
> new C tests for sincos ABI.
Ping.
ChangeLog is:
2016-06-11 Andrew Senkevich <andrew.senkevich@intel.com>
[BZ #20024]
* sysdeps/x86_64/fpu/multiarch/svml_d_sincos2_core_sse4.S: Fixed ABI
of this implementation of vector function.
* sysdeps/x86_64/fpu/multiarch/svml_d_sincos4_core_avx2.S: Likewise.
* sysdeps/x86_64/fpu/multiarch/svml_d_sincos8_core_avx512.S: Likewise.
* sysdeps/x86_64/fpu/multiarch/svml_s_sincosf16_core_avx512.S:
Likewise.
* sysdeps/x86_64/fpu/multiarch/svml_s_sincosf4_core_sse4.S: Likewise.
* sysdeps/x86_64/fpu/multiarch/svml_s_sincosf8_core_avx2.S: Likewise.
* sysdeps/x86_64/fpu/svml_d_sincos2_core.S: Likewise.
* sysdeps/x86_64/fpu/svml_d_sincos4_core.S: Likewise.
* sysdeps/x86_64/fpu/svml_d_sincos4_core_avx.S: Likewise.
* sysdeps/x86_64/fpu/svml_d_sincos8_core.S: Likewise.
* sysdeps/x86_64/fpu/svml_s_sincosf16_core.S: Likewise.
* sysdeps/x86_64/fpu/svml_s_sincosf4_core.S: Likewise.
* sysdeps/x86_64/fpu/svml_s_sincosf8_core.S: Likewise.
* sysdeps/x86_64/fpu/svml_s_sincosf8_core_avx.S: Likewise.
* sysdeps/x86_64/fpu/test-double-vlen2-wrappers.c: Redefined wrapper
for testing vector function with fixed ABI.
* sysdeps/x86_64/fpu/test-double-vlen4-avx2-wrappers.c: Likewise.
* sysdeps/x86_64/fpu/test-double-vlen4-wrappers.c: Likewise.
* sysdeps/x86_64/fpu/test-double-vlen8-wrappers.c: Likewise.
* sysdeps/x86_64/fpu/test-float-vlen16-wrappers.c: Likewise.
* sysdeps/x86_64/fpu/test-float-vlen4-wrappers.c: Likewise.
* sysdeps/x86_64/fpu/test-float-vlen8-avx2-wrappers.c: Likewise.
* sysdeps/x86_64/fpu/test-float-vlen8-wrappers.c: Likewise.
* sysdeps/x86_64/fpu/test-double-libmvec-sincos-avx.c: New test.
* sysdeps/x86_64/fpu/test-double-libmvec-sincos-avx2.c: Likewise.
* sysdeps/x86_64/fpu/test-double-libmvec-sincos-avx512.c: Likewise.
* sysdeps/x86_64/fpu/test-double-libmvec-sincos.c: Likewise.
* sysdeps/x86_64/fpu/test-float-libmvec-sincosf-avx.c: Likewise.
* sysdeps/x86_64/fpu/test-float-libmvec-sincosf-avx2.c: Likewise.
* sysdeps/x86_64/fpu/test-float-libmvec-sincosf-avx512.c: Likewise.
* sysdeps/x86_64/fpu/test-float-libmvec-sincosf.c: Likewise.
* sysdeps/x86_64/fpu/Makefile: Added new tests.
--
WBR,
Andrew
next prev parent reply other threads:[~2016-06-18 10:03 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 19:41 Andrew Senkevich
2016-06-01 0:15 ` Carlos O'Donell
2016-06-01 20:03 ` Andrew Senkevich
2016-06-02 22:50 ` Joseph Myers
2016-06-06 13:35 ` Andrew Senkevich
2016-06-06 14:08 ` Joseph Myers
2016-06-07 0:02 ` Carlos O'Donell
2016-06-11 12:56 ` Andrew Senkevich
2016-06-18 10:03 ` Andrew Senkevich [this message]
2016-06-22 15:13 ` Joseph Myers
2016-06-22 17:53 ` Andrew Senkevich
2016-06-22 17:57 ` Joseph Myers
2016-06-23 16:33 ` Andrew Senkevich
2016-06-27 11:26 ` Andrew Senkevich
2016-06-29 21:59 ` Joseph Myers
2016-06-30 12:41 ` Andrew Senkevich
2016-06-30 13:47 ` Joseph Myers
2016-06-30 15:22 ` Andrew Senkevich
2016-06-30 22:26 ` Joseph Myers
2016-07-01 11:53 ` Andrew Senkevich
2016-07-01 16:15 ` Joseph Myers
2016-07-04 12:14 ` Andrew Senkevich
2016-07-08 14:08 ` Andrew Senkevich
2016-07-08 16:20 ` Adhemerval Zanella
2016-06-30 11:44 ` Andrew Senkevich
2016-06-30 12:36 ` Andrew Senkevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMXFM3tBA=R=hXrCYyXcWCCwJjd+nSYq2XBZmzn0+uYC42c05A@mail.gmail.com' \
--to=andrew.n.senkevich@gmail.com \
--cc=carlos@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).