From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 41063 invoked by alias); 7 Dec 2016 20:04:00 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 41048 invoked by uid 89); 7 Dec 2016 20:03:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=hjltoolsgmailcom, hjl.tools@gmail.com, S, capital X-HELO: mail-vk0-f67.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=oBCb8fqn+zHmI11/Hv2jDIiYf6czpHY0GQxPEpWDEWM=; b=OTQS9e6/ZjXVE/tsJYjHS/Jk5MAoO4W5o5OgR0k+NFQp08Awzg3p51OZJF2+srWlB6 7eNwdFPOJ9tNDGzG25zUbnH1TPI+mnfJ+TPwr6CcKOxD3WiYfWQiWVt+m+vivS9ozAjT 3h5cEwTweC7YZATZDT6bfQmmwuGhIuxentwgR9+UWtU6LscRB8OGd6nRurcB75Cf4uI4 BzBFZA4rUCMMHKkOlqmkKCV619qMne4T8o3RsBem6A+tzj3yaKGHUOEwjYVAFr+E5D/F HkGYpBespWC7S26XIgU57JpQi4Eap1Kii5V6SCtikkcffJGcYQT66I3zgEWLOBG8AdHt aOQg== X-Gm-Message-State: AKaTC01F8Xb0Hs7+0Cm0xNfNmK4T8KSWX+5b7U8VdXBMm9UvARSEq31XrUfMnOcjqE1x12N254ABXjS0yfJwnQ== X-Received: by 10.31.88.1 with SMTP id m1mr26952373vkb.83.1481141027449; Wed, 07 Dec 2016 12:03:47 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: From: Andrew Senkevich Date: Wed, 07 Dec 2016 20:04:00 -0000 Message-ID: Subject: Re: [PATCH] Install libm.a as linker script [BZ #20539] To: "H.J. Lu" Cc: Andreas Schwab , libc-alpha Content-Type: multipart/mixed; boundary=001a114e5364ce2bb805431704eb X-SW-Source: 2016-12/txt/msg00254.txt.bz2 --001a114e5364ce2bb805431704eb Content-Type: text/plain; charset=UTF-8 Content-length: 3094 2016-12-07 19:21 GMT+03:00 H.J. Lu : > On Wed, Dec 7, 2016 at 2:34 AM, Andrew Senkevich > wrote: >> 2016-12-07 0:48 GMT+03:00 H.J. Lu : >>> On Tue, Dec 6, 2016 at 7:49 AM, Andrew Senkevich >>> wrote: >>>> 2016-12-06 18:21 GMT+03:00 Andreas Schwab : >>>>> On Dez 06 2016, Andrew Senkevich wrote: >>>>> >>>>>> 2016-12-06 17:17 GMT+03:00 Andreas Schwab : >>>>>>> On Dez 06 2016, Andrew Senkevich wrote: >>>>>>> >>>>>>>> +2016-12-06 Andrew Senkevich >>>>>>>> + >>>>>>>> + [BZ #20539] >>>>>>>> + * math/Makefile (install-lib-ldscripts): added libm.a. >>>>>>>> + ($(inst_libdir)/libm.a): added rule for installation as linker script. >>>>>>>> + * Makerules (install-lib.a): filter out install-lib-ldscripts. >>>>>>> >>>>>>> ChangeLog entries should be in present tense, and written as full >>>>>>> sentences. >>>>>> >>>>>> Which sentence is not full? >>>>> >>>>> Full sentences start with a capital. >>>> >>>> Oh yes of course, fixed. >>>> >>>> >>>> -- >>>> WBR, >>>> Andrew >>> >>> diff --git a/Makerules b/Makerules >>> index e865782..573c074 100644 >>> --- a/Makerules >>> +++ b/Makerules >>> @@ -1190,7 +1190,8 @@ $(addprefix $(inst_sbindir)/,$(install-sbin)): \ >>> $(do-install-program) >>> endif >>> ifdef install-lib >>> -install-lib.a := $(filter lib%.a,$(install-lib)) >>> +install-lib.a := $(filter-out libm.a,$(filter lib%.a,$(install-lib))) >>> +install-lib.a := $(filter-out $(install-lib-ldscripts),$(install-lib.a)) >>> >>> Need to filler out libm.a separately since it is in install-lib-ldscripts >>> already. >> >> Oh surely, attached. >> >> >> -- >> WBR, >> Andrew > > diff --git a/math/Makefile b/math/Makefile > index 848b093..77031b1 100644 > --- a/math/Makefile > +++ b/math/Makefile > @@ -128,10 +128,10 @@ generated += $(foreach s,.c .S,$(call > type-foreach, $(calls:s_%=m_%$(s)))) > routines = $(call type-foreach, $(calls)) > > ifeq ($(build-mathvec),yes) > -# We need to install libm.so as linker script > -# for more comfortable use of vector math library. > -install-lib-ldscripts := libm.so > -install_subdir: $(inst_libdir)/libm.so > +# We need to install libm.so and libm.a as linker scripts > +# for transparent use of vector math library. > +install-lib-ldscripts := libm.so libm.a > +install-others: $(inst_libdir)/libm.so $(inst_libdir)/libm.a > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > Here is install-others. > > $(inst_libdir)/libm.so: $(common-objpfx)format.lds \ > $(libm) \ > $(libmvec) \ > @@ -142,6 +142,18 @@ $(inst_libdir)/libm.so: $(common-objpfx)format.lds \ > 'AS_NEEDED ( $(libdir)/libmvec_nonshared.a > $(slibdir)/libmvec.so$(libmvec.so-version) ) )' \ > ) > $@.new > mv -f $@.new $@ > + > +install-others = $(inst_libdir)/libm.a > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > Is this needed? Indeed not needed. Tested with attached patch. -- WBR, Andrew --001a114e5364ce2bb805431704eb Content-Type: application/octet-stream; name="bz20539.patch" Content-Disposition: attachment; filename="bz20539.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iwfct8xo0 Content-length: 3087 ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBjY2Zk MGFlLi5hMjY0MTg5IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTEgQEAKKzIwMTYtMTItMDcgIEFuZHJldyBT ZW5rZXZpY2ggIDxhbmRyZXcuc2Vua2V2aWNoQGludGVsLmNvbT4KKworCVtC WiAjMjA1MzldCisJKiBtYXRoL01ha2VmaWxlIChpbnN0YWxsLWxpYi1sZHNj cmlwdHMpOiBBZGQgbGlibS5hLgorCSgkKGluc3RfbGliZGlyKS9saWJtLmEp OiBBZGQgcnVsZSBmb3IgaW5zdGFsbGF0aW9uIGFzCisJbGlua2VyIHNjcmlw dC4KKwkqIE1ha2VydWxlcyAoaW5zdGFsbC1saWIuYSk6IEZpbHRlciBvdXQg aW5zdGFsbC1saWItbGRzY3JpcHRzLgorCiAyMDE2LTEyLTA3ICBBbmRyZWFz IFNjaHdhYiAgPHNjaHdhYkBzdXNlLmRlPgogCiAJKiBzeXNkZXBzL3VuaXgv c3lzdi9saW51eC94ODYvZWxpc2lvbi1jb25mLmgKZGlmZiAtLWdpdCBhL01h a2VydWxlcyBiL01ha2VydWxlcwppbmRleCBlODY1NzgyLi43YWM2OTZlIDEw MDY0NAotLS0gYS9NYWtlcnVsZXMKKysrIGIvTWFrZXJ1bGVzCkBAIC0xMTkx LDYgKzExOTEsNyBAQCAkKGFkZHByZWZpeCAkKGluc3Rfc2JpbmRpcikvLCQo aW5zdGFsbC1zYmluKSk6IFwKIGVuZGlmCiBpZmRlZiBpbnN0YWxsLWxpYgog aW5zdGFsbC1saWIuYSA6PSAkKGZpbHRlciBsaWIlLmEsJChpbnN0YWxsLWxp YikpCitpbnN0YWxsLWxpYi5hIDo9ICQoZmlsdGVyLW91dCAkKGluc3RhbGwt bGliLWxkc2NyaXB0cyksJChpbnN0YWxsLWxpYi5hKSkKIGluc3RhbGwtbGli LW5vbi5hIDo9ICQoZmlsdGVyLW91dCBsaWIlLmEsJChpbnN0YWxsLWxpYikp CiBpZmRlZiBpbnN0YWxsLWxpYi1ub24uYQogJChhZGRwcmVmaXggJChpbnN0 X2xpYmRpcikvJChsaWJwcmVmaXgpLCQoaW5zdGFsbC1saWItbm9uLmEpKTog XApkaWZmIC0tZ2l0IGEvbWF0aC9NYWtlZmlsZSBiL21hdGgvTWFrZWZpbGUK aW5kZXggODQ4YjA5My4uNDk1NTZmNiAxMDA2NDQKLS0tIGEvbWF0aC9NYWtl ZmlsZQorKysgYi9tYXRoL01ha2VmaWxlCkBAIC0xMjgsMTAgKzEyOCwxMCBA QCBnZW5lcmF0ZWQgKz0gJChmb3JlYWNoIHMsLmMgLlMsJChjYWxsIHR5cGUt Zm9yZWFjaCwgJChjYWxsczpzXyU9bV8lJChzKSkpKQogcm91dGluZXMgPSAk KGNhbGwgdHlwZS1mb3JlYWNoLCAkKGNhbGxzKSkKIAogaWZlcSAoJChidWls ZC1tYXRodmVjKSx5ZXMpCi0jIFdlIG5lZWQgdG8gaW5zdGFsbCBsaWJtLnNv IGFzIGxpbmtlciBzY3JpcHQKLSMgZm9yIG1vcmUgY29tZm9ydGFibGUgdXNl IG9mIHZlY3RvciBtYXRoIGxpYnJhcnkuCi1pbnN0YWxsLWxpYi1sZHNjcmlw dHMgOj0gbGlibS5zbwotaW5zdGFsbF9zdWJkaXI6ICQoaW5zdF9saWJkaXIp L2xpYm0uc28KKyMgV2UgbmVlZCB0byBpbnN0YWxsIGxpYm0uc28gYW5kIGxp Ym0uYSBhcyBsaW5rZXIgc2NyaXB0cworIyBmb3IgdHJhbnNwYXJlbnQgdXNl IG9mIHZlY3RvciBtYXRoIGxpYnJhcnkuCitpbnN0YWxsLWxpYi1sZHNjcmlw dHMgOj0gbGlibS5zbyBsaWJtLmEKK2luc3RhbGwtb3RoZXJzID0gJChpbnN0 X2xpYmRpcikvbGlibS5zbyAkKGluc3RfbGliZGlyKS9saWJtLmEKICQoaW5z dF9saWJkaXIpL2xpYm0uc286ICQoY29tbW9uLW9ianBmeClmb3JtYXQubGRz IFwKIAkJCSQobGlibSkgXAogCQkJJChsaWJtdmVjKSBcCkBAIC0xNDIsNiAr MTQyLDE3IEBAICQoaW5zdF9saWJkaXIpL2xpYm0uc286ICQoY29tbW9uLW9i anBmeClmb3JtYXQubGRzIFwKIAkgICAgICAnQVNfTkVFREVEICggJChsaWJk aXIpL2xpYm12ZWNfbm9uc2hhcmVkLmEgJChzbGliZGlyKS9saWJtdmVjLnNv JChsaWJtdmVjLnNvLXZlcnNpb24pICkgKScgXAogCSkgPiAkQC5uZXcKIAlt diAtZiAkQC5uZXcgJEAKKworJChpbnN0X2xpYmRpcikvbGlibS5hOiAkKGNv bW1vbi1vYmpwZngpZm9ybWF0LmxkcyBcCisJCSAgICAgICAkKGxpYm0pIFwK KwkJICAgICAgICQobGlibXZlYykgXAorCQkgICAgICAgJCgrZm9yY2UpCisJ KGVjaG8gJy8qIEdOVSBsZCBzY3JpcHQnOyBlY2hvICcqLyc7XAorCSBjYXQg JDw7IFwKKwkgZWNobyAnR1JPVVAgKCAkKGxpYmRpcikvbGlibS0kKGxpYi12 ZXJzaW9uKS5hICQobGliZGlyKS9saWJtdmVjLmEgKScgXAorCSkgPiAkQC5u ZXcKKwljcCAkKG9ianBmeClsaWJtLmEgJChpbnN0X2xpYmRpcikvbGlibS0k KGxpYi12ZXJzaW9uKS5hCisJbXYgLWYgJEAubmV3ICRACiBlbmRpZgogCiAj IFJ1bGVzIGZvciB0aGUgdGVzdCBzdWl0ZS4K --001a114e5364ce2bb805431704eb--